Patchwork [meta-fsl-demos,1/3] packagegroup: rename to packagegroups

login
register
mail settings
Submitter Rogerio Nunes
Date Jan. 24, 2014, 11:45 p.m.
Message ID <1390607149-1853-2-git-send-email-ronunes@gmail.com>
Download mbox | patch
Permalink /patch/65793/
State Accepted
Delegated to: Otavio Salvador
Headers show

Comments

Rogerio Nunes - Jan. 24, 2014, 11:45 p.m.
From: Rogerio Nunes <rogerio.nunes@freescale.com>

For consistency with other layers, like poky and meta-openembedded,
it's better to have packagegroup(s) directory in the plural version.

This patch prepares the source tree to have the single packagegroup
file split into smaller recipes.

Change-Id: I28ed48fe00dc9cc3875a9029503456af7c4134e6
Signed-off-by: Rogerio Nunes <rogerio.nunes@freescale.com>
---
 recipes-fsl/packagegroup/packagegroup-fsl.bb  | 89 ---------------------------
 recipes-fsl/packagegroups/packagegroup-fsl.bb | 89 +++++++++++++++++++++++++++
 2 files changed, 89 insertions(+), 89 deletions(-)
 delete mode 100644 recipes-fsl/packagegroup/packagegroup-fsl.bb
 create mode 100644 recipes-fsl/packagegroups/packagegroup-fsl.bb
Fabio Estevam - Jan. 25, 2014, 1:39 p.m.
Hi Rogerio,

On Fri, Jan 24, 2014 at 9:45 PM,  <ronunes@gmail.com> wrote:
> From: Rogerio Nunes <rogerio.nunes@freescale.com>
>
> For consistency with other layers, like poky and meta-openembedded,
> it's better to have packagegroup(s) directory in the plural version.
>
> This patch prepares the source tree to have the single packagegroup
> file split into smaller recipes.
>
> Change-Id: I28ed48fe00dc9cc3875a9029503456af7c4134e6
> Signed-off-by: Rogerio Nunes <rogerio.nunes@freescale.com>
> ---
>  recipes-fsl/packagegroup/packagegroup-fsl.bb  | 89 ---------------------------
>  recipes-fsl/packagegroups/packagegroup-fsl.bb | 89 +++++++++++++++++++++++++++

When doing file renames in git it is better to use 'git mv' and then
generate the patch via 'git format patch -M'.

Then the git statistics will present it as a simple file rename change
rather than 89 additions and 89 deletions.

Regards,

Fabio Estevam
Rogerio Nunes - Jan. 25, 2014, 6:53 p.m.
Thanks Fabio,

I used git mv, but indeed forgot to use git format-pacth with -M...

I'll be careful next time.

Regards,
Rogerio.


On Sat, Jan 25, 2014 at 8:39 AM, Fabio Estevam <festevam@gmail.com> wrote:

> Hi Rogerio,
>
> On Fri, Jan 24, 2014 at 9:45 PM,  <ronunes@gmail.com> wrote:
> > From: Rogerio Nunes <rogerio.nunes@freescale.com>
> >
> > For consistency with other layers, like poky and meta-openembedded,
> > it's better to have packagegroup(s) directory in the plural version.
> >
> > This patch prepares the source tree to have the single packagegroup
> > file split into smaller recipes.
> >
> > Change-Id: I28ed48fe00dc9cc3875a9029503456af7c4134e6
> > Signed-off-by: Rogerio Nunes <rogerio.nunes@freescale.com>
> > ---
> >  recipes-fsl/packagegroup/packagegroup-fsl.bb  | 89
> ---------------------------
> >  recipes-fsl/packagegroups/packagegroup-fsl.bb | 89
> +++++++++++++++++++++++++++
>
> When doing file renames in git it is better to use 'git mv' and then
> generate the patch via 'git format patch -M'.
>
> Then the git statistics will present it as a simple file rename change
> rather than 89 additions and 89 deletions.
>
> Regards,
>
> Fabio Estevam
>
Daiane Angolini - Jan. 25, 2014, 7:15 p.m.
On Fri, Jan 24, 2014 at 9:45 PM,  <ronunes@gmail.com> wrote:
> From: Rogerio Nunes <rogerio.nunes@freescale.com>
>
> For consistency with other layers, like poky and meta-openembedded,
> it's better to have packagegroup(s) directory in the plural version.
>
> This patch prepares the source tree to have the single packagegroup
> file split into smaller recipes.

It's nice to see a long commit log, thanks a lot.


reviewed


Daiane
>
> Change-Id: I28ed48fe00dc9cc3875a9029503456af7c4134e6
> Signed-off-by: Rogerio Nunes <rogerio.nunes@freescale.com>
> ---
>  recipes-fsl/packagegroup/packagegroup-fsl.bb  | 89 ---------------------------
>  recipes-fsl/packagegroups/packagegroup-fsl.bb | 89 +++++++++++++++++++++++++++
>  2 files changed, 89 insertions(+), 89 deletions(-)
>  delete mode 100644 recipes-fsl/packagegroup/packagegroup-fsl.bb
>  create mode 100644 recipes-fsl/packagegroups/packagegroup-fsl.bb
>
> diff --git a/recipes-fsl/packagegroup/packagegroup-fsl.bb b/recipes-fsl/packagegroup/packagegroup-fsl.bb
> deleted file mode 100644
> index 80ce5a4..0000000
> --- a/recipes-fsl/packagegroup/packagegroup-fsl.bb
> +++ /dev/null
> @@ -1,89 +0,0 @@
> -# Copyright (C) 2012-2013 Freescale Semiconductor
> -# Released under the MIT license (see COPYING.MIT for the terms)
> -
> -DESCRIPTION = "Freescale package group"
> -LICENSE = "MIT"
> -LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
> -                    file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
> -
> -PR = "r5"
> -
> -inherit packagegroup
> -
> -PROVIDES = "${PACKAGES}"
> -PACKAGES += " \
> -    ${PN}-gstreamer \
> -    ${PN}-gstreamer-streamer \
> -    ${PN}-tools-testapps \
> -    ${PN}-tools-benchmark \
> -"
> -
> -MACHINE_GSTREAMER_PLUGIN ?= ""
> -
> -RDEPENDS_${PN}-gstreamer = " \
> -    gst-meta-audio \
> -    gst-meta-video \
> -    gst-meta-debug \
> -    gst-plugins-good-meta \
> -    ${MACHINE_GSTREAMER_PLUGIN} \
> -"
> -
> -RDEPENDS_${PN}-gstreamer-streamer = " \
> -    ${PN}-gstreamer \
> -    gst-plugins-good-udp \
> -    gst-plugins-good-rtp \
> -    gst-plugins-good-rtpmanager \
> -    gst-plugins-good-rtsp \
> -"
> -
> -SOC_TOOLS_TESTAPPS = ""
> -SOC_TOOLS_TESTAPPS_mx5 = " \
> -    amd-gpu-x11-bin-mx51 \
> -"
> -
> -SOC_TOOLS_TESTAPPS_mx6 = " \
> -    gpu-viv-bin-mx6q \
> -"
> -
> -RDEPENDS_${PN}-tools-testapps = " \
> -    ${SOC_TOOLS_TESTAPPS} \
> -    ${@base_contains("MACHINE_GSTREAMER_PLUGIN", "gst-fsl-plugin", "gst-fsl-plugin-gplay", "", d)} \
> -    alsa-utils \
> -    alsa-tools \
> -    dosfstools \
> -    evtest \
> -    e2fsprogs-mke2fs \
> -    fsl-rc-local \
> -    gst-plugins-base-tcp \
> -    i2c-tools \
> -    imx-test \
> -    iproute2 \
> -    memtester \
> -    python-subprocess \
> -    python-datetime \
> -    python-json \
> -    ${@base_contains('DISTRO_FEATURES', 'x11', 'v4l-utils', '', d)} \
> -    ethtool \
> -    mtd-utils \
> -    mtd-utils-ubifs \
> -"
> -
> -RDEPENDS_${PN}-tools-benchmark = " \
> -    lmbench \
> -    bonnie++ \
> -    dbench \
> -    fio \
> -    iozone3 \
> -    iperf \
> -    nbench-byte \
> -    tiobench \
> -    "
> -# Disabled as it has CRC problems in denzil branch
> -#    cpuburn-neon
> -
> -ALLOW_EMPTY_${PN} = "1"
> -ALLOW_EMPTY_${PN}-gstreamer = "1"
> -ALLOW_EMPTY_${PN}-tools-testapps = "1"
> -ALLOW_EMPTY_${PN}-tools-benchmark = "1"
> -
> -PACKAGE_ARCH = "${MACHINE_ARCH}"
> diff --git a/recipes-fsl/packagegroups/packagegroup-fsl.bb b/recipes-fsl/packagegroups/packagegroup-fsl.bb
> new file mode 100644
> index 0000000..80ce5a4
> --- /dev/null
> +++ b/recipes-fsl/packagegroups/packagegroup-fsl.bb
> @@ -0,0 +1,89 @@
> +# Copyright (C) 2012-2013 Freescale Semiconductor
> +# Released under the MIT license (see COPYING.MIT for the terms)
> +
> +DESCRIPTION = "Freescale package group"
> +LICENSE = "MIT"
> +LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
> +                    file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
> +
> +PR = "r5"
> +
> +inherit packagegroup
> +
> +PROVIDES = "${PACKAGES}"
> +PACKAGES += " \
> +    ${PN}-gstreamer \
> +    ${PN}-gstreamer-streamer \
> +    ${PN}-tools-testapps \
> +    ${PN}-tools-benchmark \
> +"
> +
> +MACHINE_GSTREAMER_PLUGIN ?= ""
> +
> +RDEPENDS_${PN}-gstreamer = " \
> +    gst-meta-audio \
> +    gst-meta-video \
> +    gst-meta-debug \
> +    gst-plugins-good-meta \
> +    ${MACHINE_GSTREAMER_PLUGIN} \
> +"
> +
> +RDEPENDS_${PN}-gstreamer-streamer = " \
> +    ${PN}-gstreamer \
> +    gst-plugins-good-udp \
> +    gst-plugins-good-rtp \
> +    gst-plugins-good-rtpmanager \
> +    gst-plugins-good-rtsp \
> +"
> +
> +SOC_TOOLS_TESTAPPS = ""
> +SOC_TOOLS_TESTAPPS_mx5 = " \
> +    amd-gpu-x11-bin-mx51 \
> +"
> +
> +SOC_TOOLS_TESTAPPS_mx6 = " \
> +    gpu-viv-bin-mx6q \
> +"
> +
> +RDEPENDS_${PN}-tools-testapps = " \
> +    ${SOC_TOOLS_TESTAPPS} \
> +    ${@base_contains("MACHINE_GSTREAMER_PLUGIN", "gst-fsl-plugin", "gst-fsl-plugin-gplay", "", d)} \
> +    alsa-utils \
> +    alsa-tools \
> +    dosfstools \
> +    evtest \
> +    e2fsprogs-mke2fs \
> +    fsl-rc-local \
> +    gst-plugins-base-tcp \
> +    i2c-tools \
> +    imx-test \
> +    iproute2 \
> +    memtester \
> +    python-subprocess \
> +    python-datetime \
> +    python-json \
> +    ${@base_contains('DISTRO_FEATURES', 'x11', 'v4l-utils', '', d)} \
> +    ethtool \
> +    mtd-utils \
> +    mtd-utils-ubifs \
> +"
> +
> +RDEPENDS_${PN}-tools-benchmark = " \
> +    lmbench \
> +    bonnie++ \
> +    dbench \
> +    fio \
> +    iozone3 \
> +    iperf \
> +    nbench-byte \
> +    tiobench \
> +    "
> +# Disabled as it has CRC problems in denzil branch
> +#    cpuburn-neon
> +
> +ALLOW_EMPTY_${PN} = "1"
> +ALLOW_EMPTY_${PN}-gstreamer = "1"
> +ALLOW_EMPTY_${PN}-tools-testapps = "1"
> +ALLOW_EMPTY_${PN}-tools-benchmark = "1"
> +
> +PACKAGE_ARCH = "${MACHINE_ARCH}"
> --
> 1.8.3.2
>
> _______________________________________________
> meta-freescale mailing list
> meta-freescale@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-freescale

Patch

diff --git a/recipes-fsl/packagegroup/packagegroup-fsl.bb b/recipes-fsl/packagegroup/packagegroup-fsl.bb
deleted file mode 100644
index 80ce5a4..0000000
--- a/recipes-fsl/packagegroup/packagegroup-fsl.bb
+++ /dev/null
@@ -1,89 +0,0 @@ 
-# Copyright (C) 2012-2013 Freescale Semiconductor
-# Released under the MIT license (see COPYING.MIT for the terms)
-
-DESCRIPTION = "Freescale package group"
-LICENSE = "MIT"
-LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
-                    file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
-
-PR = "r5"
-
-inherit packagegroup
-
-PROVIDES = "${PACKAGES}"
-PACKAGES += " \
-    ${PN}-gstreamer \
-    ${PN}-gstreamer-streamer \
-    ${PN}-tools-testapps \
-    ${PN}-tools-benchmark \
-"
-
-MACHINE_GSTREAMER_PLUGIN ?= ""
-
-RDEPENDS_${PN}-gstreamer = " \
-    gst-meta-audio \
-    gst-meta-video \
-    gst-meta-debug \
-    gst-plugins-good-meta \
-    ${MACHINE_GSTREAMER_PLUGIN} \
-"
-
-RDEPENDS_${PN}-gstreamer-streamer = " \
-    ${PN}-gstreamer \
-    gst-plugins-good-udp \
-    gst-plugins-good-rtp \
-    gst-plugins-good-rtpmanager \
-    gst-plugins-good-rtsp \
-"
-
-SOC_TOOLS_TESTAPPS = ""
-SOC_TOOLS_TESTAPPS_mx5 = " \
-    amd-gpu-x11-bin-mx51 \
-"
-
-SOC_TOOLS_TESTAPPS_mx6 = " \
-    gpu-viv-bin-mx6q \
-"
-
-RDEPENDS_${PN}-tools-testapps = " \
-    ${SOC_TOOLS_TESTAPPS} \
-    ${@base_contains("MACHINE_GSTREAMER_PLUGIN", "gst-fsl-plugin", "gst-fsl-plugin-gplay", "", d)} \
-    alsa-utils \
-    alsa-tools \
-    dosfstools \
-    evtest \
-    e2fsprogs-mke2fs \
-    fsl-rc-local \
-    gst-plugins-base-tcp \
-    i2c-tools \
-    imx-test \
-    iproute2 \
-    memtester \
-    python-subprocess \
-    python-datetime \
-    python-json \
-    ${@base_contains('DISTRO_FEATURES', 'x11', 'v4l-utils', '', d)} \
-    ethtool \
-    mtd-utils \
-    mtd-utils-ubifs \
-"
-
-RDEPENDS_${PN}-tools-benchmark = " \
-    lmbench \
-    bonnie++ \
-    dbench \
-    fio \
-    iozone3 \
-    iperf \
-    nbench-byte \
-    tiobench \
-    "
-# Disabled as it has CRC problems in denzil branch
-#    cpuburn-neon
-
-ALLOW_EMPTY_${PN} = "1"
-ALLOW_EMPTY_${PN}-gstreamer = "1"
-ALLOW_EMPTY_${PN}-tools-testapps = "1"
-ALLOW_EMPTY_${PN}-tools-benchmark = "1"
-
-PACKAGE_ARCH = "${MACHINE_ARCH}"
diff --git a/recipes-fsl/packagegroups/packagegroup-fsl.bb b/recipes-fsl/packagegroups/packagegroup-fsl.bb
new file mode 100644
index 0000000..80ce5a4
--- /dev/null
+++ b/recipes-fsl/packagegroups/packagegroup-fsl.bb
@@ -0,0 +1,89 @@ 
+# Copyright (C) 2012-2013 Freescale Semiconductor
+# Released under the MIT license (see COPYING.MIT for the terms)
+
+DESCRIPTION = "Freescale package group"
+LICENSE = "MIT"
+LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
+                    file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
+
+PR = "r5"
+
+inherit packagegroup
+
+PROVIDES = "${PACKAGES}"
+PACKAGES += " \
+    ${PN}-gstreamer \
+    ${PN}-gstreamer-streamer \
+    ${PN}-tools-testapps \
+    ${PN}-tools-benchmark \
+"
+
+MACHINE_GSTREAMER_PLUGIN ?= ""
+
+RDEPENDS_${PN}-gstreamer = " \
+    gst-meta-audio \
+    gst-meta-video \
+    gst-meta-debug \
+    gst-plugins-good-meta \
+    ${MACHINE_GSTREAMER_PLUGIN} \
+"
+
+RDEPENDS_${PN}-gstreamer-streamer = " \
+    ${PN}-gstreamer \
+    gst-plugins-good-udp \
+    gst-plugins-good-rtp \
+    gst-plugins-good-rtpmanager \
+    gst-plugins-good-rtsp \
+"
+
+SOC_TOOLS_TESTAPPS = ""
+SOC_TOOLS_TESTAPPS_mx5 = " \
+    amd-gpu-x11-bin-mx51 \
+"
+
+SOC_TOOLS_TESTAPPS_mx6 = " \
+    gpu-viv-bin-mx6q \
+"
+
+RDEPENDS_${PN}-tools-testapps = " \
+    ${SOC_TOOLS_TESTAPPS} \
+    ${@base_contains("MACHINE_GSTREAMER_PLUGIN", "gst-fsl-plugin", "gst-fsl-plugin-gplay", "", d)} \
+    alsa-utils \
+    alsa-tools \
+    dosfstools \
+    evtest \
+    e2fsprogs-mke2fs \
+    fsl-rc-local \
+    gst-plugins-base-tcp \
+    i2c-tools \
+    imx-test \
+    iproute2 \
+    memtester \
+    python-subprocess \
+    python-datetime \
+    python-json \
+    ${@base_contains('DISTRO_FEATURES', 'x11', 'v4l-utils', '', d)} \
+    ethtool \
+    mtd-utils \
+    mtd-utils-ubifs \
+"
+
+RDEPENDS_${PN}-tools-benchmark = " \
+    lmbench \
+    bonnie++ \
+    dbench \
+    fio \
+    iozone3 \
+    iperf \
+    nbench-byte \
+    tiobench \
+    "
+# Disabled as it has CRC problems in denzil branch
+#    cpuburn-neon
+
+ALLOW_EMPTY_${PN} = "1"
+ALLOW_EMPTY_${PN}-gstreamer = "1"
+ALLOW_EMPTY_${PN}-tools-testapps = "1"
+ALLOW_EMPTY_${PN}-tools-benchmark = "1"
+
+PACKAGE_ARCH = "${MACHINE_ARCH}"