Patchwork [meta-fsl-demos,3/3] packagegroup-fsl-tools-testapps: Use amd-gpu-x11-bin-mx51 only with X11

login
register
mail settings
Submitter Rogerio Nunes
Date Jan. 24, 2014, 11:45 p.m.
Message ID <1390607149-1853-4-git-send-email-ronunes@gmail.com>
Download mbox | patch
Permalink /patch/65791/
State Changes Requested
Delegated to: Otavio Salvador
Headers show

Comments

Rogerio Nunes - Jan. 24, 2014, 11:45 p.m.
From: Rogerio Nunes <rogerio.nunes@freescale.com>

Package amd-gpu-x11-bin-mx51 only works if X11 is in
DISTRO_FEATURES, and it should not be installed otherwise.

Change-Id: I526018066de9b7a7d4fd29c65833e5d5d2487884
Signed-off-by: Rogerio Nunes <rogerio.nunes@freescale.com>
---
 recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Otavio Salvador - Jan. 25, 2014, 6:48 p.m.
Hello Rogerio,

On Fri, Jan 24, 2014 at 9:45 PM,  <ronunes@gmail.com> wrote:
> From: Rogerio Nunes <rogerio.nunes@freescale.com>
>
> Package amd-gpu-x11-bin-mx51 only works if X11 is in
> DISTRO_FEATURES, and it should not be installed otherwise.
>
> Change-Id: I526018066de9b7a7d4fd29c65833e5d5d2487884
> Signed-off-by: Rogerio Nunes <rogerio.nunes@freescale.com>
> ---
>  recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb b/recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb
> index 8643991..1fc88e8 100644
> --- a/recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb
> +++ b/recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb
> @@ -10,7 +10,7 @@ inherit packagegroup
>
>  SOC_TOOLS_TESTAPPS = ""
>  SOC_TOOLS_TESTAPPS_mx5 = " \
> -    amd-gpu-x11-bin-mx51 \
> +    ${@base_contains('DISTRO_FEATURES', 'x11', 'amd-gpu-x11-bin-mx51', 'amd-gpu-bin-mx51', d)}
>  "

This will fail at parsing; you forgot the add the \ at end of line.
Otavio Salvador - Jan. 25, 2014, 6:49 p.m.
On Sat, Jan 25, 2014 at 4:48 PM, Otavio Salvador
<otavio@ossystems.com.br> wrote:
> Hello Rogerio,
>
> On Fri, Jan 24, 2014 at 9:45 PM,  <ronunes@gmail.com> wrote:
>> From: Rogerio Nunes <rogerio.nunes@freescale.com>
>>
>> Package amd-gpu-x11-bin-mx51 only works if X11 is in
>> DISTRO_FEATURES, and it should not be installed otherwise.
>>
>> Change-Id: I526018066de9b7a7d4fd29c65833e5d5d2487884
>> Signed-off-by: Rogerio Nunes <rogerio.nunes@freescale.com>
>> ---
>>  recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb b/recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb
>> index 8643991..1fc88e8 100644
>> --- a/recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb
>> +++ b/recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb
>> @@ -10,7 +10,7 @@ inherit packagegroup
>>
>>  SOC_TOOLS_TESTAPPS = ""
>>  SOC_TOOLS_TESTAPPS_mx5 = " \
>> -    amd-gpu-x11-bin-mx51 \
>> +    ${@base_contains('DISTRO_FEATURES', 'x11', 'amd-gpu-x11-bin-mx51', 'amd-gpu-bin-mx51', d)}
>>  "
>
> This will fail at parsing; you forgot the add the \ at end of line.

I fixed it locally.
Rogerio Nunes - Jan. 25, 2014, 6:57 p.m.
On Sat, Jan 25, 2014 at 1:49 PM, Otavio Salvador
<otavio@ossystems.com.br> wrote:
>
> On Sat, Jan 25, 2014 at 4:48 PM, Otavio Salvador
> <otavio@ossystems.com.br> wrote:
> > Hello Rogerio,
> >
> > On Fri, Jan 24, 2014 at 9:45 PM,  <ronunes@gmail.com> wrote:
> >> From: Rogerio Nunes <rogerio.nunes@freescale.com>
> >>
> >> Package amd-gpu-x11-bin-mx51 only works if X11 is in
> >> DISTRO_FEATURES, and it should not be installed otherwise.
> >>
> >> Change-Id: I526018066de9b7a7d4fd29c65833e5d5d2487884
> >> Signed-off-by: Rogerio Nunes <rogerio.nunes@freescale.com>
> >> ---
> >>  recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb b/recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb
> >> index 8643991..1fc88e8 100644
> >> --- a/recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb
> >> +++ b/recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb
> >> @@ -10,7 +10,7 @@ inherit packagegroup
> >>
> >>  SOC_TOOLS_TESTAPPS = ""
> >>  SOC_TOOLS_TESTAPPS_mx5 = " \
> >> -    amd-gpu-x11-bin-mx51 \
> >> +    ${@base_contains('DISTRO_FEATURES', 'x11', 'amd-gpu-x11-bin-mx51', 'amd-gpu-bin-mx51', d)}
> >>  "
> >
> > This will fail at parsing; you forgot the add the \ at end of line.
>
> I fixed it locally.

Thanks!! V2 was ready just in case :)

>
> --
> Otavio Salvador                             O.S. Systems
> http://www.ossystems.com.br        http://code.ossystems.com.br
> Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Patch

diff --git a/recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb b/recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb
index 8643991..1fc88e8 100644
--- a/recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb
+++ b/recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb
@@ -10,7 +10,7 @@  inherit packagegroup
 
 SOC_TOOLS_TESTAPPS = ""
 SOC_TOOLS_TESTAPPS_mx5 = " \
-    amd-gpu-x11-bin-mx51 \
+    ${@base_contains('DISTRO_FEATURES', 'x11', 'amd-gpu-x11-bin-mx51', 'amd-gpu-bin-mx51', d)}
 "
 
 SOC_TOOLS_TESTAPPS_mx6 = " \