Patchwork [meta-fsl-arm-extra,v3,1/3] cubox-i: add u-boot fork for cubox-i machines

login
register
mail settings
Submitter dv
Date Jan. 24, 2014, 7:57 p.m.
Message ID <1390593479-25184-1-git-send-email-dv@pseudoterminal.org>
Download mbox | patch
Permalink /patch/65783/
State Changes Requested
Delegated to: Otavio Salvador
Headers show

Comments

dv - Jan. 24, 2014, 7:57 p.m.
This fork includes MXC SPL support for the SolidRun CuBox-i and
HummingBoard devices

Signed-off-by: Carlos Rafael Giani <dv@pseudoterminal.org>
---
 recipes-bsp/u-boot/u-boot-cubox-i/uEnv.txt   |  1 +
 recipes-bsp/u-boot/u-boot-cubox-i_2013.10.bb | 28 ++++++++++++++++++++++++++++
 2 files changed, 29 insertions(+)
 create mode 100644 recipes-bsp/u-boot/u-boot-cubox-i/uEnv.txt
 create mode 100644 recipes-bsp/u-boot/u-boot-cubox-i_2013.10.bb
Otavio Salvador - Jan. 24, 2014, 9:44 p.m.
Hello Carlos,

Comments inline ...

On Fri, Jan 24, 2014 at 5:57 PM, Carlos Rafael Giani
<dv@pseudoterminal.org> wrote:
> This fork includes MXC SPL support for the SolidRun CuBox-i and
> HummingBoard devices
>
> Signed-off-by: Carlos Rafael Giani <dv@pseudoterminal.org>
> ---
>  recipes-bsp/u-boot/u-boot-cubox-i/uEnv.txt   |  1 +
>  recipes-bsp/u-boot/u-boot-cubox-i_2013.10.bb | 28 ++++++++++++++++++++++++++++
>  2 files changed, 29 insertions(+)
>  create mode 100644 recipes-bsp/u-boot/u-boot-cubox-i/uEnv.txt
>  create mode 100644 recipes-bsp/u-boot/u-boot-cubox-i_2013.10.bb
>
> diff --git a/recipes-bsp/u-boot/u-boot-cubox-i/uEnv.txt b/recipes-bsp/u-boot/u-boot-cubox-i/uEnv.txt
> new file mode 100644
> index 0000000..3ae0863
> --- /dev/null
> +++ b/recipes-bsp/u-boot/u-boot-cubox-i/uEnv.txt
> @@ -0,0 +1 @@
> +mmcargs=setenv bootargs console=${console},${baudrate} root=${mmcroot} video=mxcfb0:dev=hdmi,1920x1080M@60,if=RGB24,bpp=32
> diff --git a/recipes-bsp/u-boot/u-boot-cubox-i_2013.10.bb b/recipes-bsp/u-boot/u-boot-cubox-i_2013.10.bb
> new file mode 100644
> index 0000000..6a0d3e6
> --- /dev/null
> +++ b/recipes-bsp/u-boot/u-boot-cubox-i_2013.10.bb
> @@ -0,0 +1,28 @@
> +require recipes-bsp/u-boot/u-boot.inc
> +
> +LICENSE = "GPLv2+"
> +LIC_FILES_CHKSUM = "file://Licenses/README;md5=bc069111b5e5b1ed8bed98ae73b596ec"
> +COMPATIBLE_MACHINE = "cubox-i"

COMPATIBLE_MACHINE at end of file.

> +PROVIDES += "u-boot"
> +
> +SRCREV = "920ea0f20276614e11961924b1990b6c922c8d0e"
> +
> +PV = "v2013.10+git${SRCPV}"
> +

I'd put SRCREV right above SRC_URI.

> +SRC_URI = " \
> +    git://github.com/rabeeh/u-boot-imx6.git;branch=imx6 \
> +    file://uEnv.txt \
> +    "
> +
> +S = "${WORKDIR}/git"
> +
> +PACKAGE_ARCH = "${MACHINE_ARCH}"

At  end of file, just before COMPATIBLE_MACHINE.

> +UENV_FILENAME ?= "uEnv-${MACHINE}.txt"
> +
> +deploy_uenv () {
> +    install ${WORKDIR}/uEnv.txt ${DEPLOYDIR}/${UENV_FILENAME}
> +}
> +
> +do_deploy[postfuncs] += "deploy_uenv"
dv - Jan. 27, 2014, 11:36 a.m.
On 2014-01-24 22:44, Otavio Salvador wrote:
>> +SRC_URI = " \
>> +    git://github.com/rabeeh/u-boot-imx6.git;branch=imx6 \
>> +    file://uEnv.txt \
>> +    "
>> +
>> +S = "${WORKDIR}/git"
>> +
>> +PACKAGE_ARCH = "${MACHINE_ARCH}"
> At  end of file, just before COMPATIBLE_MACHINE.
>

Also SRC_URI at the end? Or just S and PACKAGE_ARCH? Because, in the 
u-boot-imx script, SRC_URI is not at the end..

Before I re-send patches, let me show you the updated structure here:


require recipes-bsp/u-boot/u-boot.inc

LICENSE = "GPLv2+"
LIC_FILES_CHKSUM = 
"file://Licenses/README;md5=bc069111b5e5b1ed8bed98ae73b596ec"

PROVIDES += "u-boot"

PV = "v2013.10+git${SRCPV}"

SRCREV = "920ea0f20276614e11961924b1990b6c922c8d0e"
SRC_URI = " \
     git://github.com/rabeeh/u-boot-imx6.git;branch=imx6 \
     file://uEnv.txt \
     "

UENV_FILENAME ?= "uEnv-${MACHINE}.txt"

deploy_uenv () {
     install ${WORKDIR}/uEnv.txt ${DEPLOYDIR}/${UENV_FILENAME}
}

do_deploy[postfuncs] += "deploy_uenv"

S = "${WORKDIR}/git"

PACKAGE_ARCH = "${MACHINE_ARCH}"
COMPATIBLE_MACHINE = "cubox-i"


Is this okay?
Otavio Salvador - Jan. 27, 2014, noon
Hello Carlos,

On Mon, Jan 27, 2014 at 9:36 AM, Carlos Rafael Giani
<dv@pseudoterminal.org> wrote:
> On 2014-01-24 22:44, Otavio Salvador wrote:
>>>
>>> +SRC_URI = " \
>>> +    git://github.com/rabeeh/u-boot-imx6.git;branch=imx6 \
>>> +    file://uEnv.txt \
>>> +    "
>>> +
>>> +S = "${WORKDIR}/git"
>>> +
>>> +PACKAGE_ARCH = "${MACHINE_ARCH}"
>>
>> At  end of file, just before COMPATIBLE_MACHINE.
>>
>
> Also SRC_URI at the end? Or just S and PACKAGE_ARCH? Because, in the
> u-boot-imx script, SRC_URI is not at the end..

No, just PACKAGE_ARCH.

> Before I re-send patches, let me show you the updated structure here:
>
>
> require recipes-bsp/u-boot/u-boot.inc
>
> LICENSE = "GPLv2+"
> LIC_FILES_CHKSUM =
> "file://Licenses/README;md5=bc069111b5e5b1ed8bed98ae73b596ec"
>
> PROVIDES += "u-boot"
>
> PV = "v2013.10+git${SRCPV}"
>
> SRCREV = "920ea0f20276614e11961924b1990b6c922c8d0e"
> SRC_URI = " \
>     git://github.com/rabeeh/u-boot-imx6.git;branch=imx6 \
>     file://uEnv.txt \
>     "
>
> UENV_FILENAME ?= "uEnv-${MACHINE}.txt"
>
> deploy_uenv () {
>
>     install ${WORKDIR}/uEnv.txt ${DEPLOYDIR}/${UENV_FILENAME}
> }
>
> do_deploy[postfuncs] += "deploy_uenv"
>
> S = "${WORKDIR}/git"
>
> PACKAGE_ARCH = "${MACHINE_ARCH}"
> COMPATIBLE_MACHINE = "cubox-i"
>
>
> Is this okay?

No:

 require recipes-bsp/u-boot/u-boot.inc

 LICENSE = "GPLv2+"
 LIC_FILES_CHKSUM =
 "file://Licenses/README;md5=bc069111b5e5b1ed8bed98ae73b596ec"

 PROVIDES += "u-boot"

 PV = "v2013.10+git${SRCPV}"

 SRCREV = "920ea0f20276614e11961924b1990b6c922c8d0e"
 SRC_URI = " \
     git://github.com/rabeeh/u-boot-imx6.git;branch=imx6 \
     file://uEnv.txt \
     "

 S = "${WORKDIR}/git"

 UENV_FILENAME ?= "uEnv-${MACHINE}.txt"

 deploy_uenv () {
     install ${WORKDIR}/uEnv.txt ${DEPLOYDIR}/${UENV_FILENAME}
 }

 do_deploy[postfuncs] += "deploy_uenv"

 PACKAGE_ARCH = "${MACHINE_ARCH}"
 COMPATIBLE_MACHINE = "cubox-i"

Patch

diff --git a/recipes-bsp/u-boot/u-boot-cubox-i/uEnv.txt b/recipes-bsp/u-boot/u-boot-cubox-i/uEnv.txt
new file mode 100644
index 0000000..3ae0863
--- /dev/null
+++ b/recipes-bsp/u-boot/u-boot-cubox-i/uEnv.txt
@@ -0,0 +1 @@ 
+mmcargs=setenv bootargs console=${console},${baudrate} root=${mmcroot} video=mxcfb0:dev=hdmi,1920x1080M@60,if=RGB24,bpp=32
diff --git a/recipes-bsp/u-boot/u-boot-cubox-i_2013.10.bb b/recipes-bsp/u-boot/u-boot-cubox-i_2013.10.bb
new file mode 100644
index 0000000..6a0d3e6
--- /dev/null
+++ b/recipes-bsp/u-boot/u-boot-cubox-i_2013.10.bb
@@ -0,0 +1,28 @@ 
+require recipes-bsp/u-boot/u-boot.inc
+
+LICENSE = "GPLv2+"
+LIC_FILES_CHKSUM = "file://Licenses/README;md5=bc069111b5e5b1ed8bed98ae73b596ec"
+COMPATIBLE_MACHINE = "cubox-i"
+
+PROVIDES += "u-boot"
+
+SRCREV = "920ea0f20276614e11961924b1990b6c922c8d0e"
+
+PV = "v2013.10+git${SRCPV}"
+
+SRC_URI = " \
+    git://github.com/rabeeh/u-boot-imx6.git;branch=imx6 \
+    file://uEnv.txt \
+    "
+
+S = "${WORKDIR}/git"
+
+PACKAGE_ARCH = "${MACHINE_ARCH}"
+
+UENV_FILENAME ?= "uEnv-${MACHINE}.txt"
+
+deploy_uenv () {
+    install ${WORKDIR}/uEnv.txt ${DEPLOYDIR}/${UENV_FILENAME}
+}
+
+do_deploy[postfuncs] += "deploy_uenv"