Patchwork [1/1] am-benchmarks: Remove platform dependencies

login
register
mail settings
Submitter Jeff Lance
Date June 27, 2011, 10:35 p.m.
Message ID <1309214125-3523-1-git-send-email-j-lance1@ti.com>
Download mbox | patch
Permalink /patch/6575/
State Superseded
Headers show

Comments

Jeff Lance - June 27, 2011, 10:35 p.m.
* Remove platform dependencies and use architecture dependencies instead
* Use OE BASE_PACKAGE_ARCH to determine architecture
* Update the SRCREV to revision 65
* Update the recipe revision to 1.3
NOTE - architecure dependency and INSANE_SKIP can be removed once CFLAGS can be passed into CCSv5 project makefile

Signed-off-by: Jeff Lance <j-lance1@ti.com>
---
 recipes/ti/am-benchmarks_1.3.bb |   31 +++++++++++++++++++++++++++++++
 1 files changed, 31 insertions(+), 0 deletions(-)
 create mode 100644 recipes/ti/am-benchmarks_1.3.bb
Koen Kooi - June 28, 2011, 6:56 a.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 28-06-11 00:35, Jeff Lance wrote:
> * Remove platform dependencies and use architecture dependencies instead
> * Use OE BASE_PACKAGE_ARCH to determine architecture
> * Update the SRCREV to revision 65
> * Update the recipe revision to 1.3
> NOTE - architecure dependency and INSANE_SKIP can be removed once CFLAGS can be passed into CCSv5 project makefile

NAK, patch the makefiles in OE to work with CFLAGS and LDFLAGS.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFOCXsfMkyGM64RGpERAukZAJ9h255ZZXglaxGDa9NacD+P/VoDwACeMC8u
VDbzOnP2HcuoztWijKjWjqI=
=nFoX
-----END PGP SIGNATURE-----
Jeff Lance - June 28, 2011, 2 p.m.
Koen,

We are using makefiles generated by CCSv5.  CCSv5 auto generates its own
build support files with CFLAGS embedded.  We plan to pass in CFLAGS from
Arago into our SDK environment setting.  But it was decided not to resolve
that issue until the next release. This patch fixes an issue where the
Makefile was not at the top level.

On Tue, Jun 28, 2011 at 1:56 AM, Koen Kooi <koen@dominion.thruhere.net>wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 28-06-11 00:35, Jeff Lance wrote:
> > * Remove platform dependencies and use architecture dependencies instead
> > * Use OE BASE_PACKAGE_ARCH to determine architecture
> > * Update the SRCREV to revision 65
> > * Update the recipe revision to 1.3
> > NOTE - architecure dependency and INSANE_SKIP can be removed once CFLAGS
> can be passed into CCSv5 project makefile
>
> NAK, patch the makefiles in OE to work with CFLAGS and LDFLAGS.
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.5 (Darwin)
>
> iD8DBQFOCXsfMkyGM64RGpERAukZAJ9h255ZZXglaxGDa9NacD+P/VoDwACeMC8u
> VDbzOnP2HcuoztWijKjWjqI=
> =nFoX
> -----END PGP SIGNATURE-----
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>
Koen Kooi - June 28, 2011, 2:12 p.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 28-06-11 16:00, Jeff Lance wrote:
> Koen,
> 
> We are using makefiles generated by CCSv5.  CCSv5 auto generates its own
> build support files with CFLAGS embedded.  We plan to pass in CFLAGS from
> Arago into our SDK environment setting.  But it was decided not to resolve
> that issue until the next release. This patch fixes an issue where the
> Makefile was not at the top level.

Yes, and it can go in when the INSANE_SKIP is gone. I'm not asking you
to fix CCSv5, I'm asking you to add a patch to this recipe to fix it. I
suspect it's a one-liner, so no reason to keep hacks liek INSANE_SKIP
when it can be easily solved in OE.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFOCeFFMkyGM64RGpERAlVzAKCB66aIKG0Gifb34swUQ6xsBhd+4wCgt8J4
xDfilGFIvPiu0uweaEtDCKQ=
=b/t6
-----END PGP SIGNATURE-----
Denys Dmytriyenko - June 28, 2011, 6:10 p.m.
On Tue, Jun 28, 2011 at 04:12:21PM +0200, Koen Kooi wrote:
> On 28-06-11 16:00, Jeff Lance wrote:
> > Koen,
> > 
> > We are using makefiles generated by CCSv5.  CCSv5 auto generates its own
> > build support files with CFLAGS embedded.  We plan to pass in CFLAGS from
> > Arago into our SDK environment setting.  But it was decided not to resolve
> > that issue until the next release. This patch fixes an issue where the
> > Makefile was not at the top level.
> 
> Yes, and it can go in when the INSANE_SKIP is gone. I'm not asking you
> to fix CCSv5, I'm asking you to add a patch to this recipe to fix it. I
> suspect it's a one-liner, so no reason to keep hacks liek INSANE_SKIP
> when it can be easily solved in OE.

In other words - add a sed magic to do_configure, like I did for matrix-tui 
long time ago...
Jeff Lance - June 29, 2011, 4:10 p.m.
Thanks, I've submitted version 2 of this patch with the necessary updates

On Tue, Jun 28, 2011 at 1:10 PM, Denys Dmytriyenko <denis@denix.org> wrote:

> On Tue, Jun 28, 2011 at 04:12:21PM +0200, Koen Kooi wrote:
> > On 28-06-11 16:00, Jeff Lance wrote:
> > > Koen,
> > >
> > > We are using makefiles generated by CCSv5.  CCSv5 auto generates its
> own
> > > build support files with CFLAGS embedded.  We plan to pass in CFLAGS
> from
> > > Arago into our SDK environment setting.  But it was decided not to
> resolve
> > > that issue until the next release. This patch fixes an issue where the
> > > Makefile was not at the top level.
> >
> > Yes, and it can go in when the INSANE_SKIP is gone. I'm not asking you
> > to fix CCSv5, I'm asking you to add a patch to this recipe to fix it. I
> > suspect it's a one-liner, so no reason to keep hacks liek INSANE_SKIP
> > when it can be easily solved in OE.
>
> In other words - add a sed magic to do_configure, like I did for matrix-tui
> long time ago...
>
> --
> Denys
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>

Patch

diff --git a/recipes/ti/am-benchmarks_1.3.bb b/recipes/ti/am-benchmarks_1.3.bb
new file mode 100644
index 0000000..f4182b3
--- /dev/null
+++ b/recipes/ti/am-benchmarks_1.3.bb
@@ -0,0 +1,31 @@ 
+#NOTE: This package is currently only supported for the Angstrom
+#      distribution.  Other distributions and toolchains may or
+#      may not work.
+
+DESCRIPTION = "AM Benchmarks"
+HOMEPAGE = "https://gforge.ti.com/gf/project/am_benchmarks/"
+LICENSE = "BSD"
+SECTION = "system"
+PRIORITY = "optional"
+
+SRCREV = "65"
+PR = "r2+svnr${SRCPV}"
+
+INSANE_SKIP_${PN} = "True"
+
+SRC_URI = "svn://gforge.ti.com/svn/am_benchmarks/;module=trunk;proto=https;user=anonymous;pswd=''"
+
+S = "${WORKDIR}/trunk"
+
+do_compile() {
+	# don't build debug version
+	touch debug
+	export CROSS_COMPILE=${TARGET_PREFIX}
+	export ARCH=${BASE_PACKAGE_ARCH}
+	make release 
+}
+
+do_install() {
+	export ARCH=${BASE_PACKAGE_ARCH}
+	make DESTDIR=${D} install
+}