Patchwork [meta-fsl-arm,v3,08/11] libfslcodec: Enable/disable the VPU support based on SoC

login
register
mail settings
Submitter Otavio Salvador
Date Jan. 24, 2014, 1:47 a.m.
Message ID <1390528076-31527-9-git-send-email-otavio@ossystems.com.br>
Download mbox | patch
Permalink /patch/65687/
State Changes Requested
Delegated to: Otavio Salvador
Headers show

Comments

Otavio Salvador - Jan. 24, 2014, 1:47 a.m.
This enables the VPU support for all SoCs but MX23, MX28 and MX6SL.

Change-Id: I82bc80b4540ed2a83aeb2ac4545b47f3e7e37d9b
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
 recipes-multimedia/libfslcodec/libfslcodec.inc | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
Fabio Estevam - Jan. 24, 2014, 11:07 a.m.
On Thu, Jan 23, 2014 at 11:47 PM, Otavio Salvador
<otavio@ossystems.com.br> wrote:

> +# VPU Hardware acceleration
> +VPU_SUPPORT = "--enable-vpu"
> +VPU_SUPPORT_mx6sl = "--disable-vpu"
> +VPU_SUPPORT_mxs = "--disable-vpu"
> +EXTRA_OECONF += "${VPU_SUPPORT}"

Don't we also need a:

VPU_SUPPORT_mx3 = "--disable-vpu"

,in order to disable VPU support for mx31 and mx35?

Regards,

Fabio Estevam
Otavio Salvador - Jan. 24, 2014, 11:22 a.m.
On Fri, Jan 24, 2014 at 9:07 AM, Fabio Estevam <festevam@gmail.com> wrote:
> On Thu, Jan 23, 2014 at 11:47 PM, Otavio Salvador
> <otavio@ossystems.com.br> wrote:
>
>> +# VPU Hardware acceleration
>> +VPU_SUPPORT = "--enable-vpu"
>> +VPU_SUPPORT_mx6sl = "--disable-vpu"
>> +VPU_SUPPORT_mxs = "--disable-vpu"
>> +EXTRA_OECONF += "${VPU_SUPPORT}"
>
> Don't we also need a:
>
> VPU_SUPPORT_mx3 = "--disable-vpu"
>
> ,in order to disable VPU support for mx31 and mx35?

Good catch, it is not being used at this moment as those use mainline
kernel but it does not hurt and makes it more complete.

I will rework it and invert the logic:

>> +# VPU Hardware acceleration
VPU_SUPPORT = "--disable-vpu"
VPU_SUPPORT_mx6 = "--enable-vpu"
VPU_SUPPORT_mx6sl = "--disable-vpu"
VPU_SUPPORT_mx5 = "--enable-vpu"
EXTRA_OECONF += "${VPU_SUPPORT}"

So we enable it for the ones having it. What do you think?
Fabio Estevam - Jan. 24, 2014, 11:28 a.m.
On Fri, Jan 24, 2014 at 9:22 AM, Otavio Salvador
<otavio@ossystems.com.br> wrote:

> Good catch, it is not being used at this moment as those use mainline
> kernel but it does not hurt and makes it more complete.
>
> I will rework it and invert the logic:
>
>>> +# VPU Hardware acceleration
> VPU_SUPPORT = "--disable-vpu"
> VPU_SUPPORT_mx6 = "--enable-vpu"
> VPU_SUPPORT_mx6sl = "--disable-vpu"
> VPU_SUPPORT_mx5 = "--enable-vpu"
> EXTRA_OECONF += "${VPU_SUPPORT}"
>
> So we enable it for the ones having it. What do you think?

Looks better.

Regards,

Fabio Estevam

Patch

diff --git a/recipes-multimedia/libfslcodec/libfslcodec.inc b/recipes-multimedia/libfslcodec/libfslcodec.inc
index aa5282c..35fc713 100644
--- a/recipes-multimedia/libfslcodec/libfslcodec.inc
+++ b/recipes-multimedia/libfslcodec/libfslcodec.inc
@@ -1,4 +1,4 @@ 
-# Copyright (C) 2012-2013 Freescale Semiconductor
+# Copyright (C) 2012-2014 Freescale Semiconductor
 # Released under the MIT license (see COPYING.MIT for the terms)
 DESCRIPTION = "Freescale Multimedia codec libs"
 LICENSE = "Proprietary"
@@ -20,6 +20,12 @@  ALLOW_EMPTY_${PN}-meta = "1"
 # Choose between Soft Float-Point and Hard Float-Point
 EXTRA_OECONF = "${@bb.utils.contains('TUNE_FEATURES', 'callconvention-hard', '--enable-fhw', '', d)}"
 
+# VPU Hardware acceleration
+VPU_SUPPORT = "--enable-vpu"
+VPU_SUPPORT_mx6sl = "--disable-vpu"
+VPU_SUPPORT_mxs = "--disable-vpu"
+EXTRA_OECONF += "${VPU_SUPPORT}"
+
 do_install_append() {
 	# FIXME: This link points to nowhere
 	rm ${D}${libdir}/imx-mm/audio-codec/lib_src_ppp_arm11_elinux.so