Patchwork uclibc: Set ARCH_USE_MMU for armeb configs

login
register
mail settings
Submitter Khem Raj
Date June 27, 2011, 7:41 p.m.
Message ID <1309203709-25406-1-git-send-email-raj.khem@gmail.com>
Download mbox | patch
Permalink /patch/6565/
State New, archived
Headers show

Comments

Khem Raj - June 27, 2011, 7:41 p.m.
After the last cleanup. armeb/uClibc.machine
gets picked up by default for ARM Big endian
so bring it uptodate.

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 .../uclibc/uclibc-git/armeb/uClibc.machine         |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
Phil Blundell - June 27, 2011, 7:47 p.m.
On Mon, 2011-06-27 at 12:41 -0700, Khem Raj wrote:
> After the last cleanup. armeb/uClibc.machine
> gets picked up by default for ARM Big endian
> so bring it uptodate.

> -UCLIBC_HAS_FPU=y
> +# UCLIBC_HAS_FPU is not set
> +UCLIBC_HAS_SOFT_FLOAT=y

Is this deliberate?  That seems to be a change in behaviour but it isn't
mentioned in the commit message.

More generally, does armeb really need its own config file?  It seems as
though there shouldn't be any difference between arm and armeb except
endianness, and it should be fairly trivial to select that automatically
in the same way as we do the other uClibc config customisations.

p.
Khem Raj - June 27, 2011, 7:57 p.m.
On Mon, Jun 27, 2011 at 12:47 PM, Phil Blundell <pb@pbcl.net> wrote:
> On Mon, 2011-06-27 at 12:41 -0700, Khem Raj wrote:
>> After the last cleanup. armeb/uClibc.machine
>> gets picked up by default for ARM Big endian
>> so bring it uptodate.
>
>> -UCLIBC_HAS_FPU=y
>> +# UCLIBC_HAS_FPU is not set
>> +UCLIBC_HAS_SOFT_FLOAT=y
>
> Is this deliberate?  That seems to be a change in behaviour but it isn't
> mentioned in the commit message.

yes forgot that though.
>
> More generally, does armeb really need its own config file?

thanks for pointing it out. Indeed it does not need its own config
file since we already munge the endianness based on TARGET_ARCH in
uclibc-config.inc

I think thats a better approach to delete it. Let me see how that pans out

 It seems as
> though there shouldn't be any difference between arm and armeb except
> endianness, and it should be fairly trivial to select that automatically
> in the same way as we do the other uClibc config customisations.
>
> p.
>
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>

Patch

diff --git a/meta/recipes-core/uclibc/uclibc-git/armeb/uClibc.machine b/meta/recipes-core/uclibc/uclibc-git/armeb/uClibc.machine
index 7a6ad8b..b6932c6 100644
--- a/meta/recipes-core/uclibc/uclibc-git/armeb/uClibc.machine
+++ b/meta/recipes-core/uclibc/uclibc-git/armeb/uClibc.machine
@@ -45,8 +45,10 @@  CONFIG_GENERIC_ARM=y
 ARCH_BIG_ENDIAN=y
 # ARCH_HAS_NO_MMU is not set
 ARCH_HAS_MMU=y
+ARCH_USE_MMU=y
 UCLIBC_HAS_FLOATS=y
-UCLIBC_HAS_FPU=y
+# UCLIBC_HAS_FPU is not set
+UCLIBC_HAS_SOFT_FLOAT=y
 DO_C99_MATH=y
 # UCLIBC_HAS_FENV is not set
 KERNEL_HEADERS="<path/to/kernel/headers>"