Patchwork [12/15] genericx86: Use the core2 tune file

login
register
mail settings
Submitter Darren Hart
Date Jan. 21, 2014, 10:39 p.m.
Message ID <c65b846c5d5882f4adcb504ca01291173bd4bcf8.1390342768.git.dvhart@linux.intel.com>
Download mbox | patch
Permalink /patch/65421/
State Accepted
Commit a5b13d4e5504e40f26c4fca736639c80b6b79235
Headers show

Comments

Darren Hart - Jan. 21, 2014, 10:39 p.m.
Aside from the movbe and specialized instruction scheduling for the lack
of out-of-order scheduling in the older Atom CPUs, the core2 tune covers
these CPUs adequately. Since the current atom tune just uses core2
anyway, go ahead and make this explicit here.

Signed-off-by: Darren Hart <dvhart@linux.intel.com>
---
 meta-yocto-bsp/conf/machine/genericx86.conf |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Martin Jansa - Jan. 21, 2014, 10:58 p.m.
On Tue, Jan 21, 2014 at 02:39:58PM -0800, Darren Hart wrote:
> Aside from the movbe and specialized instruction scheduling for the lack
> of out-of-order scheduling in the older Atom CPUs, the core2 tune covers
> these CPUs adequately. Since the current atom tune just uses core2
> anyway, go ahead and make this explicit here.
> 
> Signed-off-by: Darren Hart <dvhart@linux.intel.com>
> ---
>  meta-yocto-bsp/conf/machine/genericx86.conf |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/meta-yocto-bsp/conf/machine/genericx86.conf b/meta-yocto-bsp/conf/machine/genericx86.conf
> index 9d29f62..549fc8e 100644
> --- a/meta-yocto-bsp/conf/machine/genericx86.conf
> +++ b/meta-yocto-bsp/conf/machine/genericx86.conf

This isn't for oe-core, is it?

> @@ -3,5 +3,6 @@
>  
>  #@DESCRIPTION: Machine configuration for generic X86 (32-bit) PCs. Supports a moderately wide range of drivers that should boot and be usable on "typical" hardware.
>  
> -include conf/machine/include/tune-atom.inc
> +DEFAULTTUNE ?= "core2-32"
> +include conf/machine/include/tune-core2.inc
>  include conf/machine/include/genericx86-common.inc
> -- 
> 1.7.9.5
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
Darren Hart - Jan. 21, 2014, 11:12 p.m.
On Tue, 2014-01-21 at 23:58 +0100, Martin Jansa wrote:
> On Tue, Jan 21, 2014 at 02:39:58PM -0800, Darren Hart wrote:
> > Aside from the movbe and specialized instruction scheduling for the lack
> > of out-of-order scheduling in the older Atom CPUs, the core2 tune covers
> > these CPUs adequately. Since the current atom tune just uses core2
> > anyway, go ahead and make this explicit here.
> > 
> > Signed-off-by: Darren Hart <dvhart@linux.intel.com>
> > ---
> >  meta-yocto-bsp/conf/machine/genericx86.conf |    3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/meta-yocto-bsp/conf/machine/genericx86.conf b/meta-yocto-bsp/conf/machine/genericx86.conf
> > index 9d29f62..549fc8e 100644
> > --- a/meta-yocto-bsp/conf/machine/genericx86.conf
> > +++ b/meta-yocto-bsp/conf/machine/genericx86.conf
> 
> This isn't for oe-core, is it?
> 

Nope. I called this out in the cover letter. It spans oe-core and poky,
but I felt they were best viewed as a whole, rather than splitting them
apart and worrying about the order in which they were applied. I
understand the desire to not cross post and generally agree and avoid it
- on rare occasions such as this, it seems the least awful way to go
about it...

> > @@ -3,5 +3,6 @@
> >  
> >  #@DESCRIPTION: Machine configuration for generic X86 (32-bit) PCs. Supports a moderately wide range of drivers that should boot and be usable on "typical" hardware.
> >  
> > -include conf/machine/include/tune-atom.inc
> > +DEFAULTTUNE ?= "core2-32"
> > +include conf/machine/include/tune-core2.inc
> >  include conf/machine/include/genericx86-common.inc
> > -- 
> > 1.7.9.5
> > 
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
Martin Jansa - Jan. 21, 2014, 11:18 p.m.
On Tue, Jan 21, 2014 at 03:12:15PM -0800, Darren Hart wrote:
> On Tue, 2014-01-21 at 23:58 +0100, Martin Jansa wrote:
> > On Tue, Jan 21, 2014 at 02:39:58PM -0800, Darren Hart wrote:
> > > Aside from the movbe and specialized instruction scheduling for the lack
> > > of out-of-order scheduling in the older Atom CPUs, the core2 tune covers
> > > these CPUs adequately. Since the current atom tune just uses core2
> > > anyway, go ahead and make this explicit here.
> > > 
> > > Signed-off-by: Darren Hart <dvhart@linux.intel.com>
> > > ---
> > >  meta-yocto-bsp/conf/machine/genericx86.conf |    3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/meta-yocto-bsp/conf/machine/genericx86.conf b/meta-yocto-bsp/conf/machine/genericx86.conf
> > > index 9d29f62..549fc8e 100644
> > > --- a/meta-yocto-bsp/conf/machine/genericx86.conf
> > > +++ b/meta-yocto-bsp/conf/machine/genericx86.conf
> > 
> > This isn't for oe-core, is it?
> > 
> 
> Nope. I called this out in the cover letter. It spans oe-core and poky,
> but I felt they were best viewed as a whole, rather than splitting them
> apart and worrying about the order in which they were applied. I
> understand the desire to not cross post and generally agree and avoid it
> - on rare occasions such as this, it seems the least awful way to go
> about it...

OK, sorry I see it now, for some reason cover letter arrived to my
maildir last.

Patch

diff --git a/meta-yocto-bsp/conf/machine/genericx86.conf b/meta-yocto-bsp/conf/machine/genericx86.conf
index 9d29f62..549fc8e 100644
--- a/meta-yocto-bsp/conf/machine/genericx86.conf
+++ b/meta-yocto-bsp/conf/machine/genericx86.conf
@@ -3,5 +3,6 @@ 
 
 #@DESCRIPTION: Machine configuration for generic X86 (32-bit) PCs. Supports a moderately wide range of drivers that should boot and be usable on "typical" hardware.
 
-include conf/machine/include/tune-atom.inc
+DEFAULTTUNE ?= "core2-32"
+include conf/machine/include/tune-core2.inc
 include conf/machine/include/genericx86-common.inc