Patchwork [meta-oe] xf86-video-ati: recommend linux-firmware

login
register
mail settings
Submitter Koen Kooi
Date Jan. 21, 2014, 7:32 p.m.
Message ID <1390332748-31444-1-git-send-email-koen@dominion.thruhere.net>
Download mbox | patch
Permalink /patch/65385/
State Accepted, archived
Headers show

Comments

Koen Kooi - Jan. 21, 2014, 7:32 p.m.
Technically it won't work without, but it's possible to build the firmware into the kernel, so use RRECOMMENDS.

Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
---
 meta-oe/recipes-graphics/xorg-driver/xf86-video-ati_7.2.0.bb |    1 +
 1 file changed, 1 insertion(+)
Ross Burton - Jan. 21, 2014, 8:21 p.m.
On 21 January 2014 19:32, Koen Kooi <koen@dominion.thruhere.net> wrote:
> Technically it won't work without, but it's possible to build the firmware into the kernel, so use RRECOMMENDS.

A blanket recommendation like that seems like you should be splitting
the relevant firmware into a separate package first.

Ross
Otavio Salvador - Jan. 22, 2014, 2:36 p.m.
On Tue, Jan 21, 2014 at 6:21 PM, Burton, Ross <ross.burton@intel.com> wrote:
> On 21 January 2014 19:32, Koen Kooi <koen@dominion.thruhere.net> wrote:
>> Technically it won't work without, but it's possible to build the firmware into the kernel, so use RRECOMMENDS.
>
> A blanket recommendation like that seems like you should be splitting
> the relevant firmware into a separate package first.

Agreed; this helps to reduce the footprint increase from this change.
Koen Kooi - Jan. 23, 2014, 9:57 a.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Otavio Salvador schreef op 22-01-14 15:36:
> On Tue, Jan 21, 2014 at 6:21 PM, Burton, Ross <ross.burton@intel.com>
> wrote:
>> On 21 January 2014 19:32, Koen Kooi <koen@dominion.thruhere.net>
>> wrote:
>>> Technically it won't work without, but it's possible to build the
>>> firmware into the kernel, so use RRECOMMENDS.
>> 
>> A blanket recommendation like that seems like you should be splitting 
>> the relevant firmware into a separate package first.
> 
> Agreed; this helps to reduce the footprint increase from this change.

http://patches.openembedded.org/patch/65573/

I'll send an updated patch for xf86-video-ati after the above lands in oe-core.

regards,

Koen

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
Comment: GPGTools - http://gpgtools.org

iD8DBQFS4OeIMkyGM64RGpERApRhAJ4lMjwhZUchxfoBVAZEho0g9H0oTgCfRude
EGTQJzxZft0XY4k+6tnadew=
=mbHG
-----END PGP SIGNATURE-----
Otavio Salvador - Jan. 23, 2014, 10:42 a.m.
On Thu, Jan 23, 2014 at 7:57 AM, Koen Kooi <koen@dominion.thruhere.net> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Otavio Salvador schreef op 22-01-14 15:36:
>> On Tue, Jan 21, 2014 at 6:21 PM, Burton, Ross <ross.burton@intel.com>
>> wrote:
>>> On 21 January 2014 19:32, Koen Kooi <koen@dominion.thruhere.net>
>>> wrote:
>>>> Technically it won't work without, but it's possible to build the
>>>> firmware into the kernel, so use RRECOMMENDS.
>>>
>>> A blanket recommendation like that seems like you should be splitting
>>> the relevant firmware into a separate package first.
>>
>> Agreed; this helps to reduce the footprint increase from this change.
>
> http://patches.openembedded.org/patch/65573/
>
> I'll send an updated patch for xf86-video-ati after the above lands in oe-core.

Thanks a lot

Patch

diff --git a/meta-oe/recipes-graphics/xorg-driver/xf86-video-ati_7.2.0.bb b/meta-oe/recipes-graphics/xorg-driver/xf86-video-ati_7.2.0.bb
index a453f90..d4d9591 100644
--- a/meta-oe/recipes-graphics/xorg-driver/xf86-video-ati_7.2.0.bb
+++ b/meta-oe/recipes-graphics/xorg-driver/xf86-video-ati_7.2.0.bb
@@ -9,6 +9,7 @@  DESCRIPTION = "Open-source X.org graphics driver for ATI Radeon graphics"
 DEPENDS += "virtual/libx11 libxvmc drm xf86driproto glproto \
             virtual/libgl xineramaproto libpciaccess"
 RDEPENDS_${PN} += "xserver-xorg-module-exa"
+RRECOMMENDS_${PN} += "linux-firmware"
 
 COMPATIBLE_HOST = '(i.86|x86_64).*-linux'