Patchwork [meta-fsl-arm,05/15] libfslcodec: Drop sanity check override for .so files

login
register
mail settings
Submitter Otavio Salvador
Date Jan. 21, 2014, 2:28 p.m.
Message ID <1390314546-9473-6-git-send-email-otavio@ossystems.com.br>
Download mbox | patch
Permalink /patch/65333/
State Superseded
Delegated to: Otavio Salvador
Headers show

Comments

Otavio Salvador - Jan. 21, 2014, 2:28 p.m.
Change-Id: I9ad5c8db3b156398884ba9b63943eb56394c868f
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
 recipes-multimedia/libfslcodec/libfslcodec.inc | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
Fabio Estevam - Jan. 21, 2014, 2:41 p.m.
On Tue, Jan 21, 2014 at 12:28 PM, Otavio Salvador
<otavio@ossystems.com.br> wrote:
> Change-Id: I9ad5c8db3b156398884ba9b63943eb56394c868f
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>

I am sure you have a reason to do this change, but I have no idea as
to why this is needed :-)

Please explain it in the commit log.

Regards,

Fabio Estevam
Otavio Salvador - Jan. 21, 2014, 3:45 p.m.
On Tue, Jan 21, 2014 at 12:41 PM, Fabio Estevam <festevam@gmail.com> wrote:
> On Tue, Jan 21, 2014 at 12:28 PM, Otavio Salvador
> <otavio@ossystems.com.br> wrote:
>> Change-Id: I9ad5c8db3b156398884ba9b63943eb56394c868f
>> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
>
> I am sure you have a reason to do this change, but I have no idea as
> to why this is needed :-)
>
> Please explain it in the commit log.
>
> Regards,
>
> Fabio Estevam

Better?

libfslcodec: Drop sanity check override for .so files

The .so files are not being deployed in the regular packages, just the
-dev ones, so we can drop this sanity check workaround and the
respective FIXME entry.

Change-Id: I9ad5c8db3b156398884ba9b63943eb56394c868f
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
I won't reupload the patches due this change, but I did it in my tree
and in master-next.

Patch

diff --git a/recipes-multimedia/libfslcodec/libfslcodec.inc b/recipes-multimedia/libfslcodec/libfslcodec.inc
index e787d3a..597654b 100644
--- a/recipes-multimedia/libfslcodec/libfslcodec.inc
+++ b/recipes-multimedia/libfslcodec/libfslcodec.inc
@@ -44,9 +44,8 @@  python populate_packages_prepend() {
 
     # FIXME: All binaries lack GNU_HASH in elf binary but as we don't have
     # the source we cannot fix it. Disable the insane check for now.
-    # FIXME: gst-fsl-plugin looks for the .so files so we need to deploy those
     for p in d.getVar('PACKAGES', True).split():
-        d.setVar("INSANE_SKIP_%s" % p, "ldflags textrel dev-so")
+        d.setVar("INSANE_SKIP_%s" % p, "ldflags textrel")
         d.setVar("DEBIAN_NOAUTONAME_%s" % p, "1")
 
     # Allow addition of all codecs in a image; useful specially for