Patchwork conf/bitbake.conf: default HOMEPAGE to blank instead of unknown

login
register
mail settings
Submitter Paul Eggleton
Date Jan. 21, 2014, 12:17 p.m.
Message ID <1390306673-9822-1-git-send-email-paul.eggleton@linux.intel.com>
Download mbox | patch
Permalink /patch/65323/
State New
Headers show

Comments

Paul Eggleton - Jan. 21, 2014, 12:17 p.m.
The default value for HOMEPAGE of "unknown" has been in place since the
early OE-Classic days, but it doesn't really make sense - "unknown" is
not a valid URL and it just means we have to explicitly check for this
hardcoded string if we're displaying the value in some form of UI, such
as Toaster. There is some code in the unmaintained oelint.bbclass to
check for this value, presumably on the assumption that the recipe will
explicitly set it to "" if there really isn't a homepage, but looking at
recipes in OE-Core and meta-oe suggests that we haven't been using this
convention for some time (with one exception in the latter) and it's
rather uncommon these days to have no URL to associate with a recipe.

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
---
 meta/conf/bitbake.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Saul Wold - Jan. 21, 2014, 10:09 p.m.
On 01/21/2014 04:17 AM, Paul Eggleton wrote:
> The default value for HOMEPAGE of "unknown" has been in place since the
> early OE-Classic days, but it doesn't really make sense - "unknown" is
> not a valid URL and it just means we have to explicitly check for this
> hardcoded string if we're displaying the value in some form of UI, such
> as Toaster. There is some code in the unmaintained oelint.bbclass to
> check for this value, presumably on the assumption that the recipe will
> explicitly set it to "" if there really isn't a homepage, but looking at
> recipes in OE-Core and meta-oe suggests that we haven't been using this
> convention for some time (with one exception in the latter) and it's
> rather uncommon these days to have no URL to associate with a recipe.
>
> Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
> ---
>   meta/conf/bitbake.conf | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> index 57668e1..4fb6a1c 100644
> --- a/meta/conf/bitbake.conf
> +++ b/meta/conf/bitbake.conf
> @@ -241,7 +241,7 @@ This package contains documentation."
>
>   LICENSE = "INVALID"
>   MAINTAINER = "OE-Core Developers <openembedded-core@lists.openembedded.org>"
> -HOMEPAGE = "unknown"
> +HOMEPAGE = ""
>

This seems to have caused a couple of problems with shadow-securetty, 
updaterc and depmodwrapper.

There may be more.

I will look to see what I can do to fix those recipes.

Sau!

>   # Package dependencies and provides.
>
>
Paul Eggleton - Jan. 21, 2014, 10:12 p.m.
Hi Saul,

On Tuesday 21 January 2014 14:09:16 Saul Wold wrote:
> On 01/21/2014 04:17 AM, Paul Eggleton wrote:
> > The default value for HOMEPAGE of "unknown" has been in place since the
> > early OE-Classic days, but it doesn't really make sense - "unknown" is
> > not a valid URL and it just means we have to explicitly check for this
> > hardcoded string if we're displaying the value in some form of UI, such
> > as Toaster. There is some code in the unmaintained oelint.bbclass to
> > check for this value, presumably on the assumption that the recipe will
> > explicitly set it to "" if there really isn't a homepage, but looking at
> > recipes in OE-Core and meta-oe suggests that we haven't been using this
> > convention for some time (with one exception in the latter) and it's
> > rather uncommon these days to have no URL to associate with a recipe.
> > 
> > Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
> > ---
> > 
> >   meta/conf/bitbake.conf | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> > index 57668e1..4fb6a1c 100644
> > --- a/meta/conf/bitbake.conf
> > +++ b/meta/conf/bitbake.conf
> > @@ -241,7 +241,7 @@ This package contains documentation."
> > 
> >   LICENSE = "INVALID"
> >   MAINTAINER = "OE-Core Developers
> >   <openembedded-core@lists.openembedded.org>"> 
> > -HOMEPAGE = "unknown"
> > +HOMEPAGE = ""
> 
> This seems to have caused a couple of problems with shadow-securetty,
> updaterc and depmodwrapper.
> 
> There may be more.

Can you perhaps be more specific as to what the problem is?

Thanks,
Paul
Paul Eggleton - Jan. 21, 2014, 10:22 p.m.
On Tuesday 21 January 2014 22:12:13 Paul Eggleton wrote:
> Hi Saul,
> 
> On Tuesday 21 January 2014 14:09:16 Saul Wold wrote:
> > On 01/21/2014 04:17 AM, Paul Eggleton wrote:
> > > The default value for HOMEPAGE of "unknown" has been in place since the
> > > early OE-Classic days, but it doesn't really make sense - "unknown" is
> > > not a valid URL and it just means we have to explicitly check for this
> > > hardcoded string if we're displaying the value in some form of UI, such
> > > as Toaster. There is some code in the unmaintained oelint.bbclass to
> > > check for this value, presumably on the assumption that the recipe will
> > > explicitly set it to "" if there really isn't a homepage, but looking at
> > > recipes in OE-Core and meta-oe suggests that we haven't been using this
> > > convention for some time (with one exception in the latter) and it's
> > > rather uncommon these days to have no URL to associate with a recipe.
> > > 
> > > Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
> > > ---
> > > 
> > >   meta/conf/bitbake.conf | 2 +-
> > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> > > index 57668e1..4fb6a1c 100644
> > > --- a/meta/conf/bitbake.conf
> > > +++ b/meta/conf/bitbake.conf
> > > @@ -241,7 +241,7 @@ This package contains documentation."
> > > 
> > >   LICENSE = "INVALID"
> > >   MAINTAINER = "OE-Core Developers
> > >   <openembedded-core@lists.openembedded.org>">
> > > 
> > > -HOMEPAGE = "unknown"
> > > +HOMEPAGE = ""
> > 
> > This seems to have caused a couple of problems with shadow-securetty,
> > updaterc and depmodwrapper.
> > 
> > There may be more.
> 
> Can you perhaps be more specific as to what the problem is?

Oh, I see, rpmbuild blows up with URL blank. Great :/

Let's hold off on this one for now because fixing one or two recipes isn't going 
to cover it.

Cheers,
Paul
Richard Purdie - Jan. 21, 2014, 10:23 p.m.
On Tue, 2014-01-21 at 12:17 +0000, Paul Eggleton wrote:
> The default value for HOMEPAGE of "unknown" has been in place since the
> early OE-Classic days, but it doesn't really make sense - "unknown" is
> not a valid URL and it just means we have to explicitly check for this
> hardcoded string if we're displaying the value in some form of UI, such
> as Toaster. There is some code in the unmaintained oelint.bbclass to
> check for this value, presumably on the assumption that the recipe will
> explicitly set it to "" if there really isn't a homepage, but looking at
> recipes in OE-Core and meta-oe suggests that we haven't been using this
> convention for some time (with one exception in the latter) and it's
> rather uncommon these days to have no URL to associate with a recipe.
> 
> Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
> ---
>  meta/conf/bitbake.conf | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> index 57668e1..4fb6a1c 100644
> --- a/meta/conf/bitbake.conf
> +++ b/meta/conf/bitbake.conf
> @@ -241,7 +241,7 @@ This package contains documentation."
>  
>  LICENSE = "INVALID"
>  MAINTAINER = "OE-Core Developers <openembedded-core@lists.openembedded.org>"
> -HOMEPAGE = "unknown"
> +HOMEPAGE = ""
>  

Perhaps we just shouldn't set it at all in bitbake.conf and let recipes
elect to set it?

Cheers,

Richard
Saul Wold - Jan. 21, 2014, 10:24 p.m.
On 01/21/2014 02:12 PM, Paul Eggleton wrote:
> Hi Saul,
>
> On Tuesday 21 January 2014 14:09:16 Saul Wold wrote:
>> On 01/21/2014 04:17 AM, Paul Eggleton wrote:
>>> The default value for HOMEPAGE of "unknown" has been in place since the
>>> early OE-Classic days, but it doesn't really make sense - "unknown" is
>>> not a valid URL and it just means we have to explicitly check for this
>>> hardcoded string if we're displaying the value in some form of UI, such
>>> as Toaster. There is some code in the unmaintained oelint.bbclass to
>>> check for this value, presumably on the assumption that the recipe will
>>> explicitly set it to "" if there really isn't a homepage, but looking at
>>> recipes in OE-Core and meta-oe suggests that we haven't been using this
>>> convention for some time (with one exception in the latter) and it's
>>> rather uncommon these days to have no URL to associate with a recipe.
>>>
>>> Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
>>> ---
>>>
>>>    meta/conf/bitbake.conf | 2 +-
>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
>>> index 57668e1..4fb6a1c 100644
>>> --- a/meta/conf/bitbake.conf
>>> +++ b/meta/conf/bitbake.conf
>>> @@ -241,7 +241,7 @@ This package contains documentation."
>>>
>>>    LICENSE = "INVALID"
>>>    MAINTAINER = "OE-Core Developers
>>>    <openembedded-core@lists.openembedded.org>">
>>> -HOMEPAGE = "unknown"
>>> +HOMEPAGE = ""
>>
>> This seems to have caused a couple of problems with shadow-securetty,
>> updaterc and depmodwrapper.
>>
>> There may be more.
>
> Can you perhaps be more specific as to what the problem is?
>

Sorry, thought perhaps you would see the autobuilder failures.
> ERROR: Task 1962 (/home/pokybuild/yocto-autobuilder-dev/yocto-slave/nightly-arm/build/meta/recipes-core/update-rc.d/update-rc.d_0.7.bb, do_package_write_rpm) failed with exit code '1'
> NOTE: recipe shadow-securetty-4.1.4.3-r2: task do_package_write_deb: Started
> ERROR: Function failed: dpkg-deb execution failed
> ERROR: Logfile of failure stored in: /home/pokybuild/yocto-autobuilder-dev/yocto-slave/nightly-arm/build/build/tmp/work/qemuarm-poky-linux-gnueabi/shadow-securetty/4.1.4.3-r2/temp/log.do_package_write_deb.8751
> Log data follows:
> | DEBUG: Executing python function sstate_task_prefunc
> | DEBUG: Python function sstate_task_prefunc finished
> | DEBUG: Executing python function do_package_write_deb
> | DEBUG: Executing python function read_subpackage_metadata
> | DEBUG: Python function read_subpackage_metadata finished
> | DEBUG: Executing python function do_package_deb
> | dpkg-deb: error: parsing file '/home/pokybuild/yocto-autobuilder-dev/yocto-slave/nightly-arm/build/build/tmp/work/qemuarm-poky-linux-gnueabi/shadow-securetty/4.1.4.3-r2/packages-split/shadow-securetty-dbg/DEBIAN/control' near line 11 package 'shadow-securetty-dbg':
> |  EOF before value of field `Homepage' (missing final newline)
> | DEBUG: Python function do_package_deb finished
> | DEBUG: Python function do_package_write_deb finished
> | ERROR: Function failed: dpkg-deb execution failed
> NOTE: recipe shadow-securetty-4.1.4.3-r2: task do_package_write_deb: Failed
> ERROR: Task 4847 (/home/pokybuild/yocto-autobuilder-dev/yocto-slave/nightly-arm/build/meta/recipes-extended/shadow/shadow-securetty_4.1.4.3.bb, do_package_write_deb) failed with exit code '1'
> ERROR: Function failed: BUILDSPEC (log file is located at /home/pokybuild/yocto-autobuilder-dev/yocto-slave/nightly-arm/build/build/tmp/work/qemuarm-poky-linux-gnueabi/shadow-securetty/4.1.4.3-r2/temp/log.do_package_write_rpm.8020)
> ERROR: Logfile of failure stored in: /home/pokybuild/yocto-autobuilder-dev/yocto-slave/nightly-arm/build/build/tmp/work/qemuarm-poky-linux-gnueabi/shadow-securetty/4.1.4.3-r2/temp/log.do_package_write_rpm.8020
> Log data follows:
> | DEBUG: Executing python function sstate_task_prefunc
> | DEBUG: Python function sstate_task_prefunc finished
> | DEBUG: Executing python function do_package_write_rpm
> | DEBUG: Executing python function read_subpackage_metadata
> | DEBUG: Python function read_subpackage_metadata finished
> | DEBUG: Executing python function do_package_rpm
> | DEBUG: Executing python function write_specfile
> | NOTE: Creating EMPTY RPM Package for shadow-securetty-dbg
> | NOTE: Not creating empty RPM package for shadow-securetty-staticdev
> | NOTE: Creating EMPTY RPM Package for shadow-securetty-dev
> | NOTE: Not creating empty RPM package for shadow-securetty-doc
> | NOTE: Not creating empty RPM package for shadow-securetty-locale
> | NOTE: Creating RPM package for shadow-securetty
> | NOTE: Creating RPM package for shadow-securetty
> | DEBUG: Python function write_specfile finished
> | DEBUG: Executing shell function BUILDSPEC
> | error: line 8: Empty tag: URL:
> | error: Package has no %description: shadow-securetty-4.1.4.3-r2.qemuarm
> | Building target platforms: qemuarm-poky-linux-gnueabi
> | WARNING: /home/pokybuild/yocto-autobuilder-dev/yocto-slave/nightly-arm/build/build/tmp/work/qemuarm-poky-linux-gnueabi/shadow-securetty/4.1.4.3-r2/temp/run.BUILDSPEC.8020:1 exit 1 from
> |   rpmbuild --nodeps --short-circuit --target qemuarm-poky-linux-gnueabi --buildroot /home/pokybuild/yocto-autobuilder-dev/yocto-slave/nightly-arm/build/build/tmp/work/qemuarm-poky-linux-gnueabi/shadow-securetty/4.1.4.3-r2/package --define '_topdir /home/pokybuild/yocto-autobuilder-dev/yocto-slave/nightly-arm/build/build/tmp/work/qemuarm-poky-linux-gnueabi/shadow-securetty/4.1.4.3-r2' --define '_rpmdir /home/pokybuild/yocto-autobuilder-dev/yocto-slave/nightly-arm/build/build/tmp/work/qemuarm-poky-linux-gnueabi/shadow-securetty/4.1.4.3-r2/deploy-rpms/qemuarm' --define '_build_name_fmt %%{NAME}-%%{VERSION}-%%{RELEASE}.%%{ARCH}.rpm' --define '_use_internal_dependency_generator 0' --define '__find_requires %{nil}' --define '__find_provides %{nil}' --define '_unpackaged_files_terminate_build 0' --define 'debug_package %{nil}' --define '_rpmfc_magic_path /home/pokybuild/yocto-autobuilder-dev/yocto-slave/nightly-arm/build/build/tmp/sysroots/x86_64-linux/usr/share/misc/magic.mgc' 
 --define 
'_tmppath /home/pokybuild/yocto-autobuilder-dev/yocto-slave/nightly-arm/build/build/tmp/work/qemuarm-poky-linux-gnueabi/shadow-securetty/4.1.4.3-r2' -bb /home/pokybuild/yocto-autobuilder-dev/yocto-slave/nightly-arm/build/build/tmp/work/qemuarm-poky-linux-gnueabi/shadow-securetty/4.1.4.3-r2/shadow-securetty.spec
> | DEBUG: Python function do_package_rpm finished
> | DEBUG: Python function do_package_write_rpm finished
> | ERROR: Function failed: BUILDSPEC (log file is located at /home/pokybuild/yocto-autobuilder-dev/yocto-slave/nightly-arm/build/build/tmp/work/qemuarm-poky-linux-gnueabi/shadow-securetty/4.1.4.3-r2/temp/log.do_package_write_rpm.8020)
> NOTE: recipe shadow-securetty-4.1.4.3-r2: task do_package_write_rpm: Failed



> Thanks,
> Paul
>
Paul Eggleton - Jan. 21, 2014, 10:39 p.m.
On Tuesday 21 January 2014 22:23:18 Richard Purdie wrote:
> On Tue, 2014-01-21 at 12:17 +0000, Paul Eggleton wrote:
> > The default value for HOMEPAGE of "unknown" has been in place since the
> > early OE-Classic days, but it doesn't really make sense - "unknown" is
> > not a valid URL and it just means we have to explicitly check for this
> > hardcoded string if we're displaying the value in some form of UI, such
> > as Toaster. There is some code in the unmaintained oelint.bbclass to
> > check for this value, presumably on the assumption that the recipe will
> > explicitly set it to "" if there really isn't a homepage, but looking at
> > recipes in OE-Core and meta-oe suggests that we haven't been using this
> > convention for some time (with one exception in the latter) and it's
> > rather uncommon these days to have no URL to associate with a recipe.
> > 
> > Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
> > ---
> > 
> >  meta/conf/bitbake.conf | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> > index 57668e1..4fb6a1c 100644
> > --- a/meta/conf/bitbake.conf
> > +++ b/meta/conf/bitbake.conf
> > @@ -241,7 +241,7 @@ This package contains documentation."
> > 
> >  LICENSE = "INVALID"
> >  MAINTAINER = "OE-Core Developers
> >  <openembedded-core@lists.openembedded.org>"> 
> > -HOMEPAGE = "unknown"
> > +HOMEPAGE = ""
> 
> Perhaps we just shouldn't set it at all in bitbake.conf and let recipes
> elect to set it?

Maybe, but I think that alone isn't necessarily enough because then converting 
the value to a string gives you "None" (and this is what happens with the rpm 
backend).

Cheers,
Paul
Richard Purdie - Jan. 21, 2014, 10:41 p.m.
On Tue, 2014-01-21 at 22:22 +0000, Paul Eggleton wrote:
> On Tuesday 21 January 2014 22:12:13 Paul Eggleton wrote:
> > Hi Saul,
> > 
> > On Tuesday 21 January 2014 14:09:16 Saul Wold wrote:
> > > On 01/21/2014 04:17 AM, Paul Eggleton wrote:
> > > > The default value for HOMEPAGE of "unknown" has been in place since the
> > > > early OE-Classic days, but it doesn't really make sense - "unknown" is
> > > > not a valid URL and it just means we have to explicitly check for this
> > > > hardcoded string if we're displaying the value in some form of UI, such
> > > > as Toaster. There is some code in the unmaintained oelint.bbclass to
> > > > check for this value, presumably on the assumption that the recipe will
> > > > explicitly set it to "" if there really isn't a homepage, but looking at
> > > > recipes in OE-Core and meta-oe suggests that we haven't been using this
> > > > convention for some time (with one exception in the latter) and it's
> > > > rather uncommon these days to have no URL to associate with a recipe.
> > > > 
> > > > Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
> > > > ---
> > > > 
> > > >   meta/conf/bitbake.conf | 2 +-
> > > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > > > 
> > > > diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> > > > index 57668e1..4fb6a1c 100644
> > > > --- a/meta/conf/bitbake.conf
> > > > +++ b/meta/conf/bitbake.conf
> > > > @@ -241,7 +241,7 @@ This package contains documentation."
> > > > 
> > > >   LICENSE = "INVALID"
> > > >   MAINTAINER = "OE-Core Developers
> > > >   <openembedded-core@lists.openembedded.org>">
> > > > 
> > > > -HOMEPAGE = "unknown"
> > > > +HOMEPAGE = ""
> > > 
> > > This seems to have caused a couple of problems with shadow-securetty,
> > > updaterc and depmodwrapper.
> > > 
> > > There may be more.
> > 
> > Can you perhaps be more specific as to what the problem is?
> 
> Oh, I see, rpmbuild blows up with URL blank. Great :/
> 
> Let's hold off on this one for now because fixing one or two recipes isn't going 
> to cover it.

I'm perfectly fine with the rpm backend injecting something to deal with
this rather than cluttering bitbake.conf or the toaster code. I think
cleaning out bitbake.conf is something we need to do more of.

SRCREV ??= "INVALID" is on my hitlist (newer bitbake's shouldn't need
that).

Cheers,

Richard
Richard Purdie - Jan. 21, 2014, 10:42 p.m.
On Tue, 2014-01-21 at 22:39 +0000, Paul Eggleton wrote:
> On Tuesday 21 January 2014 22:23:18 Richard Purdie wrote:
> > On Tue, 2014-01-21 at 12:17 +0000, Paul Eggleton wrote:
> > > The default value for HOMEPAGE of "unknown" has been in place since the
> > > early OE-Classic days, but it doesn't really make sense - "unknown" is
> > > not a valid URL and it just means we have to explicitly check for this
> > > hardcoded string if we're displaying the value in some form of UI, such
> > > as Toaster. There is some code in the unmaintained oelint.bbclass to
> > > check for this value, presumably on the assumption that the recipe will
> > > explicitly set it to "" if there really isn't a homepage, but looking at
> > > recipes in OE-Core and meta-oe suggests that we haven't been using this
> > > convention for some time (with one exception in the latter) and it's
> > > rather uncommon these days to have no URL to associate with a recipe.
> > > 
> > > Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
> > > ---
> > > 
> > >  meta/conf/bitbake.conf | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> > > index 57668e1..4fb6a1c 100644
> > > --- a/meta/conf/bitbake.conf
> > > +++ b/meta/conf/bitbake.conf
> > > @@ -241,7 +241,7 @@ This package contains documentation."
> > > 
> > >  LICENSE = "INVALID"
> > >  MAINTAINER = "OE-Core Developers
> > >  <openembedded-core@lists.openembedded.org>"> 
> > > -HOMEPAGE = "unknown"
> > > +HOMEPAGE = ""
> > 
> > Perhaps we just shouldn't set it at all in bitbake.conf and let recipes
> > elect to set it?
> 
> Maybe, but I think that alone isn't necessarily enough because then converting 
> the value to a string gives you "None" (and this is what happens with the rpm 
> backend).

Lets fix the rpm backend then ;-)

Cheers,

Richard

Patch

diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
index 57668e1..4fb6a1c 100644
--- a/meta/conf/bitbake.conf
+++ b/meta/conf/bitbake.conf
@@ -241,7 +241,7 @@  This package contains documentation."
 
 LICENSE = "INVALID"
 MAINTAINER = "OE-Core Developers <openembedded-core@lists.openembedded.org>"
-HOMEPAGE = "unknown"
+HOMEPAGE = ""
 
 # Package dependencies and provides.