Patchwork [V2,1/5] systemd: add 'less' to its RDEPENDS

login
register
mail settings
Submitter Qi.Chen@windriver.com
Date Jan. 17, 2014, 10:39 a.m.
Message ID <db9b22bb0dfe7977362d7d546e752e8d0b9eb5c3.1389955027.git.Qi.Chen@windriver.com>
Download mbox | patch
Permalink /patch/65047/
State New
Headers show

Comments

Qi.Chen@windriver.com - Jan. 17, 2014, 10:39 a.m.
The less command provided by busybox cannot interpret the control
character, resulting in obscure output of the journalctl command
in a systemd based image.

Add the 'less' package to systemd's RDEPENDS so that the output
of 'journalctl' looks clear to users.

[YOCTO #5723]

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
---
 meta/recipes-core/systemd/systemd_208.bb |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Ross Burton - Jan. 17, 2014, 11:40 a.m.
On 17 January 2014 10:39, Chen Qi <Qi.Chen@windriver.com> wrote:
> The less command provided by busybox cannot interpret the control
> character, resulting in obscure output of the journalctl command
> in a systemd based image.
>
> Add the 'less' package to systemd's RDEPENDS so that the output
> of 'journalctl' looks clear to users.

Recommends, please.  From a glance at the source busybox less does
support some control characters, so maybe we should file a bug there
too.

Ross

Patch

diff --git a/meta/recipes-core/systemd/systemd_208.bb b/meta/recipes-core/systemd/systemd_208.bb
index 6590235..3659abd 100644
--- a/meta/recipes-core/systemd/systemd_208.bb
+++ b/meta/recipes-core/systemd/systemd_208.bb
@@ -217,7 +217,8 @@  FILES_${PN} = " ${base_bindir}/* \
 FILES_${PN}-dbg += "${rootlibdir}/.debug ${systemd_unitdir}/.debug ${systemd_unitdir}/*/.debug ${base_libdir}/security/.debug/"
 FILES_${PN}-dev += "${base_libdir}/security/*.la ${datadir}/dbus-1/interfaces/ ${sysconfdir}/rpm/macros.systemd"
 
-RDEPENDS_${PN} += "kmod dbus util-linux-mount"
+# less package is needed to correctly display the contents of 'journalctl'
+RDEPENDS_${PN} += "kmod dbus util-linux-mount less"
 
 RRECOMMENDS_${PN} += "systemd-serialgetty systemd-compat-units \
                       util-linux-agetty \