Patchwork [meta-fsl-arm] imx-kobs: Update license checksum

login
register
mail settings
Submitter Gary Thomas
Date Jan. 15, 2014, 3:58 p.m.
Message ID <1389801493-17578-1-git-send-email-gary@mlbassoc.com>
Download mbox | patch
Permalink /patch/64901/
State Superseded
Delegated to: Otavio Salvador
Headers show

Comments

Gary Thomas - Jan. 15, 2014, 3:58 p.m.
Update license checksum to follow changes in OE-core

Signed-off-by: Gary Thomas <gary@mlbassoc.com>
---
 recipes-bsp/imx-kobs/imx-kobs_3.5.7-1.0.0.bb |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Otavio Salvador - Jan. 15, 2014, 7:47 p.m.
Hello Gary,

On Wed, Jan 15, 2014 at 1:58 PM, Gary Thomas <gary@mlbassoc.com> wrote:

> Update license checksum to follow changes in OE-core
>
> Signed-off-by: Gary Thomas <gary@mlbassoc.com>
>

To avoid using it to happen in future, please rework this as I did in:

http://git.yoctoproject.org/cgit/cgit.cgi/meta-fsl-arm/commit/?id=a99e70cbb501f992abb8f80218fc5fb2a4fd6224
Gary Thomas - Jan. 15, 2014, 9:22 p.m.
On 2014-01-15 12:47, Otavio Salvador wrote:
> Hello Gary,
>
> On Wed, Jan 15, 2014 at 1:58 PM, Gary Thomas <gary@mlbassoc.com <mailto:gary@mlbassoc.com>> wrote:
>
>     Update license checksum to follow changes in OE-core
>
>     Signed-off-by: Gary Thomas <gary@mlbassoc.com <mailto:gary@mlbassoc.com>>
>
>
> To avoid using it to happen in future, please rework this as I did in:
>
> http://git.yoctoproject.org/cgit/cgit.cgi/meta-fsl-arm/commit/?id=a99e70cbb501f992abb8f80218fc5fb2a4fd6224

Not my place to make such a change - those are completely different
license files.  One refers to exactly GPL-2 while the other says that
the licence may be any of a set.

I only proposed the direct change which matches the changed checksum.
You'll have to make any actual license file changes.
Otavio Salvador - Jan. 15, 2014, 11:26 p.m.
On Wed, Jan 15, 2014 at 7:22 PM, Gary Thomas <gary@mlbassoc.com> wrote:

> On 2014-01-15 12:47, Otavio Salvador wrote:
>
>> On Wed, Jan 15, 2014 at 1:58 PM, Gary Thomas <gary@mlbassoc.com <mailto:
>> gary@mlbassoc.com>> wrote:
>>
>>     Update license checksum to follow changes in OE-core
>>
>>     Signed-off-by: Gary Thomas <gary@mlbassoc.com <mailto:
>> gary@mlbassoc.com>>
>>
>>
>>
>> To avoid using it to happen in future, please rework this as I did in:
>>
>> http://git.yoctoproject.org/cgit/cgit.cgi/meta-fsl-arm/commit/?id=
>> a99e70cbb501f992abb8f80218fc5fb2a4fd6224
>>
>
> Not my place to make such a change - those are completely different
> license files.  One refers to exactly GPL-2 while the other says that
> the licence may be any of a set.
>

The license, in the LICENSE field, is not changed and this checksum was
just to allow the recipe to be parsed. It makes more sense to use the
respective license file. The best fix is, in future, Freescale, include a
proper license file on the release tarball of those packages but in
meanwhile is the a good interim solution.

When we have multiple, we can use the checksums for the specific files as
well.

I only proposed the direct change which matches the changed checksum.
> You'll have to make any actual license file changes.
>

I'd like to ask you to just do as I said above. I can ask Lauren to review
those patches before commiting those so we are all comfortable with the
change.

What do you think?
Gary Thomas - Jan. 15, 2014, 11:42 p.m.
On 2014-01-15 16:26, Otavio Salvador wrote:
> On Wed, Jan 15, 2014 at 7:22 PM, Gary Thomas <gary@mlbassoc.com <mailto:gary@mlbassoc.com>> wrote:
>
>     On 2014-01-15 12:47, Otavio Salvador wrote:
>
>         On Wed, Jan 15, 2014 at 1:58 PM, Gary Thomas <gary@mlbassoc.com <mailto:gary@mlbassoc.com> <mailto:gary@mlbassoc.com <mailto:gary@mlbassoc.com>>> wrote:
>
>              Update license checksum to follow changes in OE-core
>
>              Signed-off-by: Gary Thomas <gary@mlbassoc.com <mailto:gary@mlbassoc.com> <mailto:gary@mlbassoc.com <mailto:gary@mlbassoc.com>>>
>
>
>
>         To avoid using it to happen in future, please rework this as I did in:
>
>         http://git.yoctoproject.org/__cgit/cgit.cgi/meta-fsl-arm/__commit/?id=__a99e70cbb501f992abb8f80218fc5f__b2a4fd6224
>         <http://git.yoctoproject.org/cgit/cgit.cgi/meta-fsl-arm/commit/?id=a99e70cbb501f992abb8f80218fc5fb2a4fd6224>
>
>
>     Not my place to make such a change - those are completely different
>     license files.  One refers to exactly GPL-2 while the other says that
>     the licence may be any of a set.
>
>
> The license, in the LICENSE field, is not changed and this checksum was just to allow the recipe to be parsed. It makes more sense to use the respective license file. The best fix
> is, in future, Freescale, include a proper license file on the release tarball of those packages but in meanwhile is the a good interim solution.

I don't see this.  It looks to me like you are changing the license from
   file://${COREBASE}/LICENSE
to a completely different file
   file://${COREBASE}/meta/files/common-licenses/GPL-2.0

At least that's what's in the change you quoted (above).

I'm only comfortable changing the checksum - not the file being used.

>
> When we have multiple, we can use the checksums for the specific files as well.
>
>     I only proposed the direct change which matches the changed checksum.
>     You'll have to make any actual license file changes.
>
>
> I'd like to ask you to just do as I said above. I can ask Lauren to review those patches before commiting those so we are all comfortable with the change.
>
> What do you think?
>
> --
> Otavio Salvador                             O.S. Systems
> http://www.ossystems.com.br http://code.ossystems.com.br
> Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
Philip Craig - Jan. 16, 2014, 3 a.m.
On Thu, Jan 16, 2014 at 9:26 AM, Otavio Salvador
<otavio@ossystems.com.br> wrote:
> On Wed, Jan 15, 2014 at 7:22 PM, Gary Thomas <gary@mlbassoc.com> wrote:
>>
>> On 2014-01-15 12:47, Otavio Salvador wrote:
>>>
>>> On Wed, Jan 15, 2014 at 1:58 PM, Gary Thomas <gary@mlbassoc.com
>>> <mailto:gary@mlbassoc.com>> wrote:
>>>
>>>     Update license checksum to follow changes in OE-core
>>>
>>>     Signed-off-by: Gary Thomas <gary@mlbassoc.com
>>> <mailto:gary@mlbassoc.com>>
>>>
>>>
>>>
>>> To avoid using it to happen in future, please rework this as I did in:
>>>
>>>
>>> http://git.yoctoproject.org/cgit/cgit.cgi/meta-fsl-arm/commit/?id=a99e70cbb501f992abb8f80218fc5fb2a4fd6224
>>
>>
>> Not my place to make such a change - those are completely different
>> license files.  One refers to exactly GPL-2 while the other says that
>> the licence may be any of a set.
>
>
> The license, in the LICENSE field, is not changed and this checksum was just
> to allow the recipe to be parsed. It makes more sense to use the respective
> license file. The best fix is, in future, Freescale, include a proper
> license file on the release tarball of those packages but in meanwhile is
> the a good interim solution.

imx-kobs already has a COPYING file. The recipe should use that instead.
Otavio Salvador - Jan. 16, 2014, 12:19 p.m.
Hello Philip,

On Thu, Jan 16, 2014 at 1:00 AM, Philip Craig <phil@blackmoth.com.au> wrote:

> COPYING


Great; I didn't notice it has it. Can you cook a patch using it?

Patch

diff --git a/recipes-bsp/imx-kobs/imx-kobs_3.5.7-1.0.0.bb b/recipes-bsp/imx-kobs/imx-kobs_3.5.7-1.0.0.bb
index 8c433e3..ac19d71 100644
--- a/recipes-bsp/imx-kobs/imx-kobs_3.5.7-1.0.0.bb
+++ b/recipes-bsp/imx-kobs/imx-kobs_3.5.7-1.0.0.bb
@@ -5,7 +5,7 @@  DESCRIPTION = "Nand boot write source for IMX BSP"
 SECTION = "base"
 DEPENDS = "virtual/kernel"
 LICENSE = "GPLv2"
-LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58"
+LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=4d92cd373abda3937c2bc47fbc49d690"
 
 SRC_URI = "${FSL_MIRROR}/imx-kobs-${PV}.tar.gz"
 SRC_URI[md5sum] = "1c07f922215d1fe7e202d1ba3dca0293"