Patchwork [meta-oe,v2] inetutils: fix libreadline path to fix QA errors

login
register
mail settings
Submitter Ting Liu
Date Jan. 15, 2014, 7:36 a.m.
Message ID <1389771373-5181-1-git-send-email-b28495@freescale.com>
Download mbox | patch
Permalink /patch/64797/
State Accepted, archived
Headers show

Comments

Ting Liu - Jan. 15, 2014, 7:36 a.m.
From: Ting Liu <b28495@freescale.com>

If wrong path set, inetutils configure script will add a absolute
rpath, which result in the below QA errors:
| ERROR: QA Issue: package inetutils-ftp contains bad RPATH
| ERROR: QA Issue: package inetutils-telnet contains bad RPATH
| ERROR: QA Issue: package inetutils-telnetd contains bad RPATH
| ERROR: QA run found fatal errors. Please consider fixing them.
| ERROR: Function failed: do_package_qa

Signed-off-by: Ting Liu <b28495@freescale.com>
---
 .../inetutils/inetutils_1.9.1.bb                   |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Martin Jansa - Jan. 15, 2014, 10:29 a.m.
On Wed, Jan 15, 2014 at 01:36:13AM -0600, b28495@freescale.com wrote:
> From: Ting Liu <b28495@freescale.com>
> 
> If wrong path set, inetutils configure script will add a absolute
> rpath, which result in the below QA errors:
> | ERROR: QA Issue: package inetutils-ftp contains bad RPATH
> | ERROR: QA Issue: package inetutils-telnet contains bad RPATH
> | ERROR: QA Issue: package inetutils-telnetd contains bad RPATH
> | ERROR: QA run found fatal errors. Please consider fixing them.
> | ERROR: Function failed: do_package_qa
> 
> Signed-off-by: Ting Liu <b28495@freescale.com>
> ---
>  .../inetutils/inetutils_1.9.1.bb                   |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta-networking/recipes-connectivity/inetutils/inetutils_1.9.1.bb b/meta-networking/recipes-connectivity/inetutils/inetutils_1.9.1.bb
> index 97fc6a1..80022c7 100644
> --- a/meta-networking/recipes-connectivity/inetutils/inetutils_1.9.1.bb
> +++ b/meta-networking/recipes-connectivity/inetutils/inetutils_1.9.1.bb
> @@ -37,7 +37,7 @@ PACKAGECONFIG[uucpd] = "--enable-uucpd,--disable-uucpd,readline"
>  
>  EXTRA_OECONF = "--with-ncurses-include-dir=${STAGING_INCDIR} \
>          ${noipv6} \
> -        --with-libreadline-prefix=${STAGING_DIR_HOST}${prefix} \
> +        --with-libreadline-prefix=${STAGING_LIBDIR} \

Can you confirm that libreadline support is still enabled after this change?

>  "
>  
>  do_configure_prepend () {
> -- 
> 1.7.9.7
> 
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Ting Liu - Jan. 15, 2014, 2:31 p.m.
> -----Original Message-----
> From: openembedded-devel-bounces@lists.openembedded.org
> [mailto:openembedded-devel-bounces@lists.openembedded.org] On Behalf Of
> Martin Jansa
> Sent: Wednesday, January 15, 2014 6:29 PM
> To: openembedded-devel@lists.openembedded.org
> Subject: Re: [oe] [meta-oe][PATCH v2] inetutils: fix libreadline path to
> fix QA errors
> 
> On Wed, Jan 15, 2014 at 01:36:13AM -0600, b28495@freescale.com wrote:
> > From: Ting Liu <b28495@freescale.com>
> >
> > If wrong path set, inetutils configure script will add a absolute
> > rpath, which result in the below QA errors:
> > | ERROR: QA Issue: package inetutils-ftp contains bad RPATH
> > | ERROR: QA Issue: package inetutils-telnet contains bad RPATH
> > | ERROR: QA Issue: package inetutils-telnetd contains bad RPATH
> > | ERROR: QA run found fatal errors. Please consider fixing them.
> > | ERROR: Function failed: do_package_qa
> >
> > Signed-off-by: Ting Liu <b28495@freescale.com>
> > ---
> >  .../inetutils/inetutils_1.9.1.bb                   |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git
> > a/meta-networking/recipes-connectivity/inetutils/inetutils_1.9.1.bb
> > b/meta-networking/recipes-connectivity/inetutils/inetutils_1.9.1.bb
> > index 97fc6a1..80022c7 100644
> > ---
> > a/meta-networking/recipes-connectivity/inetutils/inetutils_1.9.1.bb
> > +++ b/meta-networking/recipes-connectivity/inetutils/inetutils_1.9.1.b
> > +++ b
> > @@ -37,7 +37,7 @@ PACKAGECONFIG[uucpd] = "--enable-uucpd,--disable-
> uucpd,readline"
> >
> >  EXTRA_OECONF = "--with-ncurses-include-dir=${STAGING_INCDIR} \
> >          ${noipv6} \
> > -        --with-libreadline-prefix=${STAGING_DIR_HOST}${prefix} \
> > +        --with-libreadline-prefix=${STAGING_LIBDIR} \
> 
> Can you confirm that libreadline support is still enabled after this
> change?

Here is the log grabbed from log.do_configure:

checking for shared library run path origin... done
checking for readline... yes
checking how to link with libreadline... -lreadline
checking readline/readline.h usability... yes
checking readline/readline.h presence... yes
checking for readline/readline.h... yes
checking readline/history.h usability... yes
checking readline/history.h presence... yes
checking for readline/history.h... yes
checking for crypt in -lcrypt... yes

Without this patch, the log is:

checking for shared library run path origin... done
checking for readline... yes
checking how to link with libreadline... /home/liut/upstream/build_t4240qds-64b_release/tmp/sysroots/t4240qds-64b/usr/lib64/libreadline.so -Wl,-rpath -Wl,/home/liut/upstream/build_t4240qds-64b_release/tmp/sysroots/t4240qds-64b/usr/lib64
checking readline/readline.h usability... yes
checking readline/readline.h presence... yes
checking for readline/readline.h... yes
checking readline/history.h usability... yes
checking readline/history.h presence... yes
checking for readline/history.h... yes
checking for crypt in -lcrypt... yes

> 
> >  "
> >
> >  do_configure_prepend () {
> > --
> > 1.7.9.7
> >
> >
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> 
> --
> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

Patch

diff --git a/meta-networking/recipes-connectivity/inetutils/inetutils_1.9.1.bb b/meta-networking/recipes-connectivity/inetutils/inetutils_1.9.1.bb
index 97fc6a1..80022c7 100644
--- a/meta-networking/recipes-connectivity/inetutils/inetutils_1.9.1.bb
+++ b/meta-networking/recipes-connectivity/inetutils/inetutils_1.9.1.bb
@@ -37,7 +37,7 @@  PACKAGECONFIG[uucpd] = "--enable-uucpd,--disable-uucpd,readline"
 
 EXTRA_OECONF = "--with-ncurses-include-dir=${STAGING_INCDIR} \
         ${noipv6} \
-        --with-libreadline-prefix=${STAGING_DIR_HOST}${prefix} \
+        --with-libreadline-prefix=${STAGING_LIBDIR} \
 "
 
 do_configure_prepend () {