Patchwork [dora,0/2] Dora backports

login
register
mail settings
Submitter Martin Jansa
Date Jan. 6, 2014, 10:21 a.m.
Message ID <cover.1389003637.git.Martin.Jansa@gmail.com>
Download mbox
Permalink /patch/64137/
State New
Headers show

Pull-request

git://git.openembedded.org/openembedded-core-contrib jansa/dora-backports2

Comments

Martin Jansa - Jan. 6, 2014, 10:21 a.m.
The following changes since commit e86622a932bbd0acdea67ecfb15c8b06c27353d8:

  libsoup-2.4: add intltool-native to DEPENDS (2013-12-19 14:59:47 +0000)

are available in the git repository at:

  git://git.openembedded.org/openembedded-core-contrib jansa/dora-backports2
  http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=jansa/dora-backports2

Martin Jansa (1):
  ltp: set PREFERRED_PROVIDER and rename runtests_noltp.sh script

Richard Purdie (1):
  eglibc-initial.inc: Drop duplicate include

 meta/conf/distro/include/default-providers.inc     |   2 +
 meta/recipes-core/eglibc/eglibc-initial.inc        |   2 -
 ...tests_noltp.sh-script-so-have-unique-name.patch | 202 +++++++++++++++++++++
 meta/recipes-extended/ltp/ltp_20130503.bb          |   4 +-
 4 files changed, 207 insertions(+), 3 deletions(-)
 create mode 100644 meta/recipes-extended/ltp/ltp/0001-Rename-runtests_noltp.sh-script-so-have-unique-name.patch
Robert Yang - Jan. 10, 2014, 6:18 a.m.
Hi Martin,

Thanks, please see my comments in line.

On 01/06/2014 06:21 PM, Martin Jansa wrote:
> The following changes since commit e86622a932bbd0acdea67ecfb15c8b06c27353d8:
>
>    libsoup-2.4: add intltool-native to DEPENDS (2013-12-19 14:59:47 +0000)
>
> are available in the git repository at:
>
>    git://git.openembedded.org/openembedded-core-contrib jansa/dora-backports2
>    http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=jansa/dora-backports2
>
> Martin Jansa (1):
>    ltp: set PREFERRED_PROVIDER and rename runtests_noltp.sh script
>

I will take this.

> Richard Purdie (1):
>    eglibc-initial.inc: Drop duplicate include
>


It seems that this is a trivial fix, I don't think it's a good idea to merge
it to dora.

// Robert

>   meta/conf/distro/include/default-providers.inc     |   2 +
>   meta/recipes-core/eglibc/eglibc-initial.inc        |   2 -
>   ...tests_noltp.sh-script-so-have-unique-name.patch | 202 +++++++++++++++++++++
>   meta/recipes-extended/ltp/ltp_20130503.bb          |   4 +-
>   4 files changed, 207 insertions(+), 3 deletions(-)
>   create mode 100644 meta/recipes-extended/ltp/ltp/0001-Rename-runtests_noltp.sh-script-so-have-unique-name.patch
>
Richard Purdie - Jan. 10, 2014, 10:41 a.m.
On Fri, 2014-01-10 at 14:18 +0800, Robert Yang wrote:
> Hi Martin,
> 
> Thanks, please see my comments in line.
> 
> On 01/06/2014 06:21 PM, Martin Jansa wrote:
> > The following changes since commit e86622a932bbd0acdea67ecfb15c8b06c27353d8:
> >
> >    libsoup-2.4: add intltool-native to DEPENDS (2013-12-19 14:59:47 +0000)
> >
> > are available in the git repository at:
> >
> >    git://git.openembedded.org/openembedded-core-contrib jansa/dora-backports2
> >    http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=jansa/dora-backports2
> >
> > Martin Jansa (1):
> >    ltp: set PREFERRED_PROVIDER and rename runtests_noltp.sh script
> >
> 
> I will take this.
> 
> > Richard Purdie (1):
> >    eglibc-initial.inc: Drop duplicate include
> >
> 
> 
> It seems that this is a trivial fix, I don't think it's a good idea to merge
> it to dora.

Thanks to one of the bitbake patches we backported, this "trivial" issue
is now putting warnings in peoples builds so I think it might be a good
idea to fix it.

Cheers,

Richard
Martin Jansa - Jan. 10, 2014, 11:02 a.m.
On Fri, Jan 10, 2014 at 02:18:51PM +0800, Robert Yang wrote:
> 
> Hi Martin,
> 
> Thanks, please see my comments in line.
> 
> On 01/06/2014 06:21 PM, Martin Jansa wrote:
> > The following changes since commit e86622a932bbd0acdea67ecfb15c8b06c27353d8:
> >
> >    libsoup-2.4: add intltool-native to DEPENDS (2013-12-19 14:59:47 +0000)
> >
> > are available in the git repository at:
> >
> >    git://git.openembedded.org/openembedded-core-contrib jansa/dora-backports2
> >    http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=jansa/dora-backports2
> >
> > Martin Jansa (1):
> >    ltp: set PREFERRED_PROVIDER and rename runtests_noltp.sh script
> >
> 
> I will take this.
> 
> > Richard Purdie (1):
> >    eglibc-initial.inc: Drop duplicate include
> >
> 
> 
> It seems that this is a trivial fix, I don't think it's a good idea to merge
> it to dora.

And the warning shown in every dora build since
http://git.openembedded.org/bitbake/commit/?h=1.20&id=22e6b1c4c4afb27057689bbc94cbdf1f19f93e3d
isn't important enough reason to merge it?

> 
> // Robert
> 
> >   meta/conf/distro/include/default-providers.inc     |   2 +
> >   meta/recipes-core/eglibc/eglibc-initial.inc        |   2 -
> >   ...tests_noltp.sh-script-so-have-unique-name.patch | 202 +++++++++++++++++++++
> >   meta/recipes-extended/ltp/ltp_20130503.bb          |   4 +-
> >   4 files changed, 207 insertions(+), 3 deletions(-)
> >   create mode 100644 meta/recipes-extended/ltp/ltp/0001-Rename-runtests_noltp.sh-script-so-have-unique-name.patch
> >
Mark Hatle - Jan. 10, 2014, 4:51 p.m.
On 1/10/14, 4:41 AM, Richard Purdie wrote:
> On Fri, 2014-01-10 at 14:18 +0800, Robert Yang wrote:
>> Hi Martin,
>>
>> Thanks, please see my comments in line.
>>
>> On 01/06/2014 06:21 PM, Martin Jansa wrote:
>>> The following changes since commit e86622a932bbd0acdea67ecfb15c8b06c27353d8:
>>>
>>>     libsoup-2.4: add intltool-native to DEPENDS (2013-12-19 14:59:47 +0000)
>>>
>>> are available in the git repository at:
>>>
>>>     git://git.openembedded.org/openembedded-core-contrib jansa/dora-backports2
>>>     http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=jansa/dora-backports2
>>>
>>> Martin Jansa (1):
>>>     ltp: set PREFERRED_PROVIDER and rename runtests_noltp.sh script
>>>
>>
>> I will take this.
>>
>>> Richard Purdie (1):
>>>     eglibc-initial.inc: Drop duplicate include
>>>
>>
>>
>> It seems that this is a trivial fix, I don't think it's a good idea to merge
>> it to dora.
>
> Thanks to one of the bitbake patches we backported, this "trivial" issue
> is now putting warnings in peoples builds so I think it might be a good
> idea to fix it.

Ya I agree.  This is going to cause confusion for people.  Being a small 2 line 
patch, and pretty easy to show that it's "safe".  I'd also recommend that that 
backport be accepted.

--Mark

> Cheers,
>
> Richard
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
Koen Kooi - Jan. 11, 2014, 3:11 p.m.
Op 10 jan. 2014, om 17:51 heeft Mark Hatle <mark.hatle@windriver.com> het volgende geschreven:

> On 1/10/14, 4:41 AM, Richard Purdie wrote:
>> On Fri, 2014-01-10 at 14:18 +0800, Robert Yang wrote:
>>> Hi Martin,
>>> 
>>> Thanks, please see my comments in line.
>>> 
>>> On 01/06/2014 06:21 PM, Martin Jansa wrote:
>>>> The following changes since commit e86622a932bbd0acdea67ecfb15c8b06c27353d8:
>>>> 
>>>>    libsoup-2.4: add intltool-native to DEPENDS (2013-12-19 14:59:47 +0000)
>>>> 
>>>> are available in the git repository at:
>>>> 
>>>>    git://git.openembedded.org/openembedded-core-contrib jansa/dora-backports2
>>>>    http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=jansa/dora-backports2
>>>> 
>>>> Martin Jansa (1):
>>>>    ltp: set PREFERRED_PROVIDER and rename runtests_noltp.sh script
>>>> 
>>> 
>>> I will take this.
>>> 
>>>> Richard Purdie (1):
>>>>    eglibc-initial.inc: Drop duplicate include
>>>> 
>>> 
>>> 
>>> It seems that this is a trivial fix, I don't think it's a good idea to merge
>>> it to dora.
>> 
>> Thanks to one of the bitbake patches we backported, this "trivial" issue
>> is now putting warnings in peoples builds so I think it might be a good
>> idea to fix it.
> 
> Ya I agree.  This is going to cause confusion for people.  Being a small 2 line patch, and pretty easy to show that it's "safe".  I'd also recommend that that backport be accepted.

I agree as well.

regards,

Koen
Robert Yang - Jan. 13, 2014, 1:54 a.m.
On 01/10/2014 07:02 PM, Martin Jansa wrote:
> On Fri, Jan 10, 2014 at 02:18:51PM +0800, Robert Yang wrote:
>>
>> Hi Martin,
>>
>> Thanks, please see my comments in line.
>>
>> On 01/06/2014 06:21 PM, Martin Jansa wrote:
>>> The following changes since commit e86622a932bbd0acdea67ecfb15c8b06c27353d8:
>>>
>>>     libsoup-2.4: add intltool-native to DEPENDS (2013-12-19 14:59:47 +0000)
>>>
>>> are available in the git repository at:
>>>
>>>     git://git.openembedded.org/openembedded-core-contrib jansa/dora-backports2
>>>     http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=jansa/dora-backports2
>>>
>>> Martin Jansa (1):
>>>     ltp: set PREFERRED_PROVIDER and rename runtests_noltp.sh script
>>>
>>
>> I will take this.
>>
>>> Richard Purdie (1):
>>>     eglibc-initial.inc: Drop duplicate include
>>>
>>
>>
>> It seems that this is a trivial fix, I don't think it's a good idea to merge
>> it to dora.
>
> And the warning shown in every dora build since
> http://git.openembedded.org/bitbake/commit/?h=1.20&id=22e6b1c4c4afb27057689bbc94cbdf1f19f93e3d
> isn't important enough reason to merge it?
>

OK, thanks to all, I will take it.

// Robert

>>
>> // Robert
>>
>>>    meta/conf/distro/include/default-providers.inc     |   2 +
>>>    meta/recipes-core/eglibc/eglibc-initial.inc        |   2 -
>>>    ...tests_noltp.sh-script-so-have-unique-name.patch | 202 +++++++++++++++++++++
>>>    meta/recipes-extended/ltp/ltp_20130503.bb          |   4 +-
>>>    4 files changed, 207 insertions(+), 3 deletions(-)
>>>    create mode 100644 meta/recipes-extended/ltp/ltp/0001-Rename-runtests_noltp.sh-script-so-have-unique-name.patch
>>>
>