Patchwork valgrind: rrecommend libc6-dbg on all architectures

login
register
mail settings
Submitter Mike Crowe
Date Jan. 3, 2014, 2:28 p.m.
Message ID <1388759319-9913-1-git-send-email-mac@mcrowe.com>
Download mbox | patch
Permalink /patch/64055/
State Accepted
Commit 9a60c5e1131ace37894f9a94e5aab6d8b885bbd0
Headers show

Comments

Mike Crowe - Jan. 3, 2014, 2:28 p.m.
It seems that valgrind requires debug symbols to be available on all
architectures so there's no reason to treat arm and powerpc specially.

Ensuring that libc6-dbg is installed avoids errors like this on x86:

  valgrind:  Fatal error at startup: a function redirection
  valgrind:  which is mandatory for this platform-tool combination
  valgrind:  cannot be set up.  Details of the redirection are:
  valgrind:
  valgrind:  A must-be-redirected function
  valgrind:  whose name matches the pattern:      strlen
  valgrind:  in an object with soname matching:   ld-linux.so.2
  valgrind:  was not found whilst processing
  valgrind:  symbols from the object with soname: ld-linux.so.2
  valgrind:
  valgrind:  Possible fixes: (1, short term): install glibc's debuginfo
  valgrind:  package on this machine.  (2, longer term): ask the packagers
  valgrind:  for your Linux distribution to please in future ship a non-
  valgrind:  stripped ld.so (or whatever the dynamic linker .so is called)
  valgrind:  that exports the above-named function using the standard
  valgrind:  calling conventions for this platform.  The package you need
  valgrind:  to install for fix (1) is called
  valgrind:
  valgrind:    On Debian, Ubuntu:                 libc6-dbg
  valgrind:    On SuSE, openSuSE, Fedora, RHEL:   glibc-debuginfo
  valgrind:
  valgrind:  Cannot continue -- exiting now.  Sorry.

Signed-off-by: Mike Crowe <mac@mcrowe.com>
---
 meta/recipes-devtools/valgrind/valgrind_3.9.0.bb |    7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

Patch

diff --git a/meta/recipes-devtools/valgrind/valgrind_3.9.0.bb b/meta/recipes-devtools/valgrind/valgrind_3.9.0.bb
index 216fdab..e1fb568 100644
--- a/meta/recipes-devtools/valgrind/valgrind_3.9.0.bb
+++ b/meta/recipes-devtools/valgrind/valgrind_3.9.0.bb
@@ -37,6 +37,7 @@  do_install_append () {
 RDEPENDS_${PN} += "perl"
 
 FILES_${PN}-dbg += "${libdir}/${PN}/*/.debug/*"
-RRECOMMENDS_${PN}_powerpc += "${TCLIBC}-dbg"
-RRECOMMENDS_${PN}_powerpc64 += "${TCLIBC}-dbg"
-RRECOMMENDS_${PN}_armv7a += "${TCLIBC}-dbg"
+
+# valgrind needs debug information for ld.so at runtime in order to
+# redirect functions like strlen.
+RRECOMMENDS_${PN} += "${TCLIBC}-dbg"