Patchwork guile: fix the depends for target recipes

login
register
mail settings
Submitter jackie huang
Date Jan. 3, 2014, 9:37 a.m.
Message ID <1388741852-17520-1-git-send-email-jackie.huang@windriver.com>
Download mbox | patch
Permalink /patch/64025/
State New
Headers show

Comments

jackie huang - Jan. 3, 2014, 9:37 a.m.
From: Jackie Huang <jackie.huang@windriver.com>

The depenency on guild-native and libatomics-ops is missing
in multilib build, fix the depends with class-target.

Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
---
 meta/recipes-devtools/guile/guile_2.0.9.bb |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Martin Jansa - Jan. 3, 2014, 10:15 a.m.
On Fri, Jan 03, 2014 at 05:37:32PM +0800, jackie.huang@windriver.com wrote:
> From: Jackie Huang <jackie.huang@windriver.com>
> 
> The depenency on guild-native and libatomics-ops is missing
> in multilib build, fix the depends with class-target.
> 
> Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
> ---
>  meta/recipes-devtools/guile/guile_2.0.9.bb |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-devtools/guile/guile_2.0.9.bb b/meta/recipes-devtools/guile/guile_2.0.9.bb
> index 4c3fe28..cb7c72e 100644
> --- a/meta/recipes-devtools/guile/guile_2.0.9.bb
> +++ b/meta/recipes-devtools/guile/guile_2.0.9.bb
> @@ -33,7 +33,7 @@ BBCLASSEXTEND = "native"
>  
>  DEPENDS = "libunistring bdwgc gmp libtool libffi"
>  # add guile-native only to the target recipe's DEPENDS
> -DEPENDS += "${@['guile-native libatomics-ops', ''][d.getVar('PN', True) != 'guile']}"
> +DEPENDS_append_class-target += "guile-native libatomics-ops"

Don't use _append together with +=, just add space before guile-native.

>  
>  RDEPENDS_${PN}_append_libc-glibc_class-target = "glibc-gconv-iso8859-1"
>  
> -- 
> 1.7.9.5
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
jackie huang - Jan. 6, 2014, 2:24 a.m.
On 1/3/2014 6:15 PM, Martin Jansa wrote:
> On Fri, Jan 03, 2014 at 05:37:32PM +0800, jackie.huang@windriver.com wrote:
>> From: Jackie Huang <jackie.huang@windriver.com>
>>
>> The depenency on guild-native and libatomics-ops is missing
>> in multilib build, fix the depends with class-target.
>>
>> Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
>> ---
>>   meta/recipes-devtools/guile/guile_2.0.9.bb |    2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-devtools/guile/guile_2.0.9.bb b/meta/recipes-devtools/guile/guile_2.0.9.bb
>> index 4c3fe28..cb7c72e 100644
>> --- a/meta/recipes-devtools/guile/guile_2.0.9.bb
>> +++ b/meta/recipes-devtools/guile/guile_2.0.9.bb
>> @@ -33,7 +33,7 @@ BBCLASSEXTEND = "native"
>>
>>   DEPENDS = "libunistring bdwgc gmp libtool libffi"
>>   # add guile-native only to the target recipe's DEPENDS
>> -DEPENDS += "${@['guile-native libatomics-ops', ''][d.getVar('PN', True) != 'guile']}"
>> +DEPENDS_append_class-target += "guile-native libatomics-ops"
>
> Don't use _append together with +=, just add space before guile-native.

Fixed and sent v2 for this, thanks!

Thanks,
Jackie

>
>>
>>   RDEPENDS_${PN}_append_libc-glibc_class-target = "glibc-gconv-iso8859-1"
>>
>> --
>> 1.7.9.5
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>

Patch

diff --git a/meta/recipes-devtools/guile/guile_2.0.9.bb b/meta/recipes-devtools/guile/guile_2.0.9.bb
index 4c3fe28..cb7c72e 100644
--- a/meta/recipes-devtools/guile/guile_2.0.9.bb
+++ b/meta/recipes-devtools/guile/guile_2.0.9.bb
@@ -33,7 +33,7 @@  BBCLASSEXTEND = "native"
 
 DEPENDS = "libunistring bdwgc gmp libtool libffi"
 # add guile-native only to the target recipe's DEPENDS
-DEPENDS += "${@['guile-native libatomics-ops', ''][d.getVar('PN', True) != 'guile']}"
+DEPENDS_append_class-target += "guile-native libatomics-ops"
 
 RDEPENDS_${PN}_append_libc-glibc_class-target = "glibc-gconv-iso8859-1"