Patchwork [1/2] gconf.bbclass: remove --disable-schemas-install

login
register
mail settings
Submitter Robert Yang
Date Jan. 3, 2014, 5:27 p.m.
Message ID <5b836adb7023cf075f9eb2246c7b2bbe420fd1cf.1388769973.git.liezhi.yang@windriver.com>
Download mbox | patch
Permalink /patch/64019/
State New
Headers show

Comments

Robert Yang - Jan. 3, 2014, 5:27 p.m.
Gnome has moved the schemas to the gsettings-desktop-schemas pkg, so
there is no --disable-schemas-install option any more, and we already
have the gsettings-desktop-schemas recipe, so remove it, it wil fix
the warning:

configure was passed unrecognised options: --disable-schemas-install

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
---
 meta/classes/gconf.bbclass | 6 ------
 1 file changed, 6 deletions(-)
Ross Burton - Jan. 6, 2014, 3:47 p.m.
On 3 January 2014 17:27, Robert Yang <liezhi.yang@windriver.com> wrote:
> Gnome has moved the schemas to the gsettings-desktop-schemas pkg, so
> there is no --disable-schemas-install option any more, and we already
> have the gsettings-desktop-schemas recipe, so remove it, it wil fix
> the warning:
>
> configure was passed unrecognised options: --disable-schemas-install

I'd NAK this but it's too late as I see it's been merged.

*Some* packages have migrated away from gconf to gsettings.  Not all
packages have done this, so anything still using gconf is now broken.
Note that almost nothing in oe-core uses gsettings as we're still
using the GTK+ 2 stack generally.

The problem is that people are using gnome.bbclass which is a kitchen
sink class, inheriting many other classes that may or may not be used.
 To resolve this warning gnome.bbclass should extend the sanity check
whitelist with --disable-schemas-install as it is the class causing
gconf.bbclass to be inherited on recipes that don't use gconf.

Ross
Robert Yang - Jan. 7, 2014, 1:05 p.m.
On 01/06/2014 11:47 PM, Burton, Ross wrote:
> On 3 January 2014 17:27, Robert Yang <liezhi.yang@windriver.com> wrote:
>> Gnome has moved the schemas to the gsettings-desktop-schemas pkg, so
>> there is no --disable-schemas-install option any more, and we already
>> have the gsettings-desktop-schemas recipe, so remove it, it wil fix
>> the warning:
>>
>> configure was passed unrecognised options: --disable-schemas-install
>
> I'd NAK this but it's too late as I see it's been merged.
>
> *Some* packages have migrated away from gconf to gsettings.  Not all
> packages have done this, so anything still using gconf is now broken.
> Note that almost nothing in oe-core uses gsettings as we're still
> using the GTK+ 2 stack generally.
>

Hi Ross, which recipe is failed, please ?

// Robert

> The problem is that people are using gnome.bbclass which is a kitchen
> sink class, inheriting many other classes that may or may not be used.
>   To resolve this warning gnome.bbclass should extend the sanity check
> whitelist with --disable-schemas-install as it is the class causing
> gconf.bbclass to be inherited on recipes that don't use gconf.
>
> Ross
>
>
Ross Burton - Jan. 8, 2014, 4:12 p.m.
On 7 January 2014 13:05, Robert Yang <liezhi.yang@windriver.com> wrote:
>> *Some* packages have migrated away from gconf to gsettings.  Not all
>> packages have done this, so anything still using gconf is now broken.
>> Note that almost nothing in oe-core uses gsettings as we're still
>> using the GTK+ 2 stack generally.
>
> Hi Ross, which recipe is failed, please ?

A better question would be what package did you get this warning from?

As I said, any recipe that did inherit gnome and still used GConf
would be affected by your change.

Ross
Koen Kooi - Jan. 9, 2014, 6:33 a.m.
Op 8 jan. 2014, om 17:12 heeft Burton, Ross <ross.burton@intel.com> het volgende geschreven:

> On 7 January 2014 13:05, Robert Yang <liezhi.yang@windriver.com> wrote:
>>> *Some* packages have migrated away from gconf to gsettings.  Not all
>>> packages have done this, so anything still using gconf is now broken.
>>> Note that almost nothing in oe-core uses gsettings as we're still
>>> using the GTK+ 2 stack generally.
>> 
>> Hi Ross, which recipe is failed, please ?
> 
> A better question would be what package did you get this warning from?
> 
> As I said, any recipe that did inherit gnome and still used GConf
> would be affected by your change.

Which is over half of the meta-gnome recipes :(
Robert Yang - Jan. 13, 2014, 2 a.m.
On 01/09/2014 02:33 PM, Koen Kooi wrote:
>
> Op 8 jan. 2014, om 17:12 heeft Burton, Ross <ross.burton@intel.com> het volgende geschreven:
>
>> On 7 January 2014 13:05, Robert Yang <liezhi.yang@windriver.com> wrote:
>>>> *Some* packages have migrated away from gconf to gsettings.  Not all
>>>> packages have done this, so anything still using gconf is now broken.
>>>> Note that almost nothing in oe-core uses gsettings as we're still
>>>> using the GTK+ 2 stack generally.
>>>
>>> Hi Ross, which recipe is failed, please ?
>>
>> A better question would be what package did you get this warning from?
>>
>> As I said, any recipe that did inherit gnome and still used GConf
>> would be affected by your change.
>
> Which is over half of the meta-gnome recipes :(
>

Sounds bad, fortunately, it had been reverted.

// Robert

Patch

diff --git a/meta/classes/gconf.bbclass b/meta/classes/gconf.bbclass
index e9076b2..8ebb512 100644
--- a/meta/classes/gconf.bbclass
+++ b/meta/classes/gconf.bbclass
@@ -7,12 +7,6 @@  DEPENDS += "gconf gconf-native"
 export GCONF_SCHEMA_INSTALL_SOURCE = "xml:merged:${STAGING_DIR_NATIVE}${sysconfdir}/gconf/gconf.xml.defaults"
 export GCONF_BACKEND_DIR = "${STAGING_LIBDIR_NATIVE}/GConf/2"
 
-# Disable install-time schema registration as we're a packaging system so this
-# happens in the postinst script, not at install time.  Set both the configure
-# script option and the traditional envionment variable just to make sure.
-EXTRA_OECONF += "--disable-schemas-install"
-export GCONF_DISABLE_MAKEFILE_SCHEMA_INSTALL = "1"
-
 gconf_postinst() {
 if [ "x$D" != "x" ]; then
 	export GCONF_CONFIG_SOURCE="xml::$D${sysconfdir}/gconf/gconf.xml.defaults"