Patchwork meta/lib/oe/terminal.py: Don't pass non-supported '--disable-factory' flag to gnome-terminal

login
register
mail settings
Submitter Jacob Kroon
Date Dec. 30, 2013, 6:17 p.m.
Message ID <1388427478-16741-1-git-send-email-jacob.kroon@mikrodidakt.se>
Download mbox | patch
Permalink /patch/63913/
State New
Headers show

Comments

Jacob Kroon - Dec. 30, 2013, 6:17 p.m.
From the gnome-terminal manpage:
By default, all GNOME terminals share a single process,
reducing memory usage.  This can be disabled by starting gnome-terminal
with the --disable-factory option

However, gnome-terminal in Fedora 20 does no longer support the
'--disable-factory' flag, so remove it. As the support for 'mate' terminals was
added as a copy of the gnome code in 8cc078a9c679845464c59028f584d7aba098cc1f,
remove the flag here aswell.

Signed-off-by: Jacob Kroon <jacob.kroon@mikrodidakt.se>
---
 meta/lib/oe/terminal.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Patch

diff --git a/meta/lib/oe/terminal.py b/meta/lib/oe/terminal.py
index be2a26b..a33abd7 100644
--- a/meta/lib/oe/terminal.py
+++ b/meta/lib/oe/terminal.py
@@ -52,11 +52,11 @@  class XTerminal(Terminal):
             raise UnsupportedTerminal(self.name)
 
 class Gnome(XTerminal):
-    command = 'gnome-terminal --disable-factory -t "{title}" -x {command}'
+    command = 'gnome-terminal -t "{title}" -x {command}'
     priority = 2
 
 class Mate(XTerminal):
-    command = 'mate-terminal --disable-factory -t "{title}" -x {command}'
+    command = 'mate-terminal -t "{title}" -x {command}'
     priority = 2
 
 class Xfce(XTerminal):