Patchwork libfso-qt-embedded: Do not override `DEPENDS`

login
register
mail settings
Submitter Paul Menzel
Date June 22, 2011, 10:51 p.m.
Message ID <1308783078.21159.17.camel@mattotaupa>
Download mbox | patch
Permalink /patch/6379/
State Accepted
Commit 99cad4f2f283149eb25be6723bfdc5ec117aafba
Headers show

Comments

Paul Menzel - June 22, 2011, 10:51 p.m.
Date: Wed, 22 Jun 2011 23:41:38 +0200

Using `=` instead of `+=` overrides the dependencies declared in `libfso-qt.inc`.

Task configure therefore fails with the following errors.

1. `fso-specs` is not found.

 	checking for SPECS... no
	configure: error: Package requirements (fso-specs >= 2011.06.01.1) were not met:

	No package 'fso-specs' found

2. `qfsodbusxml2cpp` is not found.

	checking for QFSODBUSXML2CPP... no
	configure: error: Package requirements (qfsodbusxml2cpp >= 0.7.0) were not met:

	No package 'qfsodbusxml2cpp' found

Using `+=` solves these problems and is built tested using `minimal` for `MACHINE = "beagleboard"`.

Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
CC: Simon Busch <morphis@gravedo.de>
---
 recipes/freesmartphone/libfso-qt-embedded_git.bb |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Simon Busch - June 23, 2011, 7:29 p.m.
On 23.06.2011 00:51, Paul Menzel wrote:
> Date: Wed, 22 Jun 2011 23:41:38 +0200
> 
> Using `=` instead of `+=` overrides the dependencies declared in `libfso-qt.inc`.

Thanks Paul for spotting this! Feel free to put my

Acked-by: Simon Busch <morphis@gravedo.de>

below the patch and push it!

regards,
Simon

Patch

diff --git a/recipes/freesmartphone/libfso-qt-embedded_git.bb b/recipes/freesmartphone/libfso-qt-embedded_git.bb
index 647f439..641cf8d 100644
--- a/recipes/freesmartphone/libfso-qt-embedded_git.bb
+++ b/recipes/freesmartphone/libfso-qt-embedded_git.bb
@@ -2,5 +2,5 @@  require libfso-qt.inc
 
 PR = "${INC_PR}.0"
 
-DEPENDS = "qt4-embedded"
+DEPENDS += "qt4-embedded"
 EXTRA_OECONF_append = "--enable-qt-embedded"