Patchwork [meta-fsl-arm-extra] cfa10058: fix touchscreen calibration

login
register
mail settings
Submitter Alexandre Belloni
Date Dec. 28, 2013, 10:31 a.m.
Message ID <1388226702-6377-1-git-send-email-alexandre.belloni@free-electrons.com>
Download mbox | patch
Permalink /patch/63773/
State Superseded
Delegated to: Otavio Salvador
Headers show

Comments

Alexandre Belloni - Dec. 28, 2013, 10:31 a.m.
Probably a copy paste error, the y_min and x_max got inverted.

Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
 .../xinput-calibrator/pointercal-xinput/cfa10058/pointercal.xinput      | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Alexandre Belloni - Dec. 28, 2013, 10:33 a.m.
I forgot to add, this is probably worth adding in dora.

On 28/12/2013 11:31, Alexandre Belloni wrote:
> Probably a copy paste error, the y_min and x_max got inverted.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
>  .../xinput-calibrator/pointercal-xinput/cfa10058/pointercal.xinput      | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/recipes-graphics/xinput-calibrator/pointercal-xinput/cfa10058/pointercal.xinput b/recipes-graphics/xinput-calibrator/pointercal-xinput/cfa10058/pointercal.xinput
> index 445863a87099..230619b3e9a6 100644
> --- a/recipes-graphics/xinput-calibrator/pointercal-xinput/cfa10058/pointercal.xinput
> +++ b/recipes-graphics/xinput-calibrator/pointercal-xinput/cfa10058/pointercal.xinput
> @@ -1,2 +1,2 @@
> -xinput set-int-prop "mxs-lradc" "Evdev Axis Calibration" 32 1373 1381 3391 3348
> +xinput set-int-prop "mxs-lradc" "Evdev Axis Calibration" 32 206 3985 3937 219
>  xinput set-int-prop "mxs-lradc" "Evdev Axes Swap" 8 0
Otavio Salvador - Dec. 30, 2013, 5:11 a.m.
On Sat, Dec 28, 2013 at 8:31 AM, Alexandre Belloni
<alexandre.belloni@free-electrons.com> wrote:
> Probably a copy paste error, the y_min and x_max got inverted.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>

The values does not match as inverted; I am OK with fixing the
calibration but the commit log message ought to be accurate.
Otavio Salvador - Jan. 6, 2014, 3:39 p.m.
Hello Alexandre,

On Mon, Dec 30, 2013 at 3:11 AM, Otavio Salvador
<otavio@ossystems.com.br> wrote:
> On Sat, Dec 28, 2013 at 8:31 AM, Alexandre Belloni
> <alexandre.belloni@free-electrons.com> wrote:
>> Probably a copy paste error, the y_min and x_max got inverted.
>>
>> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
>
> The values does not match as inverted; I am OK with fixing the
> calibration but the commit log message ought to be accurate.

ping?
Alexandre Belloni - Jan. 6, 2014, 4:46 p.m.
Hi,

On 06/01/2014 16:39, Otavio Salvador wrote:
> Hello Alexandre,
> 
> On Mon, Dec 30, 2013 at 3:11 AM, Otavio Salvador
> <otavio@ossystems.com.br> wrote:
>> On Sat, Dec 28, 2013 at 8:31 AM, Alexandre Belloni
>> <alexandre.belloni@free-electrons.com> wrote:
>>> Probably a copy paste error, the y_min and x_max got inverted.
>>>
>>> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
>>
>> The values does not match as inverted; I am OK with fixing the
>> calibration but the commit log message ought to be accurate.
> 
> ping?
> 

Actually, after bumping the 3.10 kernel, the calibration files won't be
necessary anymore. I backported
1eb70a97452cacbe7aae752879b782e1e97a3484 which fixes the first
calibration issue.

I'll send a patch removing those but I was waiting for the kernel to be
bumped first.
Otavio Salvador - Jan. 6, 2014, 5:05 p.m.
Hello Alexandre,

On Mon, Jan 6, 2014 at 2:46 PM, Alexandre Belloni
<alexandre.belloni@free-electrons.com> wrote:
> On 06/01/2014 16:39, Otavio Salvador wrote:
>> Hello Alexandre,
>>
>> On Mon, Dec 30, 2013 at 3:11 AM, Otavio Salvador
>> <otavio@ossystems.com.br> wrote:
>>> On Sat, Dec 28, 2013 at 8:31 AM, Alexandre Belloni
>>> <alexandre.belloni@free-electrons.com> wrote:
>>>> Probably a copy paste error, the y_min and x_max got inverted.
>>>>
>>>> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
>>>
>>> The values does not match as inverted; I am OK with fixing the
>>> calibration but the commit log message ought to be accurate.
>>
>> ping?
>>
>
> Actually, after bumping the 3.10 kernel, the calibration files won't be
> necessary anymore. I backported
> 1eb70a97452cacbe7aae752879b782e1e97a3484 which fixes the first
> calibration issue.
>
> I'll send a patch removing those but I was waiting for the kernel to be
> bumped first.

Great!

Patch

diff --git a/recipes-graphics/xinput-calibrator/pointercal-xinput/cfa10058/pointercal.xinput b/recipes-graphics/xinput-calibrator/pointercal-xinput/cfa10058/pointercal.xinput
index 445863a87099..230619b3e9a6 100644
--- a/recipes-graphics/xinput-calibrator/pointercal-xinput/cfa10058/pointercal.xinput
+++ b/recipes-graphics/xinput-calibrator/pointercal-xinput/cfa10058/pointercal.xinput
@@ -1,2 +1,2 @@ 
-xinput set-int-prop "mxs-lradc" "Evdev Axis Calibration" 32 1373 1381 3391 3348
+xinput set-int-prop "mxs-lradc" "Evdev Axis Calibration" 32 206 3985 3937 219
 xinput set-int-prop "mxs-lradc" "Evdev Axes Swap" 8 0