Patchwork libshiboken: Do not override `DEPENDS`

login
register
mail settings
Submitter Paul Menzel
Date June 22, 2011, 10:50 p.m.
Message ID <1308783016.21159.16.camel@mattotaupa>
Download mbox | patch
Permalink /patch/6377/
State Accepted
Commit 7858948b41842bc3317691d607078386773526d0
Headers show

Comments

Paul Menzel - June 22, 2011, 10:50 p.m.
Date: Mon, 20 Jun 2011 18:01:13 +0200

This is a fix up for commit 1b9260e7 [1].

	commit 1b9260e7a6c756d6938821f013a41c371065980a
	Author: Paul Menzel <paulepanter@users.sourceforge.net>
	Date:   Sun Jun 19 11:45:37 2011 +0200

		  shiboken: Add `apiextrator-native` to `DEPENDS`

This commit does not fix the mentioned error, that
`ApiExtractorConfig.cmake` is not built, since by using `=` instead of `
+=` the dependencies from the include file `shiboken.inc` are overriden
in the recipe.

This patch fixes the error and is built tested using `minimal` for
`MACHINE = "beagleboard"`.

[1] http://cgit.openembedded.org/cgit.cgi/openembedded/commit/?id=1b9260e7a6c756d6938821f013a41c371065980a

Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
CC: Simon Busch <morphis@gravedo.de>
---
 recipes/pyside/libshiboken_1.0.2.bb |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Simon Busch - June 23, 2011, 7:30 p.m.
On 23.06.2011 00:50, Paul Menzel wrote:
> Date: Mon, 20 Jun 2011 18:01:13 +0200
> 
> This is a fix up for commit 1b9260e7 [1].
> 
> 	commit 1b9260e7a6c756d6938821f013a41c371065980a
> 	Author: Paul Menzel <paulepanter@users.sourceforge.net>
> 	Date:   Sun Jun 19 11:45:37 2011 +0200
> 
> 		  shiboken: Add `apiextrator-native` to `DEPENDS`
> 
> This commit does not fix the mentioned error, that
> `ApiExtractorConfig.cmake` is not built, since by using `=` instead of `
> +=` the dependencies from the include file `shiboken.inc` are overriden
> in the recipe.
> 
> This patch fixes the error and is built tested using `minimal` for
> `MACHINE = "beagleboard"`.
> 
> [1] http://cgit.openembedded.org/cgit.cgi/openembedded/commit/?id=1b9260e7a6c756d6938821f013a41c371065980a

Thanks again Paul for spotting this! Feel free to put my

Acked-by: Simon Busch <morphis@gravedo.de>

below the patch and push it!

(don't know why I did the same error twice ... next time I should look a
little longer on my recipes to spot this stupid mistakes :)

regards,
Simon

Patch

diff --git a/recipes/pyside/libshiboken_1.0.2.bb b/recipes/pyside/libshiboken_1.0.2.bb
index a9edded..91ea29b 100644
--- a/recipes/pyside/libshiboken_1.0.2.bb
+++ b/recipes/pyside/libshiboken_1.0.2.bb
@@ -1,6 +1,6 @@ 
 require shiboken.inc
 
-DEPENDS = "python"
+DEPENDS += "python"
 RDEPENDS_${PN} = "python-core"
 PR = "${INC_PR}.1"