Patchwork [bitbake-devel,2/2] bitbake: fetcher2: git.py: clean(): remove the .tar.gz.done

login
register
mail settings
Submitter Robert Yang
Date Dec. 27, 2013, 6:51 a.m.
Message ID <4cee50f7cc50c44750c61f5bf5a45f29ad1b6342.1388127045.git.liezhi.yang@windriver.com>
Download mbox | patch
Permalink /patch/63751/
State New
Headers show

Comments

Robert Yang - Dec. 27, 2013, 6:51 a.m.
There was a problem:

$ bitbake xf86-video-omapfb -cfetch && bitbake xf86-video-omapfb -ccleanall

The git2_git.pingu.fi.xf86-video-omapfb.tar.gz has been removed from the
DL_DIR, but the git2_git.pingu.fi.xf86-video-omapfb.tar.gz.done still exists,
this is because the "open(ud.donestamp, 'w').close()" in try_mirror_url() will
create the git2_git.xxx.tar.gz.done, but no one removes it (the clean() in
fetch2/__init__.py removes the DL_DIR/git2/pkg.done)

This only happens on the git fetcher AFAIK.

[YOCTO #5688]

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
---
 bitbake/lib/bb/fetch2/git.py |    1 +
 1 file changed, 1 insertion(+)

Patch

diff --git a/bitbake/lib/bb/fetch2/git.py b/bitbake/lib/bb/fetch2/git.py
index bd107db..b4b9368 100644
--- a/bitbake/lib/bb/fetch2/git.py
+++ b/bitbake/lib/bb/fetch2/git.py
@@ -283,6 +283,7 @@  class Git(FetchMethod):
 
         bb.utils.remove(ud.localpath, True)
         bb.utils.remove(ud.fullmirror)
+        bb.utils.remove(ud.fullmirror + ".done")
 
     def supports_srcrev(self):
         return True