Patchwork [2/2] packagegroup-core-boot: make initscripts-functions a basic element of RDEPENDS

login
register
mail settings
Submitter Qi.Chen@windriver.com
Date Dec. 25, 2013, 8:36 a.m.
Message ID <d5166a224cee86b6092e82c1e564162a22668710.1387959755.git.Qi.Chen@windriver.com>
Download mbox | patch
Permalink /patch/63739/
State New
Headers show

Comments

Qi.Chen@windriver.com - Dec. 25, 2013, 8:36 a.m.
From: Chen Qi <Qi.Chen@windriver.com>

Unlike the initscripts package which is useful in SysV systems but
not so useful in systemd systems, the initscripts-functions package
is useful for both.

For the reason stated above, this patch adds initscripts-funtions to
the RDEPENDS of packagegroup-core-boot.

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
---
 .../packagegroups/packagegroup-core-boot.bb        |    1 +
 1 file changed, 1 insertion(+)
Saul Wold - Dec. 26, 2013, 5:23 p.m.
On 12/25/2013 12:36 AM, Qi.Chen@windriver.com wrote:
> From: Chen Qi <Qi.Chen@windriver.com>
>
> Unlike the initscripts package which is useful in SysV systems but
> not so useful in systemd systems, the initscripts-functions package
> is useful for both.
>
> For the reason stated above, this patch adds initscripts-funtions to
> the RDEPENDS of packagegroup-core-boot.
>
Why not add the RDEPENDS on the initscript-functions to the appropriate 
recipes, such as distcc or others that require the contents of functions?

I understand the general value of having it installed, but if 
"functions" is only required for some recipes, then let's not add it in 
again if unneeded.

Sau!

> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
> ---
>   .../packagegroups/packagegroup-core-boot.bb        |    1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/meta/recipes-core/packagegroups/packagegroup-core-boot.bb b/meta/recipes-core/packagegroups/packagegroup-core-boot.bb
> index 5455899..2f60c97 100644
> --- a/meta/recipes-core/packagegroups/packagegroup-core-boot.bb
> +++ b/meta/recipes-core/packagegroups/packagegroup-core-boot.bb
> @@ -41,6 +41,7 @@ RDEPENDS_${PN} = "\
>       ${@base_contains("DISTRO_FEATURES", "sysvinit", "${SYSVINIT_SCRIPTS}", "", d)} \
>       ${@base_contains("MACHINE_FEATURES", "keyboard", "${VIRTUAL-RUNTIME_keymaps}", "", d)} \
>       netbase \
> +    initscripts-functions \
>       ${VIRTUAL-RUNTIME_login_manager} \
>       ${VIRTUAL-RUNTIME_init_manager} \
>       ${VIRTUAL-RUNTIME_initscripts} \
>

Patch

diff --git a/meta/recipes-core/packagegroups/packagegroup-core-boot.bb b/meta/recipes-core/packagegroups/packagegroup-core-boot.bb
index 5455899..2f60c97 100644
--- a/meta/recipes-core/packagegroups/packagegroup-core-boot.bb
+++ b/meta/recipes-core/packagegroups/packagegroup-core-boot.bb
@@ -41,6 +41,7 @@  RDEPENDS_${PN} = "\
     ${@base_contains("DISTRO_FEATURES", "sysvinit", "${SYSVINIT_SCRIPTS}", "", d)} \
     ${@base_contains("MACHINE_FEATURES", "keyboard", "${VIRTUAL-RUNTIME_keymaps}", "", d)} \
     netbase \
+    initscripts-functions \
     ${VIRTUAL-RUNTIME_login_manager} \
     ${VIRTUAL-RUNTIME_init_manager} \
     ${VIRTUAL-RUNTIME_initscripts} \