Patchwork bitbake.conf: Exclude WORKDIR changes from sstate checksums

login
register
mail settings
Submitter Richard Purdie
Date Dec. 20, 2013, 12:06 p.m.
Message ID <1387541201.6402.92.camel@ted>
Download mbox | patch
Permalink /patch/63625/
State Accepted
Commit 9a1705e9a51a19499a40aea8bbca43a1d759bca1
Headers show

Comments

Richard Purdie - Dec. 20, 2013, 12:06 p.m.
The layout of stamp files ensures that changes to WORKDIR mean recipes get rebuilt correctly.
Since WORKDIR usually contains MULTIMACH_TARGET_SYS and that depends on tune variables,
including WORKDIR in sstate checksums adds a lot of noise to the system for what amounts to
no gain.

On the other hand, removing it reduces noise, reduces the size of the siginfo files and
reduces the amount of processing bitbake has to do. It therefore seems like dropping it
from the checksums is an all around win.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---

Patch

diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
index 386c935..6675bff 100644
--- a/meta/conf/bitbake.conf
+++ b/meta/conf/bitbake.conf
@@ -767,7 +767,7 @@  BB_HASHBASE_WHITELIST ?= "TMPDIR FILE PATH PWD BB_TASKHASH BBPATH DL_DIR \
     USER FILESPATH STAGING_DIR_HOST STAGING_DIR_TARGET COREBASE PRSERV_HOST \
     PRSERV_DUMPDIR PRSERV_DUMPFILE PRSERV_LOCKDOWN PARALLEL_MAKE \
     CCACHE_DIR EXTERNAL_TOOLCHAIN CCACHE CCACHE_DISABLE LICENSE_PATH SDKPKGSUFFIX \
-    WARN_QA ERROR_QA"
+    WARN_QA ERROR_QA WORKDIR"
 BB_HASHCONFIG_WHITELIST ?= "${BB_HASHBASE_WHITELIST} DATE TIME SSH_AGENT_PID \
     SSH_AUTH_SOCK PSEUDO_BUILD BB_ENV_EXTRAWHITE DISABLE_SANITY_CHECKS \
     PARALLEL_MAKE BB_NUMBER_THREADS BB_ORIGENV"