Patchwork weston: for fbdev enabled distro feature, change WESTON_NATIVE_BACKEND

login
register
mail settings
Submitter Valentin Popa
Date Dec. 19, 2013, 2:20 p.m.
Message ID <1387462812-23194-1-git-send-email-valentin.popa@intel.com>
Download mbox | patch
Permalink /patch/63593/
State New
Headers show

Comments

Valentin Popa - Dec. 19, 2013, 2:20 p.m.
For builds with fbdev (no drm/kms), set
WESTON_NATIVE_BACKEND to "fbdev-backend.so"; doing this,
weston-launch will be able to know what backend to use.

Signed-off-by: Valentin Popa <valentin.popa@intel.com>
---
 meta/recipes-graphics/wayland/weston_1.3.1.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Saul Wold - Dec. 20, 2013, 12:36 a.m.
On 12/19/2013 06:20 AM, Valentin Popa wrote:
> For builds with fbdev (no drm/kms), set
> WESTON_NATIVE_BACKEND to "fbdev-backend.so"; doing this,
> weston-launch will be able to know what backend to use.
>
> Signed-off-by: Valentin Popa <valentin.popa@intel.com>
> ---
>   meta/recipes-graphics/wayland/weston_1.3.1.bb | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-graphics/wayland/weston_1.3.1.bb b/meta/recipes-graphics/wayland/weston_1.3.1.bb
> index d97f6af..4ab2776 100644
> --- a/meta/recipes-graphics/wayland/weston_1.3.1.bb
> +++ b/meta/recipes-graphics/wayland/weston_1.3.1.bb
> @@ -45,7 +45,7 @@ PACKAGECONFIG[x11] = "--enable-x11-compositor,--disable-x11-compositor,virtual/l
>   # Headless Weston
>   PACKAGECONFIG[headless] = "--enable-headless-compositor,--disable-headless-compositor"
>   # Weston on framebuffer
> -PACKAGECONFIG[fbdev] = "--enable-fbdev-compositor,--disable-fbdev-compositor,udev mtdev"
> +PACKAGECONFIG[fbdev] = "--enable-fbdev-compositor WESTON_NATIVE_BACKEND="fbdev-backend.so",--disable-fbdev-compositor,udev mtdev"

Is this a more general way to do this as suggested by Koen back in May?

+# Needed for weston-launch
+WESTONBACKEND ??= "fbdev-backend.so"
+
+export WESTON_NATIVE_BACKEND = "${WESTONBACKEND}"

See http://patches.openembedded.org/patch/50871/

Sau!


>   # weston-launch
>   PACKAGECONFIG[launch] = "--enable-weston-launch,--disable-weston-launch,libpam"
>   # VA-API desktop recorder
>
Valentin Popa - Dec. 20, 2013, 10:25 a.m.
On 12/20/2013 02:36 AM, Saul Wold wrote:
> On 12/19/2013 06:20 AM, Valentin Popa wrote:
>> For builds with fbdev (no drm/kms), set
>> WESTON_NATIVE_BACKEND to "fbdev-backend.so"; doing this,
>> weston-launch will be able to know what backend to use.
>>
>> Signed-off-by: Valentin Popa <valentin.popa@intel.com>
>> ---
>>   meta/recipes-graphics/wayland/weston_1.3.1.bb | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-graphics/wayland/weston_1.3.1.bb 
>> b/meta/recipes-graphics/wayland/weston_1.3.1.bb
>> index d97f6af..4ab2776 100644
>> --- a/meta/recipes-graphics/wayland/weston_1.3.1.bb
>> +++ b/meta/recipes-graphics/wayland/weston_1.3.1.bb
>> @@ -45,7 +45,7 @@ PACKAGECONFIG[x11] = 
>> "--enable-x11-compositor,--disable-x11-compositor,virtual/l
>>   # Headless Weston
>>   PACKAGECONFIG[headless] = 
>> "--enable-headless-compositor,--disable-headless-compositor"
>>   # Weston on framebuffer
>> -PACKAGECONFIG[fbdev] = 
>> "--enable-fbdev-compositor,--disable-fbdev-compositor,udev mtdev"
>> +PACKAGECONFIG[fbdev] = "--enable-fbdev-compositor 
>> WESTON_NATIVE_BACKEND="fbdev-backend.so",--disable-fbdev-compositor,udev 
>> mtdev"
>
> Is this a more general way to do this as suggested by Koen back in May?
>
> +# Needed for weston-launch
> +WESTONBACKEND ??= "fbdev-backend.so"
> +
> +export WESTON_NATIVE_BACKEND = "${WESTONBACKEND}"
>
> See http://patches.openembedded.org/patch/50871/
>
> Sau!
Not sure of the context of that patch, but with this patch we have fbdev 
backend -only- if the user builds with fbdev distro feature.
I've tried to build with both kms and fbdev and failed at compile time 
(bug or feature).
>
>
>>   # weston-launch
>>   PACKAGECONFIG[launch] = 
>> "--enable-weston-launch,--disable-weston-launch,libpam"
>>   # VA-API desktop recorder
>>
Ross Burton - Dec. 20, 2013, 11:50 a.m.
On 20 December 2013 10:25, Valentin Popa <valentin.popa@intel.com> wrote:
> I've tried to build with both kms and fbdev and failed at compile time (bug
> or feature).

I'd expect bug as you can build with x11 and drm backends enabled.
Please file a bug for this (and CC me using ross@burtonini.com).

Ross

Patch

diff --git a/meta/recipes-graphics/wayland/weston_1.3.1.bb b/meta/recipes-graphics/wayland/weston_1.3.1.bb
index d97f6af..4ab2776 100644
--- a/meta/recipes-graphics/wayland/weston_1.3.1.bb
+++ b/meta/recipes-graphics/wayland/weston_1.3.1.bb
@@ -45,7 +45,7 @@  PACKAGECONFIG[x11] = "--enable-x11-compositor,--disable-x11-compositor,virtual/l
 # Headless Weston
 PACKAGECONFIG[headless] = "--enable-headless-compositor,--disable-headless-compositor"
 # Weston on framebuffer
-PACKAGECONFIG[fbdev] = "--enable-fbdev-compositor,--disable-fbdev-compositor,udev mtdev"
+PACKAGECONFIG[fbdev] = "--enable-fbdev-compositor WESTON_NATIVE_BACKEND="fbdev-backend.so",--disable-fbdev-compositor,udev mtdev"
 # weston-launch
 PACKAGECONFIG[launch] = "--enable-weston-launch,--disable-weston-launch,libpam"
 # VA-API desktop recorder