Patchwork sstatesig: Correctly handle matches spanning stamps and sstatedir

login
register
mail settings
Submitter Richard Purdie
Date Dec. 19, 2013, 9:40 a.m.
Message ID <1387446010.6402.65.camel@ted>
Download mbox | patch
Permalink /patch/63581/
State New
Headers show

Comments

Richard Purdie - Dec. 19, 2013, 9:40 a.m.
By resetting filesdates at this point, we lose matches from stamps which
may not have been in sstatedir. When we don't have hashes specicifed,
its better to return all matches and have the caller decide which are
relavent and which are not since this function has no ability to
decide. There will almost always be one match from stamps we need
to keep and refer to.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---

Patch

diff --git a/meta/lib/oe/sstatesig.py b/meta/lib/oe/sstatesig.py
index 835cee8..5354c75 100644
--- a/meta/lib/oe/sstatesig.py
+++ b/meta/lib/oe/sstatesig.py
@@ -154,7 +154,6 @@  def find_siginfo(pn, taskname, taskhashlist, d, hashfn = None):
             else:
                 sstatedir = d.getVar('SSTATE_DIR', True)
 
-            filedates = {}
             for root, dirs, files in os.walk(sstatedir):
                 for fn in files:
                     fullpath = os.path.join(root, fn)