Patchwork openssl_1.0.1e: Install c_rehash utility with openssl

login
register
mail settings
Submitter Yasir Khan
Date Dec. 13, 2013, 6:08 p.m.
Message ID <1386958134-20626-1-git-send-email-yasir_khan@mentor.com>
Download mbox | patch
Permalink /patch/63349/
State New
Headers show

Comments

Yasir Khan - Dec. 13, 2013, 6:08 p.m.
From: mykhani <yasir_khan@mentor.com>

c_rehash utility is not being installed with openssl. It conveniently
generates hash and symbolic links based on it for CA certificates
stored locally for SSL based server authentication

Signed-off-by: mykhani <yasir_khan@mentor.com>
---
 meta/recipes-connectivity/openssl/openssl_1.0.1e.bb |   10 ++++++++++
 1 file changed, 10 insertions(+)
Saul Wold - Dec. 13, 2013, 6:43 p.m.
On 12/13/2013 10:08 AM, Yasir Khan wrote:
> From: mykhani <yasir_khan@mentor.com>
>
> c_rehash utility is not being installed with openssl. It conveniently
> generates hash and symbolic links based on it for CA certificates
> stored locally for SSL based server authentication
>
> Signed-off-by: mykhani <yasir_khan@mentor.com>
> ---
>   meta/recipes-connectivity/openssl/openssl_1.0.1e.bb |   10 ++++++++++
>   1 file changed, 10 insertions(+)
>
> diff --git a/meta/recipes-connectivity/openssl/openssl_1.0.1e.bb b/meta/recipes-connectivity/openssl/openssl_1.0.1e.bb
> index ac27dba..f52877c 100644
> --- a/meta/recipes-connectivity/openssl/openssl_1.0.1e.bb
> +++ b/meta/recipes-connectivity/openssl/openssl_1.0.1e.bb
> @@ -4,6 +4,9 @@ require openssl.inc
>   # if they are available.
>   DEPENDS += "ocf-linux"
>
> +# Perl is needed for the c_rehash script
> +RDEPENDS_${PN} += "perl"
> +
>   CFLAG += "-DHAVE_CRYPTODEV -DUSE_CRYPTODEV_DIGESTS"
>
>   PR = "${INC_PR}.0"
> @@ -53,3 +56,10 @@ PARALLEL_MAKEINST = ""
>   do_configure_prepend() {
>     cp ${WORKDIR}/find.pl ${S}/util/find.pl
>   }
> +
> +do_install_append() {
> +    # The c_rehash utility isn't being installed by the normal installation process.
> +    # It conveniently generates both hash and symbolic links based on hash for CA certificates.
> +    install -m 0755 ${S}/tools/c_rehash ${D}${bindir}
> +}
> +
Let's package this in a separate package such as ${PN}-misc, and then 
the perl dependency can be for that package only, I see that -misc 
already has some perl scripts but no RDEPENDS (it really should).

I am not sure that this tool and perl will be wanted on on embedded 
machines using openssl.

Also, I think this can go in the openssl.inc file instead of the .bb

Sau!

Sau!

>

Patch

diff --git a/meta/recipes-connectivity/openssl/openssl_1.0.1e.bb b/meta/recipes-connectivity/openssl/openssl_1.0.1e.bb
index ac27dba..f52877c 100644
--- a/meta/recipes-connectivity/openssl/openssl_1.0.1e.bb
+++ b/meta/recipes-connectivity/openssl/openssl_1.0.1e.bb
@@ -4,6 +4,9 @@  require openssl.inc
 # if they are available.
 DEPENDS += "ocf-linux"
 
+# Perl is needed for the c_rehash script
+RDEPENDS_${PN} += "perl"
+
 CFLAG += "-DHAVE_CRYPTODEV -DUSE_CRYPTODEV_DIGESTS"
 
 PR = "${INC_PR}.0"
@@ -53,3 +56,10 @@  PARALLEL_MAKEINST = ""
 do_configure_prepend() {
   cp ${WORKDIR}/find.pl ${S}/util/find.pl
 }
+
+do_install_append() {
+    # The c_rehash utility isn't being installed by the normal installation process. 
+    # It conveniently generates both hash and symbolic links based on hash for CA certificates.
+    install -m 0755 ${S}/tools/c_rehash ${D}${bindir}
+}
+