Patchwork bash-completion: add recipe

login
register
mail settings
Submitter Matthieu CRAPET
Date Dec. 13, 2013, 3:01 p.m.
Message ID <1386946865-18483-1-git-send-email-Matthieu.Crapet@ingenico.com>
Download mbox | patch
Permalink /patch/63345/
State New
Headers show

Comments

Matthieu CRAPET - Dec. 13, 2013, 3:01 p.m.
---
 .../bash-completion/bash-completion_2.0.bb         | 31 ++++++++++++++++++++++
 1 file changed, 31 insertions(+)
 create mode 100644 meta/recipes-support/bash-completion/bash-completion_2.0.bb
Saul Wold - Dec. 13, 2013, 4:27 p.m.
Needs more comment as to why we need this along with a Signed-off-by: 
tag.  Can you include where you brought this in from.



On 12/13/2013 07:01 AM, Matthieu Crapet wrote:
> ---
>   .../bash-completion/bash-completion_2.0.bb         | 31 ++++++++++++++++++++++
>   1 file changed, 31 insertions(+)
>   create mode 100644 meta/recipes-support/bash-completion/bash-completion_2.0.bb
>
> diff --git a/meta/recipes-support/bash-completion/bash-completion_2.0.bb b/meta/recipes-support/bash-completion/bash-completion_2.0.bb
> new file mode 100644
> index 0000000..f08988a
> --- /dev/null
> +++ b/meta/recipes-support/bash-completion/bash-completion_2.0.bb
> @@ -0,0 +1,31 @@
> +DESCRIPTION = "Programmable Completion for Bash 4"
> +HOMEPAGE = "http://bash-completion.alioth.debian.org/"
> +BUGTRACKER = "https://alioth.debian.org/projects/bash-completion/"
> +
> +SECTION = "console/utils"
> +RDEPENDS_${PN} = "bash"
> +PR = "r1"
> +
Did you bump PR here or is it coming over with a PR already = "r1"  If 
this is truly a new recipe, then we can drop the PR, but we might need a 
PE since the classic recipe had a PV of 20040711 which is greater than 
this new PV of 2.0.

> +SRC_URI="http://bash-completion.alioth.debian.org/files/${BPN}-${PV}.tar.bz2"
> +
> +SRC_URI[md5sum] = "0d903f398be8c8f24bc5ffa6f86127f8"
> +SRC_URI[sha256sum] = "e5a490a4301dfb228361bdca2ffca597958e47dd6056005ef9393a5852af5804"
> +
> +LICENSE = "GPLv2"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe"
> +
These belong above after Section

> +inherit allarch autotools
> +
> +do_configure() {
> +	oe_runconf
> +}
> +
> +do_install_append() {
> +	install -d ${D}${sysconfdir}/bash_completion.d/
> +	echo '. ${datadir}/${BPN}/bash_completion' >${D}${sysconfdir}/bash_completion
> +}
> +
> +# Some recipes are providing ${PN}-bash-completion packages
> +PACKAGES_prepend += "${PN}-extra "
> +FILES_${PN}-extra = "${datadir}/${BPN}/completions/ \
> +    ${datadir}/${BPN}/helpers/"
>
Paul Eggleton - Dec. 13, 2013, 4:36 p.m.
On Friday 13 December 2013 08:27:41 Saul Wold wrote:
> Needs more comment as to why we need this along with a Signed-off-by:
> tag.  Can you include where you brought this in from.

I think this probably belongs in meta-oe rather than OE-Core, unless a good 
case for everyone needing it can be made.

Cheers,
Paul
Matthieu CRAPET - Dec. 16, 2013, 8:48 a.m.
Hi,

Thanks for comments.
I have posted a v2 patch on oe-devel list.

Changes:
- Drop PR. As this is a new recipe, this should be PR = "r0", and r0 is the default.
- Add PE = "1" to not conflict with old recipe (OE-Classic) PV = "20040711"
- Moved LIC* entry before SECTION

Question:
- Kept DESCRIPTION, should it be renamed to SUMMARY?

Cheers,
M


-----Message d'origine-----
De : Paul Eggleton [mailto:paul.eggleton@linux.intel.com] 
Envoyé : vendredi 13 décembre 2013 17:36
À : Matthieu CRAPET; Saul Wold
Cc : openembedded-core@lists.openembedded.org
Objet : Re: [OE-core] [PATCH] bash-completion: add recipe

On Friday 13 December 2013 08:27:41 Saul Wold wrote:
> Needs more comment as to why we need this along with a Signed-off-by:
> tag.  Can you include where you brought this in from.

I think this probably belongs in meta-oe rather than OE-Core, unless a good case for everyone needing it can be made.

Cheers,
Paul

Patch

diff --git a/meta/recipes-support/bash-completion/bash-completion_2.0.bb b/meta/recipes-support/bash-completion/bash-completion_2.0.bb
new file mode 100644
index 0000000..f08988a
--- /dev/null
+++ b/meta/recipes-support/bash-completion/bash-completion_2.0.bb
@@ -0,0 +1,31 @@ 
+DESCRIPTION = "Programmable Completion for Bash 4"
+HOMEPAGE = "http://bash-completion.alioth.debian.org/"
+BUGTRACKER = "https://alioth.debian.org/projects/bash-completion/"
+
+SECTION = "console/utils"
+RDEPENDS_${PN} = "bash"
+PR = "r1"
+
+SRC_URI="http://bash-completion.alioth.debian.org/files/${BPN}-${PV}.tar.bz2"
+
+SRC_URI[md5sum] = "0d903f398be8c8f24bc5ffa6f86127f8"
+SRC_URI[sha256sum] = "e5a490a4301dfb228361bdca2ffca597958e47dd6056005ef9393a5852af5804"
+
+LICENSE = "GPLv2"
+LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe"
+
+inherit allarch autotools
+
+do_configure() {
+	oe_runconf
+}
+
+do_install_append() {
+	install -d ${D}${sysconfdir}/bash_completion.d/
+	echo '. ${datadir}/${BPN}/bash_completion' >${D}${sysconfdir}/bash_completion
+}
+
+# Some recipes are providing ${PN}-bash-completion packages
+PACKAGES_prepend += "${PN}-extra "
+FILES_${PN}-extra = "${datadir}/${BPN}/completions/ \
+    ${datadir}/${BPN}/helpers/"