Patchwork [meta-fsl-ppc] qemu: add gtk options in configure

login
register
mail settings
Submitter chunrong guo
Date Dec. 12, 2013, 3:59 a.m.
Message ID <1386820799-24420-1-git-send-email-b40290@freescale.com>
Download mbox | patch
Permalink /patch/63249/
State Accepted
Headers show

Comments

chunrong guo - Dec. 12, 2013, 3:59 a.m.
From: Chunrong Guo <B40290@freescale.com>

    * fix the following error:
    |ERROR: unknown option --disable-gtk

Signed-off-by: Chunrong Guo <B40290@freescale.com>
---
 recipes-devtools/qemu/files/add-gtk-options.patch |   13 +++++++++++++
 recipes-devtools/qemu/qemu_fslgit.bb              |    1 +
 2 files changed, 14 insertions(+), 0 deletions(-)
 create mode 100644 recipes-devtools/qemu/files/add-gtk-options.patch
Otavio Salvador - Dec. 12, 2013, 12:56 p.m.
On Thu, Dec 12, 2013 at 1:59 AM,  <b40290@freescale.com> wrote:
> From: Chunrong Guo <B40290@freescale.com>
>
>     * fix the following error:
>     |ERROR: unknown option --disable-gtk
>
> Signed-off-by: Chunrong Guo <B40290@freescale.com>

This should be done in the configure.ac or it will be lost when
regenerating the configure, no?
chunrong guo - Dec. 13, 2013, 7:26 a.m.
Hello,
 
configure script is not produced with autoconf  and  is provided by qemu source.

Thanks,
chunrong




-----Original Message-----
From: otavio.salvador@gmail.com [mailto:otavio.salvador@gmail.com] On Behalf Of Otavio Salvador
Sent: Thursday, December 12, 2013 8:56 PM
To: Guo Chunrong-B40290
Cc: meta-freescale@yoctoproject.org
Subject: Re: [meta-freescale] [meta-fsl-ppc][PATCH] qemu: add gtk options in configure

On Thu, Dec 12, 2013 at 1:59 AM,  <b40290@freescale.com> wrote:
> From: Chunrong Guo <B40290@freescale.com>
>
>     * fix the following error:
>     |ERROR: unknown option --disable-gtk
>
> Signed-off-by: Chunrong Guo <B40290@freescale.com>

This should be done in the configure.ac or it will be lost when regenerating the configure, no?
Otavio Salvador - Dec. 13, 2013, 10:39 a.m.
On Fri, Dec 13, 2013 at 5:26 AM, B40290@freescale.com
<B40290@freescale.com> wrote:
> configure script is not produced with autoconf  and  is provided by qemu source.

In this case this seems right.
Zhenhua Luo - Dec. 14, 2013, 5:35 a.m.
Applied, thanks. 


Best Regards,

Zhenhua


> -----Original Message-----
> From: meta-freescale-bounces@yoctoproject.org [mailto:meta-freescale-
> bounces@yoctoproject.org] On Behalf Of Otavio Salvador
> Sent: Friday, December 13, 2013 6:39 PM
> To: Guo Chunrong-B40290
> Cc: meta-freescale@yoctoproject.org
> Subject: Re: [meta-freescale] [meta-fsl-ppc][PATCH] qemu: add gtk options
> in configure
> 
> On Fri, Dec 13, 2013 at 5:26 AM, B40290@freescale.com
> <B40290@freescale.com> wrote:
> > configure script is not produced with autoconf  and  is provided by
> qemu source.
> 
> In this case this seems right.
> 
> --
> Otavio Salvador                             O.S. Systems
> http://www.ossystems.com.br        http://code.ossystems.com.br
> Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
> _______________________________________________
> meta-freescale mailing list
> meta-freescale@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-freescale
>

Patch

diff --git a/recipes-devtools/qemu/files/add-gtk-options.patch b/recipes-devtools/qemu/files/add-gtk-options.patch
new file mode 100644
index 0000000..d8522de
--- /dev/null
+++ b/recipes-devtools/qemu/files/add-gtk-options.patch
@@ -0,0 +1,13 @@ 
+--- a/configure.old	2013-12-11 21:24:44.422276752 -0600
++++ b/configure	2013-12-11 21:27:26.954335983 -0600
+@@ -897,6 +897,10 @@
+   ;;
+   --enable-virtio-blk-data-plane) virtio_blk_data_plane="yes"
+   ;;
++  --disable-gtk) gtk="no"
++  ;;
++  --enable-gtk) gtk="yes"
++  ;;
+   *) echo "ERROR: unknown option $opt"; show_help="yes"
+   ;;
+   esac
diff --git a/recipes-devtools/qemu/qemu_fslgit.bb b/recipes-devtools/qemu/qemu_fslgit.bb
index 356103d..98c67ca 100644
--- a/recipes-devtools/qemu/qemu_fslgit.bb
+++ b/recipes-devtools/qemu/qemu_fslgit.bb
@@ -14,6 +14,7 @@  SRC_URI += " \
    file://0001-doc-Fix-texinfo-table-markup-in-qemu-options.hx.patch \
    file://0002-docs-Fix-generating-qemu-doc.html-with-texinfo-5.patch \
    file://fdt_header.patch \
+   file://add-gtk-options.patch \
 "
 
 S = "${WORKDIR}/git"