Patchwork [bitbake-devel,3/5,dora] bitbake: fetch2: Fix handling of SCM mirrors in MIRRORS

mail settings
Submitter Robert Yang
Date Dec. 10, 2013, 3:09 p.m.
Message ID <>
Download mbox | patch
Permalink /patch/63145/
State New
Headers show


Robert Yang - Dec. 10, 2013, 3:09 p.m.
From: Richard Purdie <>

If an SCM mirror is in PREMIRRORS, the tarball is downloaded and then found
by the "upstream" check and handled correctly.

If an SCM mirror is in MIRRORS, the tarball is downloaded but not used
since there is no "upstream" run after MIRRORS completes. It therefore
sits there useless and unused. This code change forces the upstream to
run after a mirror tarball is found and fixes the usage of SCM mirrors

(Bitbake master rev: a66ee0994645aa5658b2f5ea134ed17d89f8751a)

Signed-off-by: Richard Purdie <>
Signed-off-by: Robert Yang <>
 bitbake/lib/bb/fetch2/ |    4 ++++
 1 file changed, 4 insertions(+)


diff --git a/bitbake/lib/bb/fetch2/ b/bitbake/lib/bb/fetch2/
index 451d104..b9f673c 100644
--- a/bitbake/lib/bb/fetch2/
+++ b/bitbake/lib/bb/fetch2/
@@ -805,6 +805,10 @@  def try_mirror_url(newuri, origud, ud, ld, check = False):
             dest = os.path.join(dldir, os.path.basename(ud.localpath))
             if not os.path.exists(dest):
                 os.symlink(ud.localpath, dest)
+            if not os.path.exists(origud.donestamp) or origud.method.need_update(origud.url, origud, ld):
+      , origud, ld)
+                if hasattr(ud.method,"build_mirror_data"):
+                    origud.method.build_mirror_data(origud.url, origud, ld)
             return None
         # Otherwise the result is a local file:// and we symlink to it
         if not os.path.exists(origud.localpath):