Patchwork [meta-fsl-arm-extra,v3,2/2] wandboard.inc: add touchscreen support

login
register
mail settings
Submitter Mario Domenech Goulart
Date Dec. 9, 2013, 5:26 p.m.
Message ID <1386609976-24625-2-git-send-email-mario@ossystems.com.br>
Download mbox | patch
Permalink /patch/63061/
State Accepted
Delegated to: Otavio Salvador
Headers show

Comments

Mario Domenech Goulart - Dec. 9, 2013, 5:26 p.m.
Signed-off-by: Mario Domenech Goulart <mario@ossystems.com.br>
---
 conf/machine/include/wandboard.inc |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
John Weber - Dec. 9, 2013, 6:39 p.m.
Hi Mario,

On 12/9/13 11:26 AM, Mario Domenech Goulart wrote:
> Signed-off-by: Mario Domenech Goulart <mario@ossystems.com.br>
> ---
>   conf/machine/include/wandboard.inc |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/conf/machine/include/wandboard.inc b/conf/machine/include/wandboard.inc
> index dc64d89..5e83ad5 100644
> --- a/conf/machine/include/wandboard.inc
> +++ b/conf/machine/include/wandboard.inc
> @@ -7,4 +7,4 @@ PREFERRED_PROVIDER_virtual/kernel ?= "linux-wandboard"
>   
>   SERIAL_CONSOLE = "115200 ttymxc0"
>   
> -MACHINE_FEATURES += "pci"
> +MACHINE_FEATURES += "pci touchscreen"
What does the touchscreen feature add?  In the case of headless systems, how 
would a developer override this setting if they want to create an image without 
touch support?  Would something like MACHINE_FEATURES_remove = "touchscreen" work?
Otavio Salvador - Dec. 9, 2013, 7 p.m.
Hello John,

On Mon, Dec 9, 2013 at 4:39 PM, John Weber <rjohnweber@gmail.com> wrote:
> On 12/9/13 11:26 AM, Mario Domenech Goulart wrote:
>> Signed-off-by: Mario Domenech Goulart <mario@ossystems.com.br>
>> diff --git a/conf/machine/include/wandboard.inc
>> b/conf/machine/include/wandboard.inc
>> index dc64d89..5e83ad5 100644
>> --- a/conf/machine/include/wandboard.inc
>> +++ b/conf/machine/include/wandboard.inc
>> @@ -7,4 +7,4 @@ PREFERRED_PROVIDER_virtual/kernel ?= "linux-wandboard"
>>     SERIAL_CONSOLE = "115200 ttymxc0"
>>   -MACHINE_FEATURES += "pci"
>> +MACHINE_FEATURES += "pci touchscreen"
>
> What does the touchscreen feature add?  In the case of headless systems, how
> would a developer override this setting if they want to create an image
> without touch support?  Would something like MACHINE_FEATURES_remove =
> "touchscreen" work?

It allows calibration for the images which supports it. This so
depends on the image it is uses.

The _remove is supported by bitbake so it does work.
John Weber - Dec. 9, 2013, 8:01 p.m.
On 12/9/13 1:00 PM, Otavio Salvador wrote:
> Hello John,
>
> On Mon, Dec 9, 2013 at 4:39 PM, John Weber <rjohnweber@gmail.com> wrote:
>> On 12/9/13 11:26 AM, Mario Domenech Goulart wrote:
>>> Signed-off-by: Mario Domenech Goulart <mario@ossystems.com.br>
>>> diff --git a/conf/machine/include/wandboard.inc
>>> b/conf/machine/include/wandboard.inc
>>> index dc64d89..5e83ad5 100644
>>> --- a/conf/machine/include/wandboard.inc
>>> +++ b/conf/machine/include/wandboard.inc
>>> @@ -7,4 +7,4 @@ PREFERRED_PROVIDER_virtual/kernel ?= "linux-wandboard"
>>>      SERIAL_CONSOLE = "115200 ttymxc0"
>>>    -MACHINE_FEATURES += "pci"
>>> +MACHINE_FEATURES += "pci touchscreen"
>> What does the touchscreen feature add?  In the case of headless systems, how
>> would a developer override this setting if they want to create an image
>> without touch support?  Would something like MACHINE_FEATURES_remove =
>> "touchscreen" work?
> It allows calibration for the images which supports it. This so
> depends on the image it is uses.
>
> The _remove is supported by bitbake so it does work.
>
OK.  No problem.  Thanks.
Eric BENARD - Dec. 11, 2013, 10:31 a.m.
Hi Mario,

Le Mon,  9 Dec 2013 15:26:16 -0200,
Mario Domenech Goulart <mario@ossystems.com.br> a écrit :

> Signed-off-by: Mario Domenech Goulart <mario@ossystems.com.br>
> ---
>  conf/machine/include/wandboard.inc |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/conf/machine/include/wandboard.inc b/conf/machine/include/wandboard.inc
> index dc64d89..5e83ad5 100644
> --- a/conf/machine/include/wandboard.inc
> +++ b/conf/machine/include/wandboard.inc
> @@ -7,4 +7,4 @@ PREFERRED_PROVIDER_virtual/kernel ?= "linux-wandboard"
>  
>  SERIAL_CONSOLE = "115200 ttymxc0"
>  
> -MACHINE_FEATURES += "pci"
> +MACHINE_FEATURES += "pci touchscreen"

where is the touchscreen interface on the wandboard ?

Eric
Otavio Salvador - Dec. 11, 2013, 10:44 a.m.
Hello Eric,

On Wed, Dec 11, 2013 at 8:31 AM, Eric Bénard <eric@eukrea.com> wrote:
> Le Mon,  9 Dec 2013 15:26:16 -0200,
> Mario Domenech Goulart <mario@ossystems.com.br> a écrit :
>
>> Signed-off-by: Mario Domenech Goulart <mario@ossystems.com.br>
>> ---
>>  conf/machine/include/wandboard.inc |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/conf/machine/include/wandboard.inc b/conf/machine/include/wandboard.inc
>> index dc64d89..5e83ad5 100644
>> --- a/conf/machine/include/wandboard.inc
>> +++ b/conf/machine/include/wandboard.inc
>> @@ -7,4 +7,4 @@ PREFERRED_PROVIDER_virtual/kernel ?= "linux-wandboard"
>>
>>  SERIAL_CONSOLE = "115200 ttymxc0"
>>
>> -MACHINE_FEATURES += "pci"
>> +MACHINE_FEATURES += "pci touchscreen"
>
> where is the touchscreen interface on the wandboard ?

This allow used with the adapters which provide support for it.

For reference, Future Eletronics provide one:

http://www.futureelectronics.com/en/technologies/development-tools/development-tool-hardware/Pages/9032471-FWBADAPT-7WVGA-PCAP.aspx?IM=0

This is the one we used for testing.
Eric BENARD - Dec. 11, 2013, 11 a.m.
Le Wed, 11 Dec 2013 08:44:35 -0200,
Otavio Salvador <otavio@ossystems.com.br> a écrit :

> Hello Eric,
> 
> On Wed, Dec 11, 2013 at 8:31 AM, Eric Bénard <eric@eukrea.com> wrote:
> > Le Mon,  9 Dec 2013 15:26:16 -0200,
> > Mario Domenech Goulart <mario@ossystems.com.br> a écrit :
> >
> >> Signed-off-by: Mario Domenech Goulart <mario@ossystems.com.br>
> >> ---
> >>  conf/machine/include/wandboard.inc |    2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/conf/machine/include/wandboard.inc b/conf/machine/include/wandboard.inc
> >> index dc64d89..5e83ad5 100644
> >> --- a/conf/machine/include/wandboard.inc
> >> +++ b/conf/machine/include/wandboard.inc
> >> @@ -7,4 +7,4 @@ PREFERRED_PROVIDER_virtual/kernel ?= "linux-wandboard"
> >>
> >>  SERIAL_CONSOLE = "115200 ttymxc0"
> >>
> >> -MACHINE_FEATURES += "pci"
> >> +MACHINE_FEATURES += "pci touchscreen"
> >
> > where is the touchscreen interface on the wandboard ?
> 
> This allow used with the adapters which provide support for it.
> 
> For reference, Future Eletronics provide one:
> 
> http://www.futureelectronics.com/en/technologies/development-tools/development-tool-hardware/Pages/9032471-FWBADAPT-7WVGA-PCAP.aspx?IM=0
> 
> This is the one we used for testing.
> 
OK not really a wandboard.inc MACHINE_FEATURE then ;-)

Eric

Patch

diff --git a/conf/machine/include/wandboard.inc b/conf/machine/include/wandboard.inc
index dc64d89..5e83ad5 100644
--- a/conf/machine/include/wandboard.inc
+++ b/conf/machine/include/wandboard.inc
@@ -7,4 +7,4 @@  PREFERRED_PROVIDER_virtual/kernel ?= "linux-wandboard"
 
 SERIAL_CONSOLE = "115200 ttymxc0"
 
-MACHINE_FEATURES += "pci"
+MACHINE_FEATURES += "pci touchscreen"