Patchwork [1/1] image.bbclass: default USE_DEVFS to '1'

login
register
mail settings
Submitter Qi.Chen@windriver.com
Date Dec. 9, 2013, 3:17 a.m.
Message ID <c20f79f4a812a4e007413751e3cabf63a4f5e6ec.1386558973.git.Qi.Chen@windriver.com>
Download mbox | patch
Permalink /patch/63033/
State New
Headers show

Comments

Qi.Chen@windriver.com - Dec. 9, 2013, 3:17 a.m.
From: Chen Qi <Qi.Chen@windriver.com>

Default USE_DEVFS to "1" so that the `makedevs' command is not run
at rootfs time by default. There are mainly two reasons to do so.
1. This will fix a build failure with initramfs-kexecboot-klibc-image.
2. Most of our images use a filesystem over /dev. Most of the time, it's
   just devtmpfs. So we actually are using a filesystem over /dev.

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
---
 meta/classes/image.bbclass |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Otavio Salvador - Dec. 9, 2013, 11:52 a.m.
Hello,

I agree with the commit but ...

On Mon, Dec 9, 2013 at 1:17 AM,  <Qi.Chen@windriver.com> wrote:
> From: Chen Qi <Qi.Chen@windriver.com>
>
> Default USE_DEVFS to "1" so that the `makedevs' command is not run
> at rootfs time by default. There are mainly two reasons to do so.
> 1. This will fix a build failure with initramfs-kexecboot-klibc-image.

Can you elaborate this error? is it something we can/should fix?

> 2. Most of our images use a filesystem over /dev. Most of the time, it's
>    just devtmpfs. So we actually are using a filesystem over /dev.
>
> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
> ---
>  meta/classes/image.bbclass |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
> index cc65e35..b8bd462 100644
> --- a/meta/classes/image.bbclass
> +++ b/meta/classes/image.bbclass
> @@ -77,7 +77,7 @@ PACKAGE_INSTALL_ATTEMPTONLY ?= "${FEATURE_INSTALL_OPTIONAL}"
>  # Images are generally built explicitly, do not need to be part of world.
>  EXCLUDE_FROM_WORLD = "1"
>
> -USE_DEVFS ?= "0"
> +USE_DEVFS ?= "1"
>
>  PID = "${@os.getpid()}"
>
> --
> 1.7.9.5
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
Andrea Adami - Dec. 9, 2013, 1:52 p.m.
On Mon, Dec 9, 2013 at 12:52 PM, Otavio Salvador
<otavio@ossystems.com.br> wrote:
> Hello,
>
> I agree with the commit but ...
>
> On Mon, Dec 9, 2013 at 1:17 AM,  <Qi.Chen@windriver.com> wrote:
>> From: Chen Qi <Qi.Chen@windriver.com>
>>
>> Default USE_DEVFS to "1" so that the `makedevs' command is not run
>> at rootfs time by default. There are mainly two reasons to do so.
>> 1. This will fix a build failure with initramfs-kexecboot-klibc-image.
>
> Can you elaborate this error? is it something we can/should fix?
>
>> 2. Most of our images use a filesystem over /dev. Most of the time, it's
>>    just devtmpfs. So we actually are using a filesystem over /dev.
>>
>> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
>> ---
>>  meta/classes/image.bbclass |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
>> index cc65e35..b8bd462 100644
>> --- a/meta/classes/image.bbclass
>> +++ b/meta/classes/image.bbclass
>> @@ -77,7 +77,7 @@ PACKAGE_INSTALL_ATTEMPTONLY ?= "${FEATURE_INSTALL_OPTIONAL}"
>>  # Images are generally built explicitly, do not need to be part of world.
>>  EXCLUDE_FROM_WORLD = "1"
>>
>> -USE_DEVFS ?= "0"
>> +USE_DEVFS ?= "1"
>>
>>  PID = "${@os.getpid()}"
>>
>> --
>> 1.7.9.5
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
>
>
> --
> Otavio Salvador                             O.S. Systems
> http://www.ossystems.com.br        http://code.ossystems.com.br
> Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core


The underlying issue here is the extra pass of makedevs  " makedevs:
No entry for root in search list "

At first I could not understand why that was *not* happening on my
builds then I realized we set
IMAGE_DEVICE_TABLES = "" in our machine.conf because we use devtmpfs
for all images.

qemux86 does instead inherit the default setting of image.bbclass so
it uses "files/device_table-minimal.txt"


Cheers

Andrea
Qi.Chen@windriver.com - Dec. 10, 2013, 2:26 a.m.
On 12/09/2013 09:52 PM, Andrea Adami wrote:
> On Mon, Dec 9, 2013 at 12:52 PM, Otavio Salvador
> <otavio@ossystems.com.br> wrote:
>> Hello,
>>
>> I agree with the commit but ...
>>
>> On Mon, Dec 9, 2013 at 1:17 AM,  <Qi.Chen@windriver.com> wrote:
>>> From: Chen Qi <Qi.Chen@windriver.com>
>>>
>>> Default USE_DEVFS to "1" so that the `makedevs' command is not run
>>> at rootfs time by default. There are mainly two reasons to do so.
>>> 1. This will fix a build failure with initramfs-kexecboot-klibc-image.
>> Can you elaborate this error? is it something we can/should fix?
>>
>>> 2. Most of our images use a filesystem over /dev. Most of the time, it's
>>>     just devtmpfs. So we actually are using a filesystem over /dev.
>>>
>>> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
>>> ---
>>>   meta/classes/image.bbclass |    2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
>>> index cc65e35..b8bd462 100644
>>> --- a/meta/classes/image.bbclass
>>> +++ b/meta/classes/image.bbclass
>>> @@ -77,7 +77,7 @@ PACKAGE_INSTALL_ATTEMPTONLY ?= "${FEATURE_INSTALL_OPTIONAL}"
>>>   # Images are generally built explicitly, do not need to be part of world.
>>>   EXCLUDE_FROM_WORLD = "1"
>>>
>>> -USE_DEVFS ?= "0"
>>> +USE_DEVFS ?= "1"
>>>
>>>   PID = "${@os.getpid()}"
>>>
>>> --
>>> 1.7.9.5
>>>
>>> _______________________________________________
>>> Openembedded-core mailing list
>>> Openembedded-core@lists.openembedded.org
>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>
>>
>> --
>> Otavio Salvador                             O.S. Systems
>> http://www.ossystems.com.br        http://code.ossystems.com.br
>> Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
> The underlying issue here is the extra pass of makedevs  " makedevs:
> No entry for root in search list "
>
> At first I could not understand why that was *not* happening on my
> builds then I realized we set
> IMAGE_DEVICE_TABLES = "" in our machine.conf because we use devtmpfs
> for all images.
>
> qemux86 does instead inherit the default setting of image.bbclass so
> it uses "files/device_table-minimal.txt"
>
>
> Cheers
>
> Andrea
>
>

Thanks for you extra information.

Best Regards,
Chen Qi
Qi.Chen@windriver.com - Dec. 10, 2013, 2:31 a.m.
On 12/09/2013 07:52 PM, Otavio Salvador wrote:
> Hello,
>
> I agree with the commit but ...
>
> On Mon, Dec 9, 2013 at 1:17 AM,  <Qi.Chen@windriver.com> wrote:
>> From: Chen Qi <Qi.Chen@windriver.com>
>>
>> Default USE_DEVFS to "1" so that the `makedevs' command is not run
>> at rootfs time by default. There are mainly two reasons to do so.
>> 1. This will fix a build failure with initramfs-kexecboot-klibc-image.
> Can you elaborate this error? is it something we can/should fix?

It's "makedevs: No entry for root in search list ", just as Andrea said.
I've updated the commit message in remote tree.
http://git.yoctoproject.org/cgit.cgi/poky-contrib/commit/?h=ChenQi/USE_DEVFS&id=435b6e6e34c4c65022e57b78a246cfd8fcd2d71f

Thanks,
Chen Qi

>> 2. Most of our images use a filesystem over /dev. Most of the time, it's
>>     just devtmpfs. So we actually are using a filesystem over /dev.
>>
>> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
>> ---
>>   meta/classes/image.bbclass |    2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
>> index cc65e35..b8bd462 100644
>> --- a/meta/classes/image.bbclass
>> +++ b/meta/classes/image.bbclass
>> @@ -77,7 +77,7 @@ PACKAGE_INSTALL_ATTEMPTONLY ?= "${FEATURE_INSTALL_OPTIONAL}"
>>   # Images are generally built explicitly, do not need to be part of world.
>>   EXCLUDE_FROM_WORLD = "1"
>>
>> -USE_DEVFS ?= "0"
>> +USE_DEVFS ?= "1"
>>
>>   PID = "${@os.getpid()}"
>>
>> --
>> 1.7.9.5
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
>
Saul Wold - Dec. 10, 2013, 4:38 a.m.
On 12/09/2013 06:31 PM, ChenQi wrote:
> On 12/09/2013 07:52 PM, Otavio Salvador wrote:
>> Hello,
>>
>> I agree with the commit but ...
>>
>> On Mon, Dec 9, 2013 at 1:17 AM,  <Qi.Chen@windriver.com> wrote:
>>> From: Chen Qi <Qi.Chen@windriver.com>
>>>
>>> Default USE_DEVFS to "1" so that the `makedevs' command is not run
>>> at rootfs time by default. There are mainly two reasons to do so.
>>> 1. This will fix a build failure with initramfs-kexecboot-klibc-image.
>> Can you elaborate this error? is it something we can/should fix?
>
> It's "makedevs: No entry for root in search list ", just as Andrea said.
> I've updated the commit message in remote tree.
> http://git.yoctoproject.org/cgit.cgi/poky-contrib/commit/?h=ChenQi/USE_DEVFS&id=435b6e6e34c4c65022e57b78a246cfd8fcd2d71f
>
Please resend as a V2

Sau!

>
> Thanks,
> Chen Qi
>
>>> 2. Most of our images use a filesystem over /dev. Most of the time, it's
>>>     just devtmpfs. So we actually are using a filesystem over /dev.
>>>
>>> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
>>> ---
>>>   meta/classes/image.bbclass |    2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
>>> index cc65e35..b8bd462 100644
>>> --- a/meta/classes/image.bbclass
>>> +++ b/meta/classes/image.bbclass
>>> @@ -77,7 +77,7 @@ PACKAGE_INSTALL_ATTEMPTONLY ?=
>>> "${FEATURE_INSTALL_OPTIONAL}"
>>>   # Images are generally built explicitly, do not need to be part of
>>> world.
>>>   EXCLUDE_FROM_WORLD = "1"
>>>
>>> -USE_DEVFS ?= "0"
>>> +USE_DEVFS ?= "1"
>>>
>>>   PID = "${@os.getpid()}"
>>>
>>> --
>>> 1.7.9.5
>>>
>>> _______________________________________________
>>> Openembedded-core mailing list
>>> Openembedded-core@lists.openembedded.org
>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>
>>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
>

Patch

diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
index cc65e35..b8bd462 100644
--- a/meta/classes/image.bbclass
+++ b/meta/classes/image.bbclass
@@ -77,7 +77,7 @@  PACKAGE_INSTALL_ATTEMPTONLY ?= "${FEATURE_INSTALL_OPTIONAL}"
 # Images are generally built explicitly, do not need to be part of world.
 EXCLUDE_FROM_WORLD = "1"
 
-USE_DEVFS ?= "0"
+USE_DEVFS ?= "1"
 
 PID = "${@os.getpid()}"