Patchwork aacdec support in gst-fsl-plugin on imx6

login
register
mail settings
Submitter stéphane cerveau
Date Dec. 5, 2013, 5:48 p.m.
Message ID <52A0BC85.3050303@gmail.com>
Download mbox | patch
Permalink /patch/62927/
State Superseded
Delegated to: Otavio Salvador
Headers show

Comments

stéphane cerveau - Dec. 5, 2013, 5:48 p.m.
Dear all,

I was suprised to see that aac decoding was not supported in 
gst-fsl-plugin_3.0.9. After some investigation i discovered that 
makefile.am was not having the AAC option for imx6.
Please see patch attachment.
I add a try and now m4a file are correctly supported in gstreamer.
Is there a reason to disable aac dec on imx6 or is it only a mistake ?
Best regards.

Stéphane
Otavio Salvador - Dec. 7, 2013, 10:40 p.m.
On Thu, Dec 5, 2013 at 3:48 PM, stéphane cerveau <scerveau@gmail.com> wrote:
> I was suprised to see that aac decoding was not supported in
> gst-fsl-plugin_3.0.9. After some investigation i discovered that makefile.am
> was not having the AAC option for imx6.
> Please see patch attachment.
> I add a try and now m4a file are correctly supported in gstreamer.
> Is there a reason to disable aac dec on imx6 or is it only a mistake ?

I think this may have been removed by mistake; please make a proper
patch including this fix so we can review it.
Otavio Salvador - Dec. 13, 2013, 12:13 p.m.
Hello Stéphane,

On Thu, Dec 5, 2013 at 3:48 PM, stéphane cerveau <scerveau@gmail.com> wrote:
> I was suprised to see that aac decoding was not supported in
> gst-fsl-plugin_3.0.9. After some investigation i discovered that makefile.am
> was not having the AAC option for imx6.
> Please see patch attachment.
> I add a try and now m4a file are correctly supported in gstreamer.
> Is there a reason to disable aac dec on imx6 or is it only a mistake ?

Could you please prepare a proper patch to meta-fsl-arm with the patch
so I can apply it?
stéphane cerveau - Dec. 13, 2013, 1:10 p.m.
Dear Otavio,

I submitted a patch few days ago, did you receive it ?
BR

Stéphane
On 12/13/2013 01:13 PM, Otavio Salvador wrote:
> Hello Stéphane,
>
> On Thu, Dec 5, 2013 at 3:48 PM, stéphane cerveau <scerveau@gmail.com> wrote:
>> I was suprised to see that aac decoding was not supported in
>> gst-fsl-plugin_3.0.9. After some investigation i discovered that makefile.am
>> was not having the AAC option for imx6.
>> Please see patch attachment.
>> I add a try and now m4a file are correctly supported in gstreamer.
>> Is there a reason to disable aac dec on imx6 or is it only a mistake ?
> Could you please prepare a proper patch to meta-fsl-arm with the patch
> so I can apply it?
>
Otavio Salvador - Dec. 13, 2013, 1:39 p.m.
On Fri, Dec 13, 2013 at 11:10 AM, stéphane cerveau <scerveau@gmail.com> wrote:
> Dear Otavio,
>
> I submitted a patch few days ago, did you receive it ?

I didn't. Neither patchwork did. Please resend.

Patch

--- a/Makefile.am	2013-09-10 20:52:22.000000000 +0200
+++ b/Makefile.am	2013-12-05 18:26:24.964585163 +0100
@@ -928,7 +928,7 @@ 
 		tools/gplay
 
 SUBDIRS =  $(AUDIODIRS)  $(LIBSDIRS) $(BASEDIRS) $(VPUWRAPDIRS) $(WMA8ENC_DIR) $(MP3ENC_DIR) \
- $(H264DEC_DIR) $(MPEG2DEC_DIR) $(MPEG4DEC_DIR) $(WMV9MPDEC_DIR) $(WMV78DEC_DIR) \
+ $(H264DEC_DIR) $(MPEG2DEC_DIR) $(MPEG4DEC_DIR) $(WMV9MPDEC_DIR) $(WMV78DEC_DIR) $(AACDEC_DIR)\
  $(DOWNMIX_DIR) $(AMRDEC_DIR) $(IPUDIRS) $(TOOLDIRS)
 
 endif