Patchwork [bitbake-devel] hob: changes to INHERIT var should use "append" operation

login
register
mail settings
Submitter Cristiana Voicu
Date Dec. 5, 2013, 2:09 p.m.
Message ID <1386252555-6067-1-git-send-email-cristiana.voicu@intel.com>
Download mbox | patch
Permalink /patch/62913/
State New
Headers show

Comments

Cristiana Voicu - Dec. 5, 2013, 2:09 p.m.
Setting INHERIT var means to remove other operations made on INHERIT.
This is too intrusive, so we decided to use append for this case.

[YOCTO #5448]
Signed-off-by: Cristiana Voicu <cristiana.voicu@intel.com>
---
 bitbake/lib/bb/ui/crumbs/hobeventhandler.py |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Patch

diff --git a/bitbake/lib/bb/ui/crumbs/hobeventhandler.py b/bitbake/lib/bb/ui/crumbs/hobeventhandler.py
index ce8584d..7014935 100644
--- a/bitbake/lib/bb/ui/crumbs/hobeventhandler.py
+++ b/bitbake/lib/bb/ui/crumbs/hobeventhandler.py
@@ -306,9 +306,7 @@  class HobHandler(gobject.GObject):
         self.runCommand(["createConfigFile", ".hob.conf"])
 
     def set_extra_inherit(self, bbclass):
-        inherits = self.runCommand(["getVariable", "INHERIT"]) or ""
-        inherits = inherits + " " + bbclass
-        self.set_var_in_file("INHERIT", inherits, ".hob.conf")
+        self.append_var_in_file("INHERIT", bbclass, ".hob.conf")
 
     def set_bblayers(self, bblayers):
         self.set_var_in_file("BBLAYERS", " ".join(bblayers), "bblayers.conf")