Patchwork [1/3] documentation.conf: remove unused IMAGETEST variable

login
register
mail settings
Submitter Ross Burton
Date Dec. 5, 2013, 12:55 p.m.
Message ID <1386248161-7086-1-git-send-email-ross.burton@intel.com>
Download mbox | patch
Permalink /patch/62905/
State New
Headers show

Comments

Ross Burton - Dec. 5, 2013, 12:55 p.m.
Signed-off-by: Ross Burton <ross.burton@intel.com>
---
 meta/conf/documentation.conf |    1 -
 1 file changed, 1 deletion(-)
Richard Purdie - Dec. 5, 2013, 1:32 p.m.
On Thu, 2013-12-05 at 12:55 +0000, Ross Burton wrote:
> Signed-off-by: Ross Burton <ross.burton@intel.com>
> ---
>  meta/conf/documentation.conf |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/meta/conf/documentation.conf b/meta/conf/documentation.conf
> index 6666648..db3701b 100644
> --- a/meta/conf/documentation.conf
> +++ b/meta/conf/documentation.conf
> @@ -118,7 +118,6 @@ IMAGE_LINGUAS[doc] = "Specifies the list of locales to install into the image du
>  IMAGE_OVERHEAD_FACTOR[doc] = "Defines a multiplier that the build system applies to the initial image size for cases when the multiplier times the returned disk usage value for the image is greater than the sum of IMAGE_ROOTFS_SIZE and IMAGE_ROOTFS_EXTRA_SPACE."
>  IMAGE_ROOTFS_EXTRA_SPACE[doc] = "Defines additional free disk space created in the image in Kbytes. By default, this variable is set to '0'."
>  IMAGE_ROOTFS_SIZE[doc] = "Defines the size in Kbytes for the generated image."
> -IMAGETEST[doc] = "Enable test booting of virtual machine images under the qemu emulator after any root filesystems are created and run tests against those images."
>  INC_PR[doc] = "Helps define the recipe revision for recipes that share a common include file."
>  INHIBIT_PACKAGE_STRIP[doc] = "If set to "1", causes the build to not strip binaries in resulting packages."
>  INHERIT[doc] = "Causes the named class to be inherited at this point during parsing. The variable is only valid in configuration files."

Isn't it actually IMAGE_TEST ?

Cheers,

Richard
Paul Eggleton - Dec. 5, 2013, 1:42 p.m.
On Thursday 05 December 2013 13:32:54 Richard Purdie wrote:
> On Thu, 2013-12-05 at 12:55 +0000, Ross Burton wrote:
> > Signed-off-by: Ross Burton <ross.burton@intel.com>
> > ---
> > 
> >  meta/conf/documentation.conf |    1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/meta/conf/documentation.conf b/meta/conf/documentation.conf
> > index 6666648..db3701b 100644
> > --- a/meta/conf/documentation.conf
> > +++ b/meta/conf/documentation.conf
> > @@ -118,7 +118,6 @@ IMAGE_LINGUAS[doc] = "Specifies the list of locales to
> > install into the image du> 
> >  IMAGE_OVERHEAD_FACTOR[doc] = "Defines a multiplier that the build system
> >  applies to the initial image size for cases when the multiplier times
> >  the returned disk usage value for the image is greater than the sum of
> >  IMAGE_ROOTFS_SIZE and IMAGE_ROOTFS_EXTRA_SPACE."
> >  IMAGE_ROOTFS_EXTRA_SPACE[doc] = "Defines additional free disk space
> >  created in the image in Kbytes. By default, this variable is set to
> >  '0'." IMAGE_ROOTFS_SIZE[doc] = "Defines the size in Kbytes for the
> >  generated image."> 
> > -IMAGETEST[doc] = "Enable test booting of virtual machine images under the
> > qemu emulator after any root filesystems are created and run tests
> > against those images."> 
> >  INC_PR[doc] = "Helps define the recipe revision for recipes that share a
> >  common include file." INHIBIT_PACKAGE_STRIP[doc] = "If set to "1",
> >  causes the build to not strip binaries in resulting packages."
> >  INHERIT[doc] = "Causes the named class to be inherited at this point
> >  during parsing. The variable is only valid in configuration files."
>
> Isn't it actually IMAGE_TEST ?

If you mean what it is now, it's TEST_IMAGE.

If we're removing the old IMAGETEST variable (and we should) we should also 
remove TEST_SCEN at the same time.

Cheers,
Paul
Paul Eggleton - Dec. 5, 2013, 1:44 p.m.
On Thursday 05 December 2013 13:42:17 Paul Eggleton wrote:
> On Thursday 05 December 2013 13:32:54 Richard Purdie wrote:
> > On Thu, 2013-12-05 at 12:55 +0000, Ross Burton wrote:
> > > Signed-off-by: Ross Burton <ross.burton@intel.com>
> > > ---
> > > 
> > >  meta/conf/documentation.conf |    1 -
> > >  1 file changed, 1 deletion(-)
> > > 
> > > diff --git a/meta/conf/documentation.conf b/meta/conf/documentation.conf
> > > index 6666648..db3701b 100644
> > > --- a/meta/conf/documentation.conf
> > > +++ b/meta/conf/documentation.conf
> > > @@ -118,7 +118,6 @@ IMAGE_LINGUAS[doc] = "Specifies the list of locales
> > > to
> > > install into the image du>
> > > 
> > >  IMAGE_OVERHEAD_FACTOR[doc] = "Defines a multiplier that the build
> > >  system
> > >  applies to the initial image size for cases when the multiplier times
> > >  the returned disk usage value for the image is greater than the sum of
> > >  IMAGE_ROOTFS_SIZE and IMAGE_ROOTFS_EXTRA_SPACE."
> > >  IMAGE_ROOTFS_EXTRA_SPACE[doc] = "Defines additional free disk space
> > >  created in the image in Kbytes. By default, this variable is set to
> > >  '0'." IMAGE_ROOTFS_SIZE[doc] = "Defines the size in Kbytes for the
> > >  generated image.">
> > > 
> > > -IMAGETEST[doc] = "Enable test booting of virtual machine images under
> > > the
> > > qemu emulator after any root filesystems are created and run tests
> > > against those images.">
> > > 
> > >  INC_PR[doc] = "Helps define the recipe revision for recipes that share
> > >  a
> > >  common include file." INHIBIT_PACKAGE_STRIP[doc] = "If set to "1",
> > >  causes the build to not strip binaries in resulting packages."
> > >  INHERIT[doc] = "Causes the named class to be inherited at this point
> > >  during parsing. The variable is only valid in configuration files."
> > 
> > Isn't it actually IMAGE_TEST ?
> 
> If you mean what it is now, it's TEST_IMAGE.
> 
> If we're removing the old IMAGETEST variable (and we should) we should also
> remove TEST_SCEN at the same time.

... and also TEST_SERIALIZE.

Cheers,
Paul

Patch

diff --git a/meta/conf/documentation.conf b/meta/conf/documentation.conf
index 6666648..db3701b 100644
--- a/meta/conf/documentation.conf
+++ b/meta/conf/documentation.conf
@@ -118,7 +118,6 @@  IMAGE_LINGUAS[doc] = "Specifies the list of locales to install into the image du
 IMAGE_OVERHEAD_FACTOR[doc] = "Defines a multiplier that the build system applies to the initial image size for cases when the multiplier times the returned disk usage value for the image is greater than the sum of IMAGE_ROOTFS_SIZE and IMAGE_ROOTFS_EXTRA_SPACE."
 IMAGE_ROOTFS_EXTRA_SPACE[doc] = "Defines additional free disk space created in the image in Kbytes. By default, this variable is set to '0'."
 IMAGE_ROOTFS_SIZE[doc] = "Defines the size in Kbytes for the generated image."
-IMAGETEST[doc] = "Enable test booting of virtual machine images under the qemu emulator after any root filesystems are created and run tests against those images."
 INC_PR[doc] = "Helps define the recipe revision for recipes that share a common include file."
 INHIBIT_PACKAGE_STRIP[doc] = "If set to "1", causes the build to not strip binaries in resulting packages."
 INHERIT[doc] = "Causes the named class to be inherited at this point during parsing. The variable is only valid in configuration files."