Patchwork [meta-perl] add libcrypt-openssl-rsa-perl

login
register
mail settings
Submitter Patrick Patat
Date Dec. 4, 2013, 10:59 a.m.
Message ID <1386154747-14820-1-git-send-email-patrick.patat@innotis.org>
Download mbox | patch
Permalink /patch/62789/
State Superseded, archived
Headers show

Comments

Patrick Patat - Dec. 4, 2013, 10:59 a.m.
This recipe build cpan module Crypt-OpenSSL-RSA

Signed-off-by: Patrick Patat <patrick.patat@innotis.org>
---
 .../libcrypt/libcrypt-openssl-rsa-perl_0.28.bb     |   23 ++++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 meta-perl/recipes-perl/libcrypt/libcrypt-openssl-rsa-perl_0.28.bb
Koen Kooi - Dec. 4, 2013, 11:15 a.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Patrick Patat schreef op 04-12-13 11:59:
> This recipe build cpan module Crypt-OpenSSL-RSA
> 
> Signed-off-by: Patrick Patat <patrick.patat@innotis.org> --- 
> .../libcrypt/libcrypt-openssl-rsa-perl_0.28.bb     |   23
> ++++++++++++++++++++

> 1 file changed, 23 insertions(+) create mode 100644
> meta-perl/recipes-perl/libcrypt/libcrypt-openssl-rsa-perl_0.28.bb
> 
> diff --git
> a/meta-perl/recipes-perl/libcrypt/libcrypt-openssl-rsa-perl_0.28.bb
> b/meta-perl/recipes-perl/libcrypt/libcrypt-openssl-rsa-perl_0.28.bb new
> file mode 100644 index 0000000..3d902a3 --- /dev/null +++
> b/meta-perl/recipes-perl/libcrypt/libcrypt-openssl-rsa-perl_0.28.bb @@
> -0,0 +1,23 @@ +SUMMARY = "Collection of Perl modules for working with
> shairport."

I don't think that's the correct summary.

> +SECTION = "libs" +LICENSE = "MIT" +LIC_FILES_CHKSUM =
> "file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
>
> 
+
> +SRC_URI =
> "http://www.cpan.org/modules/by-module/Crypt/Crypt-OpenSSL-RSA-${PV}.tar.gz
> " + +SRC_URI[md5sum] = "86217a5036fc63779c30420b5fd84129" 
> +SRC_URI[sha256sum] =
> "5357f977464bb3a8184cf2d3341851a10d5515b4b2b0dfb88bf78995c0ded7be" + 
> +DEPENDS += "perl openssl"

'perl' should already be added by cpan.bbclass.

> + +EXTRA_CPANFLAGS = "INC='-I${STAGING_INCDIR}' LIBS='-L${STAGING_LIBDIR}
> -lssl -L${STAGING_DIR_TARGET}${base_libdir} -lcrypto'" + +S =
> "${WORKDIR}/Crypt-OpenSSL-RSA-${PV}" + +inherit cpan + +do_compile() { +
> export LIBC="$(find ${STAGING_DIR_TARGET}${base_libdir}/ -name
> 'libc-*.so')" +	export OTHERLDFLAGS='-Wl,-rpath' +
> cpan_do_compile +}

http://deps.cpantesters.org/?module=Crypt%3A%3AOpenSSL%3A%3ARSA;perl=latest
reports a dependency on openssl::random, so you probably need an
RDEPENDS_${PN} for that.

regards,

Koen

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
Comment: GPGTools - http://gpgtools.org

iD8DBQFSnw63MkyGM64RGpERAuWfAJ0XUBxSe4MnayKTfGJVUNlaWEoDrQCggTM3
LMPrOwaSjEy3jvF67JCYpi8=
=cy5N
-----END PGP SIGNATURE-----
Roman Khimov - Dec. 4, 2013, 11:28 a.m.
? ?????? ?? 4 ??????? 2013 11:59:07 ???????????? Patrick Patat ???????:
> +DEPENDS += "perl openssl"
> +
> +EXTRA_CPANFLAGS = "INC='-I${STAGING_INCDIR}' LIBS='-L${STAGING_LIBDIR}
> -lssl -L${STAGING_DIR_TARGET}${base_libdir} -lcrypto'" +
> +S = "${WORKDIR}/Crypt-OpenSSL-RSA-${PV}"
> +
> +inherit cpan
> +
> +do_compile() {
> +        export LIBC="$(find ${STAGING_DIR_TARGET}${base_libdir}/ -name
> 'libc-*.so')" +	export OTHERLDFLAGS='-Wl,-rpath'
> +        cpan_do_compile
> +}

Although this one:
http://git.openembedded.org/openembedded/commit/?id=0f2de8ebc390406205fd0b27f62c833895aa6901
is for a bit different version in a bit different kind of OE, I think you 
don't need this kind of CPANFLAGS and do_compile mangling. Also, inheriting 
cpan already sets proper perl DEPENDS/RDEPENDS.
Olof Johansson - Dec. 4, 2013, 1:05 p.m.
On 13-12-04 11:59 +0100, Patrick Patat wrote:
> +LICENSE = "MIT"

Where did you get MIT from? From what I can tell, it's
GPL1+/Artistic as usual. "Same as perl"

Regards,
Patrick Patat - Dec. 4, 2013, 1:21 p.m.
On Wed, Dec 4, 2013 at 12:28 PM, Roman Khimov <khimov@altell.ru> wrote:

> ? ?????? ?? 4 ??????? 2013 11:59:07 ???????????? Patrick Patat ???????:
> > +DEPENDS += "perl openssl"
> > +
> > +EXTRA_CPANFLAGS = "INC='-I${STAGING_INCDIR}' LIBS='-L${STAGING_LIBDIR}
> > -lssl -L${STAGING_DIR_TARGET}${base_libdir} -lcrypto'" +
> > +S = "${WORKDIR}/Crypt-OpenSSL-RSA-${PV}"
> > +
> > +inherit cpan
> > +
> > +do_compile() {
> > +        export LIBC="$(find ${STAGING_DIR_TARGET}${base_libdir}/ -name
> > 'libc-*.so')" +       export OTHERLDFLAGS='-Wl,-rpath'
> > +        cpan_do_compile
> > +}
>
> Although this one:
>
> http://git.openembedded.org/openembedded/commit/?id=0f2de8ebc390406205fd0b27f62c833895aa6901
> is for a bit different version in a bit different kind of OE, I think you
> don't need this kind of CPANFLAGS and do_compile mangling. Also, inheriting
> cpan already sets proper perl DEPENDS/RDEPENDS.
>

Without EXTRA_CPANFLAGS I have the following error at run time:
Can't load
'/usr/lib/perl/vendor_perl/5.14.3//auto/Crypt/OpenSSL/RSA/RSA.so' for
module Crypt::OpenSSL::RSA:
/usr/lib/perl/vendor_perl/5.14.3//auto/Crypt/OpenSSL/RSA/RSA.so: undefined
symbol: RSA_public_encrypt at /usr/lib/perl/5.14.3//DynaLoader.pm line 194.

Then with EXTRA_CPANFLAGS I have QA issue about bad RPATH so this is why I
add OTHERLDFLAGS in do compile.


> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
>

Patch

diff --git a/meta-perl/recipes-perl/libcrypt/libcrypt-openssl-rsa-perl_0.28.bb b/meta-perl/recipes-perl/libcrypt/libcrypt-openssl-rsa-perl_0.28.bb
new file mode 100644
index 0000000..3d902a3
--- /dev/null
+++ b/meta-perl/recipes-perl/libcrypt/libcrypt-openssl-rsa-perl_0.28.bb
@@ -0,0 +1,23 @@ 
+SUMMARY = "Collection of Perl modules for working with shairport."
+SECTION = "libs"
+LICENSE = "MIT"
+LIC_FILES_CHKSUM = "file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
+
+SRC_URI = "http://www.cpan.org/modules/by-module/Crypt/Crypt-OpenSSL-RSA-${PV}.tar.gz "
+
+SRC_URI[md5sum] = "86217a5036fc63779c30420b5fd84129"
+SRC_URI[sha256sum] = "5357f977464bb3a8184cf2d3341851a10d5515b4b2b0dfb88bf78995c0ded7be"
+
+DEPENDS += "perl openssl"
+
+EXTRA_CPANFLAGS = "INC='-I${STAGING_INCDIR}' LIBS='-L${STAGING_LIBDIR} -lssl -L${STAGING_DIR_TARGET}${base_libdir} -lcrypto'"
+
+S = "${WORKDIR}/Crypt-OpenSSL-RSA-${PV}"
+
+inherit cpan
+
+do_compile() {
+        export LIBC="$(find ${STAGING_DIR_TARGET}${base_libdir}/ -name 'libc-*.so')"
+	export OTHERLDFLAGS='-Wl,-rpath'
+        cpan_do_compile
+}