| Submitter | Mark Hatle |
|---|---|
| Date | June 22, 2011, 5:36 p.m. |
| Message ID | <d841fe05df49bcc07373ab510be5ddeb9f97324c.1308763995.git.mark.hatle@windriver.com> |
| Download | mbox | patch |
| Permalink | /patch/6263/ |
| State | New, archived |
| Headers | show |
Comments
On Wed, 2011-06-22 at 12:36 -0500, Mark Hatle wrote: > If perf isn't installed under "fakeroot" (pseudo) control, all of the files > are given the build user's uid/gid. The bit about do_install_perf() seems reasonable, but why does do_compile_perf() need to run under fakeroot? > diff --git a/meta/recipes-kernel/linux/linux-tools.inc b/meta/recipes-kernel/linux/linux-tools.inc > index ef81650..88a1c5b 100644 > --- a/meta/recipes-kernel/linux/linux-tools.inc > +++ b/meta/recipes-kernel/linux/linux-tools.inc > @@ -6,11 +6,11 @@ do_compile_perf_libc-uclibc () { > do_install_perf_libc-uclibc () { > : > } > -do_compile_perf() { > +fakeroot do_compile_perf() { > oe_runmake -C ${S}/tools/perf CC="${CC}" LD="${LD}" prefix=${prefix} NO_NEWT=1 NO_DWARF=1 > } > > -do_install_perf() { > +fakeroot do_install_perf() { > oe_runmake -C ${S}/tools/perf CC="${CC}" LD="${LD}" prefix=${prefix} DESTDIR=${D} install NO_NEWT=1 NO_DWARF=1 > } > p.
Patch
diff --git a/meta/recipes-kernel/linux/linux-tools.inc b/meta/recipes-kernel/linux/linux-tools.inc index ef81650..88a1c5b 100644 --- a/meta/recipes-kernel/linux/linux-tools.inc +++ b/meta/recipes-kernel/linux/linux-tools.inc @@ -6,11 +6,11 @@ do_compile_perf_libc-uclibc () { do_install_perf_libc-uclibc () { : } -do_compile_perf() { +fakeroot do_compile_perf() { oe_runmake -C ${S}/tools/perf CC="${CC}" LD="${LD}" prefix=${prefix} NO_NEWT=1 NO_DWARF=1 } -do_install_perf() { +fakeroot do_install_perf() { oe_runmake -C ${S}/tools/perf CC="${CC}" LD="${LD}" prefix=${prefix} DESTDIR=${D} install NO_NEWT=1 NO_DWARF=1 }
If perf isn't installed under "fakeroot" (pseudo) control, all of the files are given the build user's uid/gid. Signed-off-by: Mark Hatle <mark.hatle@windriver.com> --- meta/recipes-kernel/linux/linux-tools.inc | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)