Patchwork module-base: Fix misleading comment

login
register
mail settings
Submitter Richard Purdie
Date Nov. 27, 2013, 1:45 p.m.
Message ID <1385559942.11222.1.camel@ted>
Download mbox | patch
Permalink /patch/62477/
State Accepted
Commit 977d62328723d33b873b02a3e543ba7db865fa7c
Headers show

Comments

Richard Purdie - Nov. 27, 2013, 1:45 p.m.
The comment was originally written for module.bbclass and is now
slightly misleading. This updates it to match the current code.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
Bruce Ashfield - Nov. 27, 2013, 1:46 p.m.
On 13-11-27 08:45 AM, Richard Purdie wrote:
> The comment was originally written for module.bbclass and is now
> slightly misleading. This updates it to match the current code.

Acked-by: Bruce Ashfield <bruce.ashfield@windriver.com>

>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
> diff --git a/meta/classes/module-base.bbclass b/meta/classes/module-base.bbclass
> index 9dbb4b4..1589a90 100644
> --- a/meta/classes/module-base.bbclass
> +++ b/meta/classes/module-base.bbclass
> @@ -11,11 +11,8 @@ KERNEL_OBJECT_SUFFIX = ".ko"
>   # kernel modules are generally machine specific
>   PACKAGE_ARCH = "${MACHINE_ARCH}"
>
> -#
> -# Ensure the hostprogs are available for module compilation. Modules that
> -# inherit this recipe and override do_compile() should be sure to call
> -# do_make_scripts() or ensure the scripts are built independently.
> -#
> +# Function to ensure the kernel scripts are created. Expected to
> +# be called before do_compile. See module.bbclass for an exmaple.
>   do_make_scripts() {
>   	unset CFLAGS CPPFLAGS CXXFLAGS LDFLAGS
>   	make CC="${KERNEL_CC}" LD="${KERNEL_LD}" AR="${KERNEL_AR}" \
>
>
Khem Raj - Nov. 27, 2013, 3:44 p.m.
On Wednesday, November 27, 2013, Bruce Ashfield wrote:

> On 13-11-27 08:45 AM, Richard Purdie wrote:
>
>> The comment was originally written for module.bbclass and is now
>> slightly misleading. This updates it to match the current code.
>>
>
> Acked-by: Bruce Ashfield <bruce.ashfield@windriver.com>


Looks ok

>
>
>> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
>> ---
>> diff --git a/meta/classes/module-base.bbclass b/meta/classes/module-base.
>> bbclass
>> index 9dbb4b4..1589a90 100644
>> --- a/meta/classes/module-base.bbclass
>> +++ b/meta/classes/module-base.bbclass
>> @@ -11,11 +11,8 @@ KERNEL_OBJECT_SUFFIX = ".ko"
>>   # kernel modules are generally machine specific
>>   PACKAGE_ARCH = "${MACHINE_ARCH}"
>>
>> -#
>> -# Ensure the hostprogs are available for module compilation. Modules that
>> -# inherit this recipe and override do_compile() should be sure to call
>> -# do_make_scripts() or ensure the scripts are built independently.
>> -#
>> +# Function to ensure the kernel scripts are created. Expected to
>> +# be called before do_compile. See module.bbclass for an exmaple.
>>   do_make_scripts() {
>>         unset CFLAGS CPPFLAGS CXXFLAGS LDFLAGS
>>         make CC="${KERNEL_CC}" LD="${KERNEL_LD}" AR="${KERNEL_AR}" \
>>
>>
>>
>

Patch

diff --git a/meta/classes/module-base.bbclass b/meta/classes/module-base.bbclass
index 9dbb4b4..1589a90 100644
--- a/meta/classes/module-base.bbclass
+++ b/meta/classes/module-base.bbclass
@@ -11,11 +11,8 @@  KERNEL_OBJECT_SUFFIX = ".ko"
 # kernel modules are generally machine specific
 PACKAGE_ARCH = "${MACHINE_ARCH}"
 
-#
-# Ensure the hostprogs are available for module compilation. Modules that
-# inherit this recipe and override do_compile() should be sure to call
-# do_make_scripts() or ensure the scripts are built independently.
-#
+# Function to ensure the kernel scripts are created. Expected to
+# be called before do_compile. See module.bbclass for an exmaple.
 do_make_scripts() {
 	unset CFLAGS CPPFLAGS CXXFLAGS LDFLAGS 
 	make CC="${KERNEL_CC}" LD="${KERNEL_LD}" AR="${KERNEL_AR}" \