Patchwork [v2] classes/native*.bbclass: fix error during parse with bitbake master

login
register
mail settings
Submitter Paul Eggleton
Date June 22, 2011, 10:18 a.m.
Message ID <1308737894-5494-1-git-send-email-paul.eggleton@linux.intel.com>
Download mbox | patch
Permalink /patch/6239/
State Accepted
Headers show

Comments

Paul Eggleton - June 22, 2011, 10:18 a.m.
Fixes "AttributeError: 'NoneType' object has no attribute 'split'" during
parsing with bitbake master. We should not be calling explode_deps with
None as the argument, so ensure the value isn't None.

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
---
 classes/native.bbclass    |    2 +-
 classes/nativesdk.bbclass |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Andrea Adami - June 23, 2011, 11:26 p.m.
On Wed, Jun 22, 2011 at 12:18 PM, Paul Eggleton
<paul.eggleton@linux.intel.com> wrote:
> Fixes "AttributeError: 'NoneType' object has no attribute 'split'" during
> parsing with bitbake master. We should not be calling explode_deps with
> None as the argument, so ensure the value isn't None.
>
> Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
> ---
>  classes/native.bbclass    |    2 +-
>  classes/nativesdk.bbclass |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
<snip>

Acked-by: Andrea Adami <andrea.adami@gmail.com>

Patch

diff --git a/classes/native.bbclass b/classes/native.bbclass
index 1e7a6ec..6f30471 100644
--- a/classes/native.bbclass
+++ b/classes/native.bbclass
@@ -115,7 +115,7 @@  python __anonymous () {
 
     if "native" in (bb.data.getVar('BBCLASSEXTEND', d, True) or ""):
         pn = bb.data.getVar("PN", d, True)
-        depends = bb.data.getVar("DEPENDS_virtclass-native", d, True)
+        depends = bb.data.getVar("DEPENDS_virtclass-native", d, True) or ""
         deps = bb.utils.explode_deps(depends)
         newdeps = []
         for dep in deps:
diff --git a/classes/nativesdk.bbclass b/classes/nativesdk.bbclass
index 6689399..6607abf 100644
--- a/classes/nativesdk.bbclass
+++ b/classes/nativesdk.bbclass
@@ -58,7 +58,7 @@  OVERRIDES =. "virtclass-nativesdk:"
 
 python __anonymous () {
     pn = bb.data.getVar("PN", d, True)
-    depends = bb.data.getVar("DEPENDS_virtclass-nativesdk", d, True)
+    depends = bb.data.getVar("DEPENDS_virtclass-nativesdk", d, True) or ""
     deps = bb.utils.explode_deps(depends)
     newdeps = []
     for dep in deps: