Patchwork [meta-fsl-arm] gst-fsl-plugin: Fix that enables mfw_isink work by default.

login
register
mail settings
Submitter Janis Coders
Date Nov. 25, 2013, 10:42 a.m.
Message ID <1385376175-17762-1-git-send-email-janis.coders@gmail.com>
Download mbox | patch
Permalink /patch/62279/
State Not Applicable
Delegated to: Otavio Salvador
Headers show

Comments

Janis Coders - Nov. 25, 2013, 10:42 a.m.
vssconfig by default has fb_num configured to 1, but the value
must be set to 2 for isink to work properly.

Note, that VSALPHA still must be set manually.

Signed-off-by: J?nis ?oders <janis.coders@gmail.com>
---
 ...ault-framebuffer-number-to-2-in-vssconfig.patch | 25 ++++++++++++++++++++++
 .../gstreamer/gst-fsl-plugin_3.0.9.bb              |  3 ++-
 2 files changed, 27 insertions(+), 1 deletion(-)
 create mode 100644 recipes-multimedia/gstreamer/gst-fsl-plugin/change-default-framebuffer-number-to-2-in-vssconfig.patch
Otavio Salvador - Nov. 25, 2013, 11:22 a.m.
Hello Janis,

Thanks for sending the patch.

On Mon, Nov 25, 2013 at 8:42 AM, J?nis ?oders <janis.coders@gmail.com> wrote:
> vssconfig by default has fb_num configured to 1, but the value
> must be set to 2 for isink to work properly.
>
> Note, that VSALPHA still must be set manually.
>
> Signed-off-by: J?nis ?oders <janis.coders@gmail.com>

Lauren, please review this patch and ack/nack it. As I am not a
multimedia guy I don't feel confortable in acking it as I don't know
the implications for users of this change. Please let me know your
thoughts.
Daiane Angolini - Dec. 13, 2013, 11:37 a.m.
On 25-11-2013 09:22, Otavio Salvador wrote:
> Hello Janis,
>
> Thanks for sending the patch.
>
> On Mon, Nov 25, 2013 at 8:42 AM, J?nis ?oders <janis.coders@gmail.com> wrote:
>> vssconfig by default has fb_num configured to 1, but the value
>> must be set to 2 for isink to work properly.
>>
>> Note, that VSALPHA still must be set manually.
>>
>> Signed-off-by: J?nis ?oders <janis.coders@gmail.com>
>
> Lauren, please review this patch and ack/nack it. As I am not a
> multimedia guy I don't feel confortable in acking it as I don't know
> the implications for users of this change. Please let me know your
> thoughts.
>

Janis, what target did you use for testing the patch?
Janis Coders - Dec. 13, 2013, 4:44 p.m.
I used board based on QSB - imx53.


On 13 December 2013 13:37, Daiane Angolini <daiane.angolini@freescale.com>wrote:

> On 25-11-2013 09:22, Otavio Salvador wrote:
>
>> Hello Janis,
>>
>> Thanks for sending the patch.
>>
>> On Mon, Nov 25, 2013 at 8:42 AM, J?nis ?oders <janis.coders@gmail.com>
>> wrote:
>>
>>> vssconfig by default has fb_num configured to 1, but the value
>>> must be set to 2 for isink to work properly.
>>>
>>> Note, that VSALPHA still must be set manually.
>>>
>>> Signed-off-by: J?nis ?oders <janis.coders@gmail.com>
>>>
>>
>> Lauren, please review this patch and ack/nack it. As I am not a
>> multimedia guy I don't feel confortable in acking it as I don't know
>> the implications for users of this change. Please let me know your
>> thoughts.
>>
>>
> Janis, what target did you use for testing the patch?
>
> --
> Daiane
>
>
Daiane Angolini - Dec. 13, 2013, 4:49 p.m.
On 13-12-2013 14:44, J?nis ?oders wrote:
> I used board based on QSB - imx53.

I think your patch breaks imx6. Are you available to test it on any imx6 
board?

Otherwise, I will try to test it next week, before we merge the patch


Daiane
>
>
> On 13 December 2013 13:37, Daiane Angolini
> <daiane.angolini@freescale.com <mailto:daiane.angolini@freescale.com>>
> wrote:
>
>     On 25-11-2013 09:22, Otavio Salvador wrote:
>
>         Hello Janis,
>
>         Thanks for sending the patch.
>
>         On Mon, Nov 25, 2013 at 8:42 AM, J?nis ?oders
>         <janis.coders@gmail.com <mailto:janis.coders@gmail.com>> wrote:
>
>             vssconfig by default has fb_num configured to 1, but the value
>             must be set to 2 for isink to work properly.
>
>             Note, that VSALPHA still must be set manually.
>
>             Signed-off-by: J?nis ?oders <janis.coders@gmail.com
>             <mailto:janis.coders@gmail.com>>
>
>
>         Lauren, please review this patch and ack/nack it. As I am not a
>         multimedia guy I don't feel confortable in acking it as I don't know
>         the implications for users of this change. Please let me know your
>         thoughts.
>
>
>     Janis, what target did you use for testing the patch?
>
>     --
>     Daiane
>
>
>
>
> --
> Ar cie?u,
> J?nis ?oders
Janis Coders - Dec. 13, 2013, 9:08 p.m.
No, unfortunately I don't have imx6 based board. And yeah, I hoped someone
could test this on imx6.


On 13 December 2013 18:49, Daiane Angolini <daiane.angolini@freescale.com>wrote:

> On 13-12-2013 14:44, J?nis ?oders wrote:
>
>> I used board based on QSB - imx53.
>>
>
> I think your patch breaks imx6. Are you available to test it on any imx6
> board?
>
> Otherwise, I will try to test it next week, before we merge the patch
>
>
> Daiane
>
>>
>>
>> On 13 December 2013 13:37, Daiane Angolini
>> <daiane.angolini@freescale.com <mailto:daiane.angolini@freescale.com>>
>>
>> wrote:
>>
>>     On 25-11-2013 09:22, Otavio Salvador wrote:
>>
>>         Hello Janis,
>>
>>         Thanks for sending the patch.
>>
>>         On Mon, Nov 25, 2013 at 8:42 AM, J?nis ?oders
>>         <janis.coders@gmail.com <mailto:janis.coders@gmail.com>> wrote:
>>
>>             vssconfig by default has fb_num configured to 1, but the value
>>             must be set to 2 for isink to work properly.
>>
>>             Note, that VSALPHA still must be set manually.
>>
>>             Signed-off-by: J?nis ?oders <janis.coders@gmail.com
>>             <mailto:janis.coders@gmail.com>>
>>
>>
>>
>>         Lauren, please review this patch and ack/nack it. As I am not a
>>         multimedia guy I don't feel confortable in acking it as I don't
>> know
>>         the implications for users of this change. Please let me know your
>>         thoughts.
>>
>>
>>     Janis, what target did you use for testing the patch?
>>
>>     --
>>     Daiane
>>
>>
>>
>>
>> --
>> Ar cie?u,
>> J?nis ?oders
>>
>
>
> --
> Daiane
>
>
Daiane Angolini - Jan. 13, 2014, 1:06 p.m.
> -----Original Message-----

> From: meta-freescale-bounces@yoctoproject.org [mailto:meta-freescale-

> bounces@yoctoproject.org] On Behalf Of Daiane Angolini

> Sent: Friday, December 13, 2013 2:49 PM

> To: J?nis ?oders

> Cc: meta-freescale@yoctoproject.org; Otavio Salvador

> Subject: Re: [meta-freescale] [meta-fsl-arm][PATCH] gst-fsl-plugin: Fix

> that enables mfw_isink work by default.

> 

> On 13-12-2013 14:44, J?nis ?oders wrote:

> > I used board based on QSB - imx53.

> 

> I think your patch breaks imx6. Are you available to test it on any imx6

> board?

> 

> Otherwise, I will try to test it next week, before we merge the patch


I just tested this patch and it hurts imx6 (please, see error attached)

I propose to open a BUG in bugzilla and apply the patch only for mx5 boards,
with a #FIXME tag pointing to BUG number.

The error must be fixed properly for 'all boards', however we do have a workaround
Today that may help people.

What do you think?


Daiane

> 

> 

> Daiane

> >

> >

> > On 13 December 2013 13:37, Daiane Angolini

> > <daiane.angolini@freescale.com <mailto:daiane.angolini@freescale.com>>

> > wrote:

> >

> >     On 25-11-2013 09:22, Otavio Salvador wrote:

> >

> >         Hello Janis,

> >

> >         Thanks for sending the patch.

> >

> >         On Mon, Nov 25, 2013 at 8:42 AM, J?nis ?oders

> >         <janis.coders@gmail.com <mailto:janis.coders@gmail.com>> wrote:

> >

> >             vssconfig by default has fb_num configured to 1, but the

> value

> >             must be set to 2 for isink to work properly.

> >

> >             Note, that VSALPHA still must be set manually.

> >

> >             Signed-off-by: J?nis ?oders <janis.coders@gmail.com

> >             <mailto:janis.coders@gmail.com>>

> >

> >

> >         Lauren, please review this patch and ack/nack it. As I am not a

> >         multimedia guy I don't feel confortable in acking it as I don't

> know

> >         the implications for users of this change. Please let me know

> your

> >         thoughts.

> >

> >

> >     Janis, what target did you use for testing the patch?

> >

> >     --

> >     Daiane

> >

> >

> >

> >

> > --

> > Ar cie?u,

> > J?nis ?oders

> 

> 

> --

> Daiane

> 

> _______________________________________________

> meta-freescale mailing list

> meta-freescale@yoctoproject.org

> https://lists.yoctoproject.org/listinfo/meta-freescale
eps1_4.451mbps_30fps_720_L3B2_cut.avi ! decodebin ! mfw_isinkedia/sda1/StarWars_ 
MAX resolution 1024x768
set color key
MFW_GST_ISINK_PLUGIN 3.0.9 build on Jan  7 2014 11:52:33.
Setting pipeline to PAUSED ...
Pipeline is PREROLLING ...
Aiur: 3.0.9 
Core: AVI_PARSER_03.05.07  build on Aug 28 2013 10:17:26
  mime: video/x-msvideo
  file: /usr/lib/imx-mm/parser/lib_avi_parser_arm11_elinux.so.3.1
Content Info:
        URI:
              file:///media/sda1/StarWars_eps1_4.451mbps_30fps_720_L3B2_cut.avi
        Idx File:
              /home/root/.aiur/.media.sda1.StarWars_eps1_4.451mbps_30fps_720_L3B2_cut.avi.aidx
        Seekable  : Yes
        Size(byte): 6394986

Movie Info:
        Seekable  : Yes
        Live      : No
        Duration  : 0:00:16.683333000
        ReadMode  : Track
        Track     : 2

Track 00 [video_000000] Enabled
        Duration: 0:00:16.683333000
        Language: und
        Mime:
              video/x-h264, parsed=(boolean)true, width=(int)720, height=(int)480, framerate=(
              fraction)30000/1001
[INFO]  Product Info: i.MX6Q/D/S
vpudec versions :)
        plugin: 3.0.9
        wrapper: 1.0.40(VPUWRAPPER_ARM_LINUX Build on Jan  7 2014 11:30:13)
        vpulib: 5.4.18
        firmware: 2.3.10.40778
Track 01 [audio_000000] Enabled
        Duration: 0:00:16.650000000
        Language: und
        Mime:
              audio/mpeg, mpegversion=(int)1, framed=(boolean)true, channels=(int)2, rate=(int
              )48000, bitrate=(int)128000
[INFO]  bitstreamMode 1, chromaInterleave 1, mapType 0, tiled2LinearEnable 0
hwbuf allocator zone(520192) created
Beep: 3.0.9 
Core: MP3 decoder Wrapper  build on Aug 29 2013 13:37:52
  mime: audio/mpeg, mpegversion = (int)1
  file: /usr/lib/imx-mm/audio-codec/wrap/lib_mp3d_wrap_arm12_elinux.so.3
CODEC: BLN_MAD-MMCODECS_MP3D_ARM_02.13.00_CORTEX-A8  build on Dec  5 2012 09:45:19.
can not create threadmmxc_sdc_fb mxc_sdc_fb.1: Should use the overlay framebuffer to set the position of the overlay window
fw_gst_isink_setcaps:1489
Pipeline is PREROLLED ...
Setting pipeline to PLAYING ...
VS0 created. in fmt[NV12] win(0,0-720,480:720x480) out win(0,0-mxc_sdc_fb mxc_sdc_fb.1: Should use the overlay framebuffer to set the position of the overlay window
1024,768:1024x768)
New clock: GstSystemClock
vss/mfw_gst_vss_common.c:701 ioctl error, return -1
vss/mfw_gst_vss_common.c:726 ioctl error, return -1
vss/mfw_gst_vss_common.c:593 ioctl error, return -1
set deinterlace mode 0
Got EOS from element "pipeline0".
Execution ended after 16663865002 ns.
Setting pipeline to PAUSED ...
Setting pipeline to READY ...
Setting pipeline to NULL ...
vss/mfw_gst_vss_common.c:760 ioctl error, return -1
VS0 destroyed, force=0!
hwbuf allocator zone(520192) destroied.
[--->FINALIZE aiurdemux
Freeing pipeline ...
[--->FINALIZE isink
Otavio Salvador - Jan. 13, 2014, 1:40 p.m.
On Mon, Jan 13, 2014 at 11:06 AM, Daiane.Angolini@freescale.com <
Daiane.Angolini@freescale.com> wrote:

>
>
> > -----Original Message-----
> > From: meta-freescale-bounces@yoctoproject.org [mailto:meta-freescale-
> > bounces@yoctoproject.org] On Behalf Of Daiane Angolini
> > Sent: Friday, December 13, 2013 2:49 PM
> > To: J?nis ?oders
> > Cc: meta-freescale@yoctoproject.org; Otavio Salvador
> > Subject: Re: [meta-freescale] [meta-fsl-arm][PATCH] gst-fsl-plugin: Fix
> > that enables mfw_isink work by default.
> >
> > On 13-12-2013 14:44, J?nis ?oders wrote:
> > > I used board based on QSB - imx53.
> >
> > I think your patch breaks imx6. Are you available to test it on any imx6
> > board?
> >
> > Otherwise, I will try to test it next week, before we merge the patch
>
> I just tested this patch and it hurts imx6 (please, see error attached)
>
> I propose to open a BUG in bugzilla and apply the patch only for mx5
> boards,
> with a #FIXME tag pointing to BUG number.
>
> The error must be fixed properly for 'all boards', however we do have a
> workaround
> Today that may help people.
>
> What do you think?
>

I agree.
Daiane Angolini - Jan. 14, 2014, 12:20 p.m.
On 13-01-2014 11:40, Otavio Salvador wrote:
>
>
>
> On Mon, Jan 13, 2014 at 11:06 AM, Daiane.Angolini@freescale.com
> <mailto:Daiane.Angolini@freescale.com> <Daiane.Angolini@freescale.com
> <mailto:Daiane.Angolini@freescale.com>> wrote:
>
>
>
>      > -----Original Message-----
>      > From: meta-freescale-bounces@yoctoproject.org
>     <mailto:meta-freescale-bounces@yoctoproject.org>
>     [mailto:meta-freescale- <mailto:meta-freescale->
>      > bounces@yoctoproject.org <mailto:bounces@yoctoproject.org>] On
>     Behalf Of Daiane Angolini
>      > Sent: Friday, December 13, 2013 2:49 PM
>      > To: J?nis ?oders
>      > Cc: meta-freescale@yoctoproject.org
>     <mailto:meta-freescale@yoctoproject.org>; Otavio Salvador
>      > Subject: Re: [meta-freescale] [meta-fsl-arm][PATCH]
>     gst-fsl-plugin: Fix
>      > that enables mfw_isink work by default.
>      >
>      > On 13-12-2013 14:44, J?nis ?oders wrote:
>      > > I used board based on QSB - imx53.
>      >
>      > I think your patch breaks imx6. Are you available to test it on
>     any imx6
>      > board?
>      >
>      > Otherwise, I will try to test it next week, before we merge the patch
>
>     I just tested this patch and it hurts imx6 (please, see error attached)
>
>     I propose to open a BUG in bugzilla and apply the patch only for mx5
>     boards,
>     with a #FIXME tag pointing to BUG number.
>
>     The error must be fixed properly for 'all boards', however we do
>     have a workaround
>     Today that may help people.
>
>     What do you think?
>
>
> I agree.


Janis, do you think it's a good solution to you?
Would you mind to create the BUG and re-send the patch?


Regards,
Daiane

>
> --
> Otavio Salvador                             O.S. Systems
> http://www.ossystems.com.br http://code.ossystems.com.br
> Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
Otavio Salvador - Jan. 28, 2014, 9:36 p.m.
Hello Janis,

On Mon, Nov 25, 2013 at 8:42 AM, J?nis ?oders <janis.coders@gmail.com> wrote:
> vssconfig by default has fb_num configured to 1, but the value
> must be set to 2 for isink to work properly.
>
> Note, that VSALPHA still must be set manually.
>
> Signed-off-by: J?nis ?oders <janis.coders@gmail.com>

Did you create the bugzilla bug about this issue? I have this patch
marked as pending in my side awaiting for the bug number.

In case you didn't, please add the link for the patchwork:

http://patchwork.openembedded.org/patch/62279/

I just marked it as Not Applicable.
Alok Kumar - Jan. 29, 2014, 4:59 p.m.
Hi,

I am using Dora branch and when I changed fb_num as 2, I started getting
lots of errors like below. I am using nitrogen6X.
/usr/share/vssconfig

# vss device definition
# Singel display

# master display
[master]
type = framebuffer
format = RGBP
fb_num = 2
main_fb_num = 0

saved, sync , reboot,


export VSALPHA=1



vss/mfw_gst_vss_common.c:521 ioctl error, return -1
createVideoSurface: error config!
vss/mfw_gst_vss_common.c:521 ioctl error, return -1
createVideoSurface: error config!
..............

Please advise.

Thanks
Alok








On Tue, Jan 28, 2014 at 4:36 PM, Otavio Salvador <otavio@ossystems.com.br>wrote:

> Hello Janis,
>
> On Mon, Nov 25, 2013 at 8:42 AM, J?nis ?oders <janis.coders@gmail.com>
> wrote:
> > vssconfig by default has fb_num configured to 1, but the value
> > must be set to 2 for isink to work properly.
> >
> > Note, that VSALPHA still must be set manually.
> >
> > Signed-off-by: J?nis ?oders <janis.coders@gmail.com>
>
> Did you create the bugzilla bug about this issue? I have this patch
> marked as pending in my side awaiting for the bug number.
>
> In case you didn't, please add the link for the patchwork:
>
> http://patchwork.openembedded.org/patch/62279/
>
> I just marked it as Not Applicable.
>
> --
> Otavio Salvador                             O.S. Systems
> http://www.ossystems.com.br        http://code.ossystems.com.br
> Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
> _______________________________________________
> meta-freescale mailing list
> meta-freescale@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-freescale
>
Eric Nelson - Jan. 29, 2014, 5:20 p.m.
Hi Alok,

On 01/29/2014 09:59 AM, Alok Kumar wrote:
>
> Hi,
>
> I am using Dora branch and when I changed fb_num as 2, I started getting
> lots of errors like below. I am using nitrogen6X.
> /usr/share/vssconfig
>
> # vss device definition
> # Singel display
>
> # master display
> [master]
> type = framebuffer
> format = RGBP
 > fb_num = 2
 > main_fb_num = 0

What are you after here? I think fb_num=2 would point
at a second display.

On i.MX5x, /dev/fb2 was a YUV overlay, but on i.MX6,
this is /dev/fb1

Please advise,


Eric
Alok Kumar - Jan. 29, 2014, 5:36 p.m.
ohh my bad, I thought for i.MX6 we should be using /dev/fb2 for better
performance on mfw_isink. I am sorry I did not read through completely.

mfw_isink is working ok for /dev/fb1 for imx6 (nitrogen6x). video playback
seems ok.


On Wed, Jan 29, 2014 at 12:20 PM, Eric Nelson <
eric.nelson@boundarydevices.com> wrote:

> Hi Alok,
>
> On 01/29/2014 09:59 AM, Alok Kumar wrote:
>
>>
>> Hi,
>>
>> I am using Dora branch and when I changed fb_num as 2, I started getting
>> lots of errors like below. I am using nitrogen6X.
>> /usr/share/vssconfig
>>
>> # vss device definition
>> # Singel display
>>
>> # master display
>> [master]
>> type = framebuffer
>> format = RGBP
>>
> > fb_num = 2
> > main_fb_num = 0
>
> What are you after here? I think fb_num=2 would point
> at a second display.
>
> On i.MX5x, /dev/fb2 was a YUV overlay, but on i.MX6,
> this is /dev/fb1
>
> Please advise,
>
>
> Eric
>

Patch

diff --git a/recipes-multimedia/gstreamer/gst-fsl-plugin/change-default-framebuffer-number-to-2-in-vssconfig.patch b/recipes-multimedia/gstreamer/gst-fsl-plugin/change-default-framebuffer-number-to-2-in-vssconfig.patch
new file mode 100644
index 0000000..cbdbdf7
--- /dev/null
+++ b/recipes-multimedia/gstreamer/gst-fsl-plugin/change-default-framebuffer-number-to-2-in-vssconfig.patch
@@ -0,0 +1,25 @@ 
+From a8c79cad10bc405f261fc23cb51eafa5e8a3e4e2 Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?J=C4=81nis=20=C4=8Coders?= <janis.coders@gmail.com>
+Date: Mon, 25 Nov 2013 10:41:27 +0200
+Subject: [PATCH] change default framebuffer number to 2 in vssconfig
+
+- This change is needed so that mfw_isink would work by default.
+---
+ libs/vss/vssconfig | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/libs/vss/vssconfig b/libs/vss/vssconfig
+index 0bd2a3d..0ff7fd0 100755
+--- a/libs/vss/vssconfig
++++ b/libs/vss/vssconfig
+@@ -5,6 +5,6 @@
+ [master]
+ type = framebuffer
+ format = RGBP
+-fb_num = 1
++fb_num = 2
+ main_fb_num = 0
+ 
+-- 
+1.8.4.4
+
diff --git a/recipes-multimedia/gstreamer/gst-fsl-plugin_3.0.9.bb b/recipes-multimedia/gstreamer/gst-fsl-plugin_3.0.9.bb
index fc9b38f..ef339bf 100644
--- a/recipes-multimedia/gstreamer/gst-fsl-plugin_3.0.9.bb
+++ b/recipes-multimedia/gstreamer/gst-fsl-plugin_3.0.9.bb
@@ -6,7 +6,8 @@  require gst-fsl-plugin.inc
 # FIXME: Inspecting the source code the content is in fact 3.0.9
 SRC_URI = "${FSL_MIRROR}/gst-fsl-plugins-3.10.9-1.0.0.tar.gz \
            file://remove-GST_INFO-in-mfw_gst_utils.h.patch \
-           file://configure.ac-Fix-checking-for-include-headers-in-mul.patch"
+           file://configure.ac-Fix-checking-for-include-headers-in-mul.patch \
+           file://change-default-framebuffer-number-to-2-in-vssconfig.patch"
 
 SRC_URI[md5sum] = "a338a5c25225c765ae5f44af82fe7413"
 SRC_URI[sha256sum] = "e809daa0cd60381f05a79f34a53305a5ee53bfed22192a1cda6d998acc84a6fd"