Patchwork [master,dora,2/2] perf: Disable -Werror flag

login
register
mail settings
Submitter Mark Hatle
Date Nov. 21, 2013, 7:33 a.m.
Message ID <1385019198-24458-3-git-send-email-mark.hatle@windriver.com>
Download mbox | patch
Permalink /patch/62117/
State New
Headers show

Comments

Mark Hatle - Nov. 21, 2013, 7:33 a.m.
From: Konrad Scherer <Konrad.Scherer@windriver.com>

If the sed command does not run before make is invoked, the compile
fails. Defining the environment variable is the proper way to disable
warnings as errors build option and eliminates the race condition.

Signed-off-by: Konrad Scherer <Konrad.Scherer@windriver.com>
Signed-off-by: Randy MacLeod <Randy.MacLeod@windriver.com>
---
 meta/recipes-kernel/perf/perf.bb | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
Konrad Scherer - Nov. 21, 2013, 3:26 p.m.
On 13-11-21 02:33 AM, Mark Hatle wrote:
> From: Konrad Scherer <Konrad.Scherer@windriver.com>
>
> If the sed command does not run before make is invoked, the compile
> fails. Defining the environment variable is the proper way to disable
> warnings as errors build option and eliminates the race condition.
>
> Signed-off-by: Konrad Scherer <Konrad.Scherer@windriver.com>
> Signed-off-by: Randy MacLeod <Randy.MacLeod@windriver.com>
> ---
>   meta/recipes-kernel/perf/perf.bb | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/meta/recipes-kernel/perf/perf.bb b/meta/recipes-kernel/perf/perf.bb
> index 138595d..1b889aa 100644
> --- a/meta/recipes-kernel/perf/perf.bb
> +++ b/meta/recipes-kernel/perf/perf.bb
> @@ -40,6 +40,7 @@ export STAGING_INCDIR
>   export STAGING_LIBDIR
>   export BUILD_SYS
>   export HOST_SYS
> +export WERROR = "0"
>
>   do_populate_lic[depends] += "virtual/kernel:do_populate_sysroot"
>
> @@ -118,10 +119,6 @@ do_install() {
>   	fi
>   }
>
> -do_configure_prepend () {
> -    sed -i 's,-Werror ,,' ${S}/tools/perf/Makefile
> -}
> -

This is will not work for kernels < 3.1. I did submit another patch 
which works for all kernel versions.

Patch

diff --git a/meta/recipes-kernel/perf/perf.bb b/meta/recipes-kernel/perf/perf.bb
index 138595d..1b889aa 100644
--- a/meta/recipes-kernel/perf/perf.bb
+++ b/meta/recipes-kernel/perf/perf.bb
@@ -40,6 +40,7 @@  export STAGING_INCDIR
 export STAGING_LIBDIR
 export BUILD_SYS
 export HOST_SYS
+export WERROR = "0"
 
 do_populate_lic[depends] += "virtual/kernel:do_populate_sysroot"
 
@@ -118,10 +119,6 @@  do_install() {
 	fi
 }
 
-do_configure_prepend () {
-    sed -i 's,-Werror ,,' ${S}/tools/perf/Makefile
-}
-
 python do_package_prepend() {
     bb.data.setVar('PKGV', get_kernelversion('${S}').split("-")[0], d)
 }