Patchwork [meta-networking,2/3] proftpd: Convert proftpd group to system scope

login
register
mail settings
Submitter Mark Hatle
Date Nov. 19, 2013, 9:50 p.m.
Message ID <1384897838-11066-3-git-send-email-mark.hatle@windriver.com>
Download mbox | patch
Permalink /patch/61991/
State Accepted, archived
Headers show

Comments

Mark Hatle - Nov. 19, 2013, 9:50 p.m.
From: Qiang Chen <qiang.chen@windriver.com>

Proftpd is meant to be a system user, not a normal user of the
system so lets pass the correct parameters to the system.
Just add --system param when creating ftp group.

Signed-off-by: Qiang Chen <qiang.chen@windriver.com>
Signed-off-by: Jeff Polk <jeff.polk@windriver.com>
---
 meta-networking/recipes-daemons/proftpd/proftpd_1.3.4b.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Joe MacDonald - Nov. 26, 2013, 2:54 a.m.
Merged this one, the other two are giving me a bit of grief.  I'll check
back soon if it's not a quick fix.

-J.

[[meta-networking][PATCH 2/3] proftpd: Convert proftpd group to system scope] On 13.11.19 (Tue 15:50) Mark Hatle wrote:

> From: Qiang Chen <qiang.chen@windriver.com>
> 
> Proftpd is meant to be a system user, not a normal user of the
> system so lets pass the correct parameters to the system.
> Just add --system param when creating ftp group.
> 
> Signed-off-by: Qiang Chen <qiang.chen@windriver.com>
> Signed-off-by: Jeff Polk <jeff.polk@windriver.com>
> ---
>  meta-networking/recipes-daemons/proftpd/proftpd_1.3.4b.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta-networking/recipes-daemons/proftpd/proftpd_1.3.4b.bb b/meta-networking/recipes-daemons/proftpd/proftpd_1.3.4b.bb
> index 6571b9c..29c3097 100644
> --- a/meta-networking/recipes-daemons/proftpd/proftpd_1.3.4b.bb
> +++ b/meta-networking/recipes-daemons/proftpd/proftpd_1.3.4b.bb
> @@ -60,7 +60,7 @@ INITSCRIPT_NAME = "proftpd"
>  INITSCRIPT_PARAM = "defaults 85 15"
>  
>  USERADD_PACKAGES = "${PN}"
> -GROUPADD_PARAM_${PN} = "${FTPGROUP}"
> +GROUPADD_PARAM_${PN} = "--system ${FTPGROUP}"
>  USERADD_PARAM_${PN} = "--system -g ${FTPGROUP} ${FTPUSER}"
>  
>  FILES_${PN} += "/home/${FTPUSER}"

Patch

diff --git a/meta-networking/recipes-daemons/proftpd/proftpd_1.3.4b.bb b/meta-networking/recipes-daemons/proftpd/proftpd_1.3.4b.bb
index 6571b9c..29c3097 100644
--- a/meta-networking/recipes-daemons/proftpd/proftpd_1.3.4b.bb
+++ b/meta-networking/recipes-daemons/proftpd/proftpd_1.3.4b.bb
@@ -60,7 +60,7 @@  INITSCRIPT_NAME = "proftpd"
 INITSCRIPT_PARAM = "defaults 85 15"
 
 USERADD_PACKAGES = "${PN}"
-GROUPADD_PARAM_${PN} = "${FTPGROUP}"
+GROUPADD_PARAM_${PN} = "--system ${FTPGROUP}"
 USERADD_PARAM_${PN} = "--system -g ${FTPGROUP} ${FTPUSER}"
 
 FILES_${PN} += "/home/${FTPUSER}"