Patchwork [4/7] linux-firmware: Drop allarch

login
register
mail settings
Submitter Martin Jansa
Date Nov. 17, 2013, 1:52 p.m.
Message ID <1384696338-5390-4-git-send-email-Martin.Jansa@gmail.com>
Download mbox | patch
Permalink /patch/61877/
State New
Headers show

Comments

Martin Jansa - Nov. 17, 2013, 1:52 p.m.
* the recipe itself is allarch, but update-alternatives adds dependency on
  virtual/${MLPREFIX}update-alternatives which can be TUNE_PKGARCH opkg
  causing linux-firmware signature to be different for different TUNE_PKGARCHs
  Hash for dependent task opkg_svn.bb.do_populate_sysroot changed from 8d215059308161841a84542dd1dcbf3a to 80b280c741c392cf5b30dd67b61dd56e

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
 meta/recipes-kernel/linux-firmware/linux-firmware_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Richard Purdie - Nov. 18, 2013, 10:57 a.m.
On Sun, 2013-11-17 at 14:52 +0100, Martin Jansa wrote:
> * the recipe itself is allarch, but update-alternatives adds dependency on
>   virtual/${MLPREFIX}update-alternatives which can be TUNE_PKGARCH opkg
>   causing linux-firmware signature to be different for different TUNE_PKGARCHs
>   Hash for dependent task opkg_svn.bb.do_populate_sysroot changed from 8d215059308161841a84542dd1dcbf3a to 80b280c741c392cf5b30dd67b61dd56e
> 
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> ---
>  meta/recipes-kernel/linux-firmware/linux-firmware_git.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-kernel/linux-firmware/linux-firmware_git.bb b/meta/recipes-kernel/linux-firmware/linux-firmware_git.bb
> index e3a099a..ebb9c81 100644
> --- a/meta/recipes-kernel/linux-firmware/linux-firmware_git.bb
> +++ b/meta/recipes-kernel/linux-firmware/linux-firmware_git.bb
> @@ -32,7 +32,7 @@ SRC_URI = "git://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware
>  
>  S = "${WORKDIR}/git"
>  
> -inherit allarch update-alternatives
> +inherit update-alternatives

I think this is one case where we should whitelist update-alternatives
as being ABI/API safe instead. There is no point in building the
firmware multiple times.

Cheers,

Richard

Patch

diff --git a/meta/recipes-kernel/linux-firmware/linux-firmware_git.bb b/meta/recipes-kernel/linux-firmware/linux-firmware_git.bb
index e3a099a..ebb9c81 100644
--- a/meta/recipes-kernel/linux-firmware/linux-firmware_git.bb
+++ b/meta/recipes-kernel/linux-firmware/linux-firmware_git.bb
@@ -32,7 +32,7 @@  SRC_URI = "git://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware
 
 S = "${WORKDIR}/git"
 
-inherit allarch update-alternatives
+inherit update-alternatives
 
 do_compile() {
 	: