Patchwork [2/7] packagegroup-core-boot: Drop build-time dependency on virtual/kernel

login
register
mail settings
Submitter Martin Jansa
Date Nov. 17, 2013, 1:52 p.m.
Message ID <1384696338-5390-2-git-send-email-Martin.Jansa@gmail.com>
Download mbox | patch
Permalink /patch/61871/
State Accepted
Commit bba44c613f12079081fb0a20cbd2e99adc5276c3
Headers show

Comments

Martin Jansa - Nov. 17, 2013, 1:52 p.m.
* because kernel isn't needed to build packagegroup and building
  it doesn't influence if it's included in image or not.

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
 meta/recipes-core/packagegroups/packagegroup-core-boot.bb | 1 -
 1 file changed, 1 deletion(-)
Qi.Chen@windriver.com - Nov. 20, 2013, 5:57 a.m.
On 11/17/2013 09:52 PM, Martin Jansa wrote:
> * because kernel isn't needed to build packagegroup and building
>    it doesn't influence if it's included in image or not.
>
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> ---
>   meta/recipes-core/packagegroups/packagegroup-core-boot.bb | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/meta/recipes-core/packagegroups/packagegroup-core-boot.bb b/meta/recipes-core/packagegroups/packagegroup-core-boot.bb
> index 486385a..5455899 100644
> --- a/meta/recipes-core/packagegroups/packagegroup-core-boot.bb
> +++ b/meta/recipes-core/packagegroups/packagegroup-core-boot.bb
> @@ -5,7 +5,6 @@
>   SUMMARY = "Minimal boot requirements"
>   DESCRIPTION = "The minimal set of packages required to boot the system"
>   LICENSE = "MIT"
> -DEPENDS = "virtual/kernel"
>   PR = "r11"
>   
>   inherit packagegroup

What about adding this dependency in image.bbclass? Otherwise, the 
kernel will not get built if it's not pulled in by other packages like 
v86d. For example, if we build core-image-minimal for qemumips, the 
kernel is not built by default and we have to `bitbake linux-yocto' 
before we can use `runqemu' to start target.

Best Regards,
Chen Qi

Patch

diff --git a/meta/recipes-core/packagegroups/packagegroup-core-boot.bb b/meta/recipes-core/packagegroups/packagegroup-core-boot.bb
index 486385a..5455899 100644
--- a/meta/recipes-core/packagegroups/packagegroup-core-boot.bb
+++ b/meta/recipes-core/packagegroups/packagegroup-core-boot.bb
@@ -5,7 +5,6 @@ 
 SUMMARY = "Minimal boot requirements"
 DESCRIPTION = "The minimal set of packages required to boot the system"
 LICENSE = "MIT"
-DEPENDS = "virtual/kernel"
 PR = "r11"
 
 inherit packagegroup