Patchwork sysvinit: unmount the psplash lazyily

login
register
mail settings
Submitter Saul Wold
Date Nov. 15, 2013, 1:52 a.m.
Message ID <1384480333-7671-1-git-send-email-sgw@linux.intel.com>
Download mbox | patch
Permalink /patch/61741/
State New
Headers show

Comments

Saul Wold - Nov. 15, 2013, 1:52 a.m.
There is an race condition where psplash is not quite exited before the unmount occurs
causing a umount: /mnt/.psplash: target is busy message to appear, it's ok to lazyily
unmount and not get this message

[YOCTO #5244]

Signed-off-by: Saul Wold <sgw@linux.intel.com>
---
 meta/recipes-core/sysvinit/sysvinit/rc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Otavio Salvador - Nov. 15, 2013, 1:29 p.m.
On Thu, Nov 14, 2013 at 11:52 PM, Saul Wold <sgw@linux.intel.com> wrote:
> There is an race condition where psplash is not quite exited before the unmount occurs
> causing a umount: /mnt/.psplash: target is busy message to appear, it's ok to lazyily
> unmount and not get this message
>
> [YOCTO #5244]
>
> Signed-off-by: Saul Wold <sgw@linux.intel.com>

Agreed.

Acked-by: Otavio Salvador <otavio@ossystems.com.br>

Robert, please consider it to be included in dora. This is a simple
and nice bugfix.
Robert Yang - Nov. 18, 2013, 12:59 p.m.
On 11/15/2013 09:29 PM, Otavio Salvador wrote:
> On Thu, Nov 14, 2013 at 11:52 PM, Saul Wold <sgw@linux.intel.com> wrote:
>> There is an race condition where psplash is not quite exited before the unmount occurs
>> causing a umount: /mnt/.psplash: target is busy message to appear, it's ok to lazyily
>> unmount and not get this message
>>
>> [YOCTO #5244]
>>
>> Signed-off-by: Saul Wold <sgw@linux.intel.com>
>
> Agreed.
>
> Acked-by: Otavio Salvador <otavio@ossystems.com.br>
>
> Robert, please consider it to be included in dora. This is a simple
> and nice bugfix.
>

Hi Otavio,

Thanks, I will try to add it in dora.

// Robert

Patch

diff --git a/meta/recipes-core/sysvinit/sysvinit/rc b/meta/recipes-core/sysvinit/sysvinit/rc
index 655a0b0..1f400d9 100755
--- a/meta/recipes-core/sysvinit/sysvinit/rc
+++ b/meta/recipes-core/sysvinit/sysvinit/rc
@@ -174,6 +174,6 @@  startup() {
 if [ "x$runlevel" != "xS" ] && [ ! -x /etc/rc${runlevel}.d/S??xserver-nodm ]; then
     if type psplash-write >/dev/null 2>&1; then
         TMPDIR=/mnt/.psplash psplash-write "QUIT" || true
-    	umount /mnt/.psplash
+    	umount -l /mnt/.psplash
     fi
 fi