Patchwork [2/2] bluez4: Fix no moudle named gi.repository and GObject for simpel-agent

login
register
mail settings
Submitter Zhong Hongbo
Date Nov. 13, 2013, 10:08 a.m.
Message ID <1384337335-32231-3-git-send-email-hongbo.zhong@windriver.com>
Download mbox | patch
Permalink /patch/61613/
State New
Headers show

Comments

Zhong Hongbo - Nov. 13, 2013, 10:08 a.m.
From: Zhong Hongbo <hongbo.zhong@windriver.com>

Signed-off-by: Zhong Hongbo <hongbo.zhong@windriver.com>
---
 ...x-no-module-name-GObject-for-simple-agent.patch |   25 ++++++++++++++++++++
 meta/recipes-connectivity/bluez/bluez4_4.101.bb    |    1 +
 2 files changed, 26 insertions(+)
 create mode 100644 meta/recipes-connectivity/bluez/bluez4-4.101/fix-no-module-name-GObject-for-simple-agent.patch
Ross Burton - Nov. 13, 2013, 12:30 p.m.
On 13 November 2013 10:08, Zhong Hongbo <hongbo.zhong@windriver.com> wrote:
> +++ b/meta/recipes-connectivity/bluez/bluez4-4.101/fix-no-module-name-GObject-for-simple-agent.patch
> @@ -0,0 +1,25 @@
> +Fix No module name gi.repository and GObject for simple-agent
> +
> +Signed-off-by: Zhong Hongbo <hongbo.zhong@windriver.com>

Patch needs an Upstream-Status ("Inappropriate [revert]" would be
suitable), and please rename the patch/comment to something more
accurate along the lines of "use legacy pygobject instead of
gobject-introspection".

Ross
Zhong Hongbo - Nov. 14, 2013, 3:30 a.m.
On 11/13/2013 08:30 PM, Burton, Ross wrote:
> On 13 November 2013 10:08, Zhong Hongbo <hongbo.zhong@windriver.com> wrote:
>> +++ b/meta/recipes-connectivity/bluez/bluez4-4.101/fix-no-module-name-GObject-for-simple-agent.patch
>> @@ -0,0 +1,25 @@
>> +Fix No module name gi.repository and GObject for simple-agent
>> +
>> +Signed-off-by: Zhong Hongbo <hongbo.zhong@windriver.com>
> Patch needs an Upstream-Status ("Inappropriate [revert]" would be
> suitable), and please rename the patch/comment to something more
> accurate along the lines of "use legacy pygobject instead of
> gobject-introspection".
Sorry, This is my first RR. I will do it in the next RR.

Thanks,
Hongbo
>
> Ross
>
>
Zhong Hongbo - Nov. 14, 2013, 10:47 a.m.
On 11/13/2013 08:30 PM, Burton, Ross wrote:
> On 13 November 2013 10:08, Zhong Hongbo <hongbo.zhong@windriver.com> wrote:
>> +++ b/meta/recipes-connectivity/bluez/bluez4-4.101/fix-no-module-name-GObject-for-simple-agent.patch
>> @@ -0,0 +1,25 @@
>> +Fix No module name gi.repository and GObject for simple-agent
>> +
>> +Signed-off-by: Zhong Hongbo <hongbo.zhong@windriver.com>
> Patch needs an Upstream-Status ("Inappropriate [revert]" would be
> suitable), and please rename the patch/comment to something more
> accurate along the lines of "use legacy pygobject instead of
> gobject-introspection".
This patch do not in upstream. I do the change  and test it in my x86_64 
platform.
What status should fill in Upstream-Status.

Thanks,
Hongbo
>
> Ross
>
>
Ross Burton - Nov. 14, 2013, 10:53 a.m.
On 14 November 2013 10:47, Zhong Hongbo <hongbo.zhong@windriver.com> wrote:
> What status should fill in Upstream-Status.

As I said, "Inappropriate" is suitable here.

Ross

Patch

diff --git a/meta/recipes-connectivity/bluez/bluez4-4.101/fix-no-module-name-GObject-for-simple-agent.patch b/meta/recipes-connectivity/bluez/bluez4-4.101/fix-no-module-name-GObject-for-simple-agent.patch
new file mode 100644
index 0000000..245250c
--- /dev/null
+++ b/meta/recipes-connectivity/bluez/bluez4-4.101/fix-no-module-name-GObject-for-simple-agent.patch
@@ -0,0 +1,25 @@ 
+Fix No module name gi.repository and GObject for simple-agent
+
+Signed-off-by: Zhong Hongbo <hongbo.zhong@windriver.com>
+---
+diff -Nurd bluez-4.101.orig/test/simple-agent bluez-4.101/test/simple-agent
+--- bluez-4.101.orig/test/simple-agent	2013-11-13 17:14:08.138118159 +0800
++++ bluez-4.101/test/simple-agent	2013-11-13 17:14:29.034118107 +0800
+@@ -2,7 +2,7 @@
+ 
+ from __future__ import absolute_import, print_function, unicode_literals
+ 
+-from gi.repository import GObject
++import gobject
+ 
+ import sys
+ import dbus
+@@ -122,7 +122,7 @@
+ 	path = "/test/agent"
+ 	agent = Agent(bus, path)
+ 
+-	mainloop = GObject.MainLoop()
++	mainloop = gobject.MainLoop()
+ 
+ 	if len(args) > 1:
+ 		if len(args) > 2:
diff --git a/meta/recipes-connectivity/bluez/bluez4_4.101.bb b/meta/recipes-connectivity/bluez/bluez4_4.101.bb
index c3444ab..03e0964 100644
--- a/meta/recipes-connectivity/bluez/bluez4_4.101.bb
+++ b/meta/recipes-connectivity/bluez/bluez4_4.101.bb
@@ -7,6 +7,7 @@  SRC_URI += "file://bluetooth.conf \
             file://fix-udev-paths.patch \
             file://obsolete_automake_macros.patch \
             file://network-fix-network-Connect-method-parameters.patch \
+            file://fix-no-module-name-GObject-for-simple-agent.patch \
 "
 
 SRC_URI[md5sum] = "fb42cb7038c380eb0e2fa208987c96ad"