Patchwork [1/1] lsb: update directory of install_initd and remove_initd

login
register
mail settings
Submitter Kang Kai
Date Nov. 13, 2013, 8:27 a.m.
Message ID <bb068bc66bcdbf96dd84e5cd18e1765b9a32f2cc.1384331128.git.kai.kang@windriver.com>
Download mbox | patch
Permalink /patch/61603/
State New
Headers show

Comments

Kang Kai - Nov. 13, 2013, 8:27 a.m.
According to LSB specification:

http://refspecs.linuxfoundation.org/LSB_4.1.0/LSB-Core-generic/LSB-Core-generic/installinitd.html
http://refspecs.linuxfoundation.org/LSB_4.1.0/LSB-Core-generic/LSB-Core-generic/removeinitd.html

commands install_initd and remove_initd should under directory /usr/lib/lsb/.

lsb recipe creates these commands under directory ${libdir} which may
expand to /usr/lib64 when multilib is enabled on qemux86-64. That will
cause LSB command check for install_initd and remove_initd fail. So
correct it.

Signed-off-by: Kai Kang <kai.kang@windriver.com>
---
 meta/recipes-extended/lsb/lsb_4.1.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Kang Kai - Nov. 18, 2013, 5:26 a.m.
On 2013?11?13? 16:27, Kai Kang wrote:

ping?

> According to LSB specification:
>
> http://refspecs.linuxfoundation.org/LSB_4.1.0/LSB-Core-generic/LSB-Core-generic/installinitd.html
> http://refspecs.linuxfoundation.org/LSB_4.1.0/LSB-Core-generic/LSB-Core-generic/removeinitd.html
>
> commands install_initd and remove_initd should under directory /usr/lib/lsb/.
>
> lsb recipe creates these commands under directory ${libdir} which may
> expand to /usr/lib64 when multilib is enabled on qemux86-64. That will
> cause LSB command check for install_initd and remove_initd fail. So
> correct it.
>
> Signed-off-by: Kai Kang <kai.kang@windriver.com>
> ---
>   meta/recipes-extended/lsb/lsb_4.1.bb | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-extended/lsb/lsb_4.1.bb b/meta/recipes-extended/lsb/lsb_4.1.bb
> index c80ff59..8105e59 100644
> --- a/meta/recipes-extended/lsb/lsb_4.1.bb
> +++ b/meta/recipes-extended/lsb/lsb_4.1.bb
> @@ -79,8 +79,8 @@ do_install_append(){
>   
>          # creat links for LSB test
>          install -d ${D}/${libdir}/lsb
> -       ln -sf ${sbindir}/chkconfig ${D}/${libdir}/lsb/install_initd
> -       ln -sf ${sbindir}/chkconfig ${D}/${libdir}/lsb/remove_initd
> +       ln -sf ${sbindir}/chkconfig ${D}/usr/lib/lsb/install_initd
> +       ln -sf ${sbindir}/chkconfig ${D}/usr/lib/lsb/remove_initd
>          ln -sf ${sbindir}/sendmail ${D}/${libdir}/sendmail
>   
>          if [ "${TARGET_ARCH}" = "x86_64" ];then
Saul Wold - Dec. 10, 2013, 7:40 p.m.
On 11/13/2013 12:27 AM, Kai Kang wrote:
> According to LSB specification:
>
> http://refspecs.linuxfoundation.org/LSB_4.1.0/LSB-Core-generic/LSB-Core-generic/installinitd.html
> http://refspecs.linuxfoundation.org/LSB_4.1.0/LSB-Core-generic/LSB-Core-generic/removeinitd.html
>
> commands install_initd and remove_initd should under directory /usr/lib/lsb/.
>
> lsb recipe creates these commands under directory ${libdir} which may
> expand to /usr/lib64 when multilib is enabled on qemux86-64. That will
> cause LSB command check for install_initd and remove_initd fail. So
> correct it.
>
> Signed-off-by: Kai Kang <kai.kang@windriver.com>
> ---
>   meta/recipes-extended/lsb/lsb_4.1.bb | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-extended/lsb/lsb_4.1.bb b/meta/recipes-extended/lsb/lsb_4.1.bb
> index c80ff59..8105e59 100644
> --- a/meta/recipes-extended/lsb/lsb_4.1.bb
> +++ b/meta/recipes-extended/lsb/lsb_4.1.bb
> @@ -79,8 +79,8 @@ do_install_append(){
>
>          # creat links for LSB test
>          install -d ${D}/${libdir}/lsb
> -       ln -sf ${sbindir}/chkconfig ${D}/${libdir}/lsb/install_initd
> -       ln -sf ${sbindir}/chkconfig ${D}/${libdir}/lsb/remove_initd
> +       ln -sf ${sbindir}/chkconfig ${D}/usr/lib/lsb/install_initd
> +       ln -sf ${sbindir}/chkconfig ${D}/usr/lib/lsb/remove_initd
It's arguable that this should be ${prefix}/lib since there is a 
possibly case of libdir not being /usr/lib or /usr/lib64.  It also goes 
to LSB explictly requires /usr/lib/lsb so for an LSB machine /usr/lib 
will aways exist.

I will put this in the next C-Pull.

Sau!

>          ln -sf ${sbindir}/sendmail ${D}/${libdir}/sendmail
>
>          if [ "${TARGET_ARCH}" = "x86_64" ];then
>
Kang Kai - Dec. 11, 2013, 1:54 a.m.
On 2013?12?11? 03:40, Saul Wold wrote:
> On 11/13/2013 12:27 AM, Kai Kang wrote:
>> According to LSB specification:
>>
>> http://refspecs.linuxfoundation.org/LSB_4.1.0/LSB-Core-generic/LSB-Core-generic/installinitd.html
>>
>> http://refspecs.linuxfoundation.org/LSB_4.1.0/LSB-Core-generic/LSB-Core-generic/removeinitd.html
>>
>>
>> commands install_initd and remove_initd should under directory
>> /usr/lib/lsb/.
>>
>> lsb recipe creates these commands under directory ${libdir} which may
>> expand to /usr/lib64 when multilib is enabled on qemux86-64. That will
>> cause LSB command check for install_initd and remove_initd fail. So
>> correct it.
>>
>> Signed-off-by: Kai Kang <kai.kang@windriver.com>
>> ---
>> meta/recipes-extended/lsb/lsb_4.1.bb | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta/recipes-extended/lsb/lsb_4.1.bb
>> b/meta/recipes-extended/lsb/lsb_4.1.bb
>> index c80ff59..8105e59 100644
>> --- a/meta/recipes-extended/lsb/lsb_4.1.bb
>> +++ b/meta/recipes-extended/lsb/lsb_4.1.bb
>> @@ -79,8 +79,8 @@ do_install_append(){
>>
>> # creat links for LSB test
>> install -d ${D}/${libdir}/lsb
>> - ln -sf ${sbindir}/chkconfig ${D}/${libdir}/lsb/install_initd
>> - ln -sf ${sbindir}/chkconfig ${D}/${libdir}/lsb/remove_initd
>> + ln -sf ${sbindir}/chkconfig ${D}/usr/lib/lsb/install_initd
>> + ln -sf ${sbindir}/chkconfig ${D}/usr/lib/lsb/remove_initd
> It's arguable that this should be ${prefix}/lib since there is a
> possibly case of libdir not being /usr/lib or /usr/lib64. It also goes
> to LSB explictly requires /usr/lib/lsb so for an LSB machine /usr/lib
> will aways exist.
>
> I will put this in the next C-Pull.

Hi Saul,

Sorry, please drop it for now and there is something wrong with this patch.
I intended to send a V2 version and with other changes for lsbtest.

Thanks,
Kai

>
> Sau!
>
>> ln -sf ${sbindir}/sendmail ${D}/${libdir}/sendmail
>>
>> if [ "${TARGET_ARCH}" = "x86_64" ];then
>>
>
>

Patch

diff --git a/meta/recipes-extended/lsb/lsb_4.1.bb b/meta/recipes-extended/lsb/lsb_4.1.bb
index c80ff59..8105e59 100644
--- a/meta/recipes-extended/lsb/lsb_4.1.bb
+++ b/meta/recipes-extended/lsb/lsb_4.1.bb
@@ -79,8 +79,8 @@  do_install_append(){
 
        # creat links for LSB test
        install -d ${D}/${libdir}/lsb
-       ln -sf ${sbindir}/chkconfig ${D}/${libdir}/lsb/install_initd
-       ln -sf ${sbindir}/chkconfig ${D}/${libdir}/lsb/remove_initd
+       ln -sf ${sbindir}/chkconfig ${D}/usr/lib/lsb/install_initd
+       ln -sf ${sbindir}/chkconfig ${D}/usr/lib/lsb/remove_initd
        ln -sf ${sbindir}/sendmail ${D}/${libdir}/sendmail
 
        if [ "${TARGET_ARCH}" = "x86_64" ];then