Patchwork [0/1] udev: remove libudev-dbg and libgudev-dbg

login
register
mail settings
Submitter wenzong.fan@windriver.com
Date Nov. 11, 2013, 10:10 a.m.
Message ID <cover.1384164392.git.wenzong.fan@windriver.com>
Download mbox
Permalink /patch/61415/
State New
Headers show

Pull-request

git://git.pokylinux.org/poky-contrib wenzong/udev-remove-dbg

Comments

wenzong.fan@windriver.com - Nov. 11, 2013, 10:10 a.m.
From: Wenzong Fan <wenzong.fan@windriver.com>

We don't support multiple -dbg packages, so just remove the libudev-dbg,
libgudev-dbg and put all debug stuffs to 'udev-dbg'.

The following changes since commit 4fdc3d77d4a875b7236536bf78849a4d1f6a7449:

  kbd: Fix stdarg related errors on uclibc (2013-11-08 17:31:36 +0000)

are available in the git repository at:

  git://git.pokylinux.org/poky-contrib wenzong/udev-remove-dbg
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=wenzong/udev-remove-dbg

Wenzong Fan (1):
  udev: remove libudev-dbg and libgudev-dbg

 meta/recipes-core/udev/udev.inc |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
Mark Hatle - Nov. 11, 2013, 4:05 p.m.
On 11/11/13, 4:10 AM, wenzong.fan@windriver.com wrote:
> From: Wenzong Fan <wenzong.fan@windriver.com>
>
> We don't support multiple -dbg packages, so just remove the libudev-dbg,
> libgudev-dbg and put all debug stuffs to 'udev-dbg'.

I'm a bit confused, we do support package that want to provide multiple -dbg 
files to generate them.

This way large recipes that provide lots of different bits of functionality can 
no only segment the packages they create, but keep the side of the -dbg 
information reasonable as well.  (It's not all that commonly used, but it does 
work with the IMAGE_FEATURES 'dbg-pkgs'.)

What issue was being solved by combining the two items back into one?

--Mark

> The following changes since commit 4fdc3d77d4a875b7236536bf78849a4d1f6a7449:
>
>    kbd: Fix stdarg related errors on uclibc (2013-11-08 17:31:36 +0000)
>
> are available in the git repository at:
>
>    git://git.pokylinux.org/poky-contrib wenzong/udev-remove-dbg
>    http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=wenzong/udev-remove-dbg
>
> Wenzong Fan (1):
>    udev: remove libudev-dbg and libgudev-dbg
>
>   meta/recipes-core/udev/udev.inc |    6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
>
wenzong.fan@windriver.com - Nov. 12, 2013, 1:53 a.m.
On 11/12/2013 12:05 AM, Mark Hatle wrote:
> On 11/11/13, 4:10 AM, wenzong.fan@windriver.com wrote:
>> From: Wenzong Fan <wenzong.fan@windriver.com>
>>
>> We don't support multiple -dbg packages, so just remove the libudev-dbg,
>> libgudev-dbg and put all debug stuffs to 'udev-dbg'.
>
> I'm a bit confused, we do support package that want to provide multiple
> -dbg files to generate them.
>
> This way large recipes that provide lots of different bits of
> functionality can no only segment the packages they create, but keep the
> side of the -dbg information reasonable as well.  (It's not all that
> commonly used, but it does work with the IMAGE_FEATURES 'dbg-pkgs'.)
>
> What issue was being solved by combining the two items back into one?

Hi Mark,

This is an updated patch for fixing the 'source codes <--> -dbg 
packages' (i.e. which src should be shipped to which -dbg package), 
details please refer to another thread about:

Subject: udev: ship source files to related dbg package

As Richard mentioned:

"We don't support multiple -dbg packages and this looks like an error." 
- (the udev have there -dbg packages: libudev-dbg/libgudev-dbg/udev-dbg)

If I was wrong please correct me.

Thanks
Wenzong

>
> --Mark
>
>> The following changes since commit
>> 4fdc3d77d4a875b7236536bf78849a4d1f6a7449:
>>
>>    kbd: Fix stdarg related errors on uclibc (2013-11-08 17:31:36 +0000)
>>
>> are available in the git repository at:
>>
>>    git://git.pokylinux.org/poky-contrib wenzong/udev-remove-dbg
>>
>> http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=wenzong/udev-remove-dbg
>>
>>
>> Wenzong Fan (1):
>>    udev: remove libudev-dbg and libgudev-dbg
>>
>>   meta/recipes-core/udev/udev.inc |    6 ++----
>>   1 file changed, 2 insertions(+), 4 deletions(-)
>>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
Richard Purdie - Nov. 12, 2013, 7:47 a.m.
On Mon, 2013-11-11 at 10:05 -0600, Mark Hatle wrote:
> On 11/11/13, 4:10 AM, wenzong.fan@windriver.com wrote:
> > From: Wenzong Fan <wenzong.fan@windriver.com>
> >
> > We don't support multiple -dbg packages, so just remove the libudev-dbg,
> > libgudev-dbg and put all debug stuffs to 'udev-dbg'.
> 
> I'm a bit confused, we do support package that want to provide multiple -dbg 
> files to generate them.

No, we do not. We don't support multiple -dev packages either. Yes
packages can generate them but the system does not correctly handle them
and never has.

Cheers,

Richard
wenzong.fan@windriver.com - Nov. 14, 2013, 2:56 a.m.
On 11/12/2013 03:47 PM, Richard Purdie wrote:
> On Mon, 2013-11-11 at 10:05 -0600, Mark Hatle wrote:
>> On 11/11/13, 4:10 AM, wenzong.fan@windriver.com wrote:
>>> From: Wenzong Fan <wenzong.fan@windriver.com>
>>>
>>> We don't support multiple -dbg packages, so just remove the libudev-dbg,
>>> libgudev-dbg and put all debug stuffs to 'udev-dbg'.
>>
>> I'm a bit confused, we do support package that want to provide multiple -dbg
>> files to generate them.
>
> No, we do not. We don't support multiple -dev packages either. Yes
> packages can generate them but the system does not correctly handle them
> and never has.

Ok, a V2 patch was sent for removing extra -dev/-dbg packages for udev.

Thanks
Wenzong

>
> Cheers,
>
> Richard
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
>