Patchwork [1/1] linuxdoc-tools: add dependency on texinfo

login
register
mail settings
Submitter Joe Slater
Date Nov. 8, 2013, 9:49 p.m.
Message ID <1383947372-20075-1-git-send-email-jslater@windriver.com>
Download mbox | patch
Permalink /patch/61345/
State New
Headers show

Comments

Joe Slater - Nov. 8, 2013, 9:49 p.m.
We do run makeinfo, so we want to DEPEND on texinfo-native.

Signed-off-by: Joe Slater <jslater@windriver.com>
---
 .../linuxdoc-tools/linuxdoc-tools-native_0.9.69.bb |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Richard Purdie - Nov. 12, 2013, 10:47 a.m.
On Fri, 2013-11-08 at 13:49 -0800, Joe Slater wrote:
> We do run makeinfo, so we want to DEPEND on texinfo-native.

makeinfo is checked for by the sanity tests so we require it be present?

Cheers,

Richard

> Signed-off-by: Joe Slater <jslater@windriver.com>
> ---
>  .../linuxdoc-tools/linuxdoc-tools-native_0.9.69.bb |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/meta/recipes-devtools/linuxdoc-tools/linuxdoc-tools-native_0.9.69.bb b/meta/recipes-devtools/linuxdoc-tools/linuxdoc-tools-native_0.9.69.bb
> index ba9c72e..d8122e6 100644
> --- a/meta/recipes-devtools/linuxdoc-tools/linuxdoc-tools-native_0.9.69.bb
> +++ b/meta/recipes-devtools/linuxdoc-tools/linuxdoc-tools-native_0.9.69.bb
> @@ -4,7 +4,7 @@ HOMEPAGE = "http://packages.debian.org/linuxdoc-tools"
>  LICENSE = "GPLv3+"
>  LIC_FILES_CHKSUM = "file://COPYING;md5=077ef64ec3ac257fb0d786531cf26931"
>  
> -DEPENDS = "groff-native openjade-native"
> +DEPENDS = "groff-native openjade-native texinfo-native"
>  
> 
>  SRC_URI = "${DEBIAN_MIRROR}/main/l/linuxdoc-tools/linuxdoc-tools_${PV}.orig.tar.gz \
Slater, Joseph - Nov. 12, 2013, 7:02 p.m.
I believe we will use the host makeinfo, if that exists, so we
won't automatically build texinfo-native.  But, if we are building
it at the same time we are trying to run makeinfo, we might get
"our" version instead of the host's, and our version might not be
fully installed.  At least, that looks like what happened for the
build failure this patch attempts to fix.

Joe


> -----Original Message-----
> From: Richard Purdie [mailto:richard.purdie@linuxfoundation.org]
> Sent: Tuesday, November 12, 2013 2:47 AM
> To: Slater, Joseph
> Cc: openembedded-core@lists.openembedded.org
> Subject: Re: [OE-core] [PATCH 1/1] linuxdoc-tools: add dependency on texinfo
> 
> On Fri, 2013-11-08 at 13:49 -0800, Joe Slater wrote:
> > We do run makeinfo, so we want to DEPEND on texinfo-native.
> 
> makeinfo is checked for by the sanity tests so we require it be present?
> 
> Cheers,
> 
> Richard
> 
> > Signed-off-by: Joe Slater <jslater@windriver.com>
> > ---
> >  .../linuxdoc-tools/linuxdoc-tools-native_0.9.69.bb |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/meta/recipes-devtools/linuxdoc-tools/linuxdoc-tools-native_0.9.69.bb
> b/meta/recipes-devtools/linuxdoc-tools/linuxdoc-tools-native_0.9.69.bb
> > index ba9c72e..d8122e6 100644
> > --- a/meta/recipes-devtools/linuxdoc-tools/linuxdoc-tools-native_0.9.69.bb
> > +++ b/meta/recipes-devtools/linuxdoc-tools/linuxdoc-tools-native_0.9.69.bb
> > @@ -4,7 +4,7 @@ HOMEPAGE = "http://packages.debian.org/linuxdoc-tools"
> >  LICENSE = "GPLv3+"
> >  LIC_FILES_CHKSUM = "file://COPYING;md5=077ef64ec3ac257fb0d786531cf26931"
> >
> > -DEPENDS = "groff-native openjade-native"
> > +DEPENDS = "groff-native openjade-native texinfo-native"
> >
> >
> >  SRC_URI = "${DEBIAN_MIRROR}/main/l/linuxdoc-tools/linuxdoc-tools_${PV}.orig.tar.gz \
>
Richard Purdie - Nov. 12, 2013, 7:45 p.m.
On Tue, 2013-11-12 at 19:02 +0000, Slater, Joseph wrote:
> I believe we will use the host makeinfo, if that exists, so we
> won't automatically build texinfo-native.  But, if we are building
> it at the same time we are trying to run makeinfo, we might get
> "our" version instead of the host's, and our version might not be
> fully installed.  At least, that looks like what happened for the
> build failure this patch attempts to fix.

It would help to have that in the commit message.

Equally, does this really solve the problem or does it just move it
elsewhere as other applications probably use makeinfo too? :/

Cheers,

Richard
Slater, Joseph - Nov. 12, 2013, 8:46 p.m.
> -----Original Message-----
> From: Richard Purdie [mailto:richard.purdie@linuxfoundation.org]
> Sent: Tuesday, November 12, 2013 11:45 AM
> To: Slater, Joseph
> Cc: openembedded-core@lists.openembedded.org
> Subject: Re: [OE-core] [PATCH 1/1] linuxdoc-tools: add dependency on texinfo
> 
> On Tue, 2013-11-12 at 19:02 +0000, Slater, Joseph wrote:
> > I believe we will use the host makeinfo, if that exists, so we
> > won't automatically build texinfo-native.  But, if we are building
> > it at the same time we are trying to run makeinfo, we might get
> > "our" version instead of the host's, and our version might not be
> > fully installed.  At least, that looks like what happened for the
> > build failure this patch attempts to fix.
> 
> It would help to have that in the commit message.
> 
> Equally, does this really solve the problem or does it just move it
> elsewhere as other applications probably use makeinfo too? :/

It does just move it elsewhere.  I don't know if texinfo would be basic
enough to force it to build early (I'm not sure how to do that), or if
we just expect packages that need it to depend on it.

Joe


> 
> Cheers,
> 
> Richard
Richard Purdie - Nov. 12, 2013, 9:27 p.m.
On Tue, 2013-11-12 at 20:46 +0000, Slater, Joseph wrote:
> 
> > -----Original Message-----
> > From: Richard Purdie [mailto:richard.purdie@linuxfoundation.org]
> > Sent: Tuesday, November 12, 2013 11:45 AM
> > To: Slater, Joseph
> > Cc: openembedded-core@lists.openembedded.org
> > Subject: Re: [OE-core] [PATCH 1/1] linuxdoc-tools: add dependency on texinfo
> > 
> > On Tue, 2013-11-12 at 19:02 +0000, Slater, Joseph wrote:
> > > I believe we will use the host makeinfo, if that exists, so we
> > > won't automatically build texinfo-native.  But, if we are building
> > > it at the same time we are trying to run makeinfo, we might get
> > > "our" version instead of the host's, and our version might not be
> > > fully installed.  At least, that looks like what happened for the
> > > build failure this patch attempts to fix.
> > 
> > It would help to have that in the commit message.
> > 
> > Equally, does this really solve the problem or does it just move it
> > elsewhere as other applications probably use makeinfo too? :/
> 
> It does just move it elsewhere.  I don't know if texinfo would be basic
> enough to force it to build early (I'm not sure how to do that), or if
> we just expect packages that need it to depend on it.

Could we simply not install the makeinfo binary in texinfo-native and
always use the one from the host?

Cheers,

Richard

Patch

diff --git a/meta/recipes-devtools/linuxdoc-tools/linuxdoc-tools-native_0.9.69.bb b/meta/recipes-devtools/linuxdoc-tools/linuxdoc-tools-native_0.9.69.bb
index ba9c72e..d8122e6 100644
--- a/meta/recipes-devtools/linuxdoc-tools/linuxdoc-tools-native_0.9.69.bb
+++ b/meta/recipes-devtools/linuxdoc-tools/linuxdoc-tools-native_0.9.69.bb
@@ -4,7 +4,7 @@  HOMEPAGE = "http://packages.debian.org/linuxdoc-tools"
 LICENSE = "GPLv3+"
 LIC_FILES_CHKSUM = "file://COPYING;md5=077ef64ec3ac257fb0d786531cf26931"
 
-DEPENDS = "groff-native openjade-native"
+DEPENDS = "groff-native openjade-native texinfo-native"
 
 
 SRC_URI = "${DEBIAN_MIRROR}/main/l/linuxdoc-tools/linuxdoc-tools_${PV}.orig.tar.gz \