Patchwork syslinux: add APPENDS to dependency list

login
register
mail settings
Submitter Ross Burton
Date Nov. 8, 2013, 12:16 p.m.
Message ID <1383912990-12718-1-git-send-email-ross.burton@intel.com>
Download mbox | patch
Permalink /patch/61325/
State Accepted
Commit 65ca5cb1640901211746e812d9fbbe3daafb33b7
Headers show

Comments

Ross Burton - Nov. 8, 2013, 12:16 p.m.
Changing APPENDS wasn't causing syslinux to re-run, so add a manual dependency.

Signed-off-by: Ross Burton <ross.burton@intel.com>
---
 meta/classes/syslinux.bbclass |    1 +
 1 file changed, 1 insertion(+)
Phil Blundell - Nov. 8, 2013, 12:27 p.m.
On Fri, 2013-11-08 at 12:16 +0000, Ross Burton wrote:
> Changing APPENDS wasn't causing syslinux to re-run, so add a manual dependency.

[...]

> +build_syslinux_cfg[vardeps] += "APPEND"

You mention APPENDS in the subject line and the commit message, but the
patch is actually adding APPEND (no 's').  Which is correct?

p.
Ross Burton - Nov. 8, 2013, 12:34 p.m.
On 8 November 2013 12:27, Phil Blundell <pb@pbcl.net> wrote:
> On Fri, 2013-11-08 at 12:16 +0000, Ross Burton wrote:
>> Changing APPENDS wasn't causing syslinux to re-run, so add a manual dependency.
>
> [...]
>
>> +build_syslinux_cfg[vardeps] += "APPEND"
>
> You mention APPENDS in the subject line and the commit message, but the
> patch is actually adding APPEND (no 's').  Which is correct?

Pedant. ;)

V2 incoming.

Ross

Patch

diff --git a/meta/classes/syslinux.bbclass b/meta/classes/syslinux.bbclass
index 2a5b766..62d4b7a 100644
--- a/meta/classes/syslinux.bbclass
+++ b/meta/classes/syslinux.bbclass
@@ -179,3 +179,4 @@  python build_syslinux_cfg () {
 
     cfgfile.close()
 }
+build_syslinux_cfg[vardeps] += "APPEND"